Re: [PATCH] arm64: dts: rockchip: support camera module on Haikou Video Demo on RK3399 Puma

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] arm64: dts: rockchip: missing #address-cells and #size-cells in &isp1 port@0
--

commit e8d6ac8231bd6d76f74f768d24834758e451dab4
Author: Quentin Schulz <quentin.schulz@cherry.de>

arm64: dts: rockchip: support camera module on Haikou Video Demo on RK3399 Puma

This commit adds Device Tree overlay support for the OV5675 camera sensor
and DW9714 focus lens driver on the Haikou Video Demo adapter for the
RK3399 Puma module.

> diff --git a/arch/arm64/boot/dts/rockchip/rk3399-puma-haikou-video-demo.dtso b/arch/arm64/boot/dts/rockchip/rk3399-puma-haikou-video-demo.dtso
> index 141a921a06e47..6c28e7e60ef28 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3399-puma-haikou-video-demo.dtso
> +++ b/arch/arm64/boot/dts/rockchip/rk3399-puma-haikou-video-demo.dtso

[ ... ]

> @@ -122,6 +129,50 @@ pca9670: gpio@27 {

[ ... ]

> +&isp1 {
> +	status = "okay";
> +
> +	ports {
> +		port@0 {
> +			mipi_in_cam: endpoint@0 {
> +				reg = <0>;
> +				data-lanes = <1 2>;
> +				link-frequencies = /bits/ 64 <450000000>;
> +				remote-endpoint = <&cam_output>;
> +			};
> +		};
> +	};
> +};

[Severity: Low]
Because rk3399-puma-haikou-video-demo.dtso is compiled as a standalone
Device Tree overlay before being applied to the base DTB, dtc does not see
the #address-cells and #size-cells properties defined on isp1 in
rk3399-base.dtsi.

With reg = <0> present on endpoint@0 inside port@0 without #address-cells =
<1> and #size-cells = <0> on port@0, check_reg_format(),
check_avoid_default_addr_size(), and check_graph_reg() in
scripts/dtc/checks.c emit dtc warnings during the overlay build (and
check_unit_address_vs_reg() warns on port@0 under W=1):

scripts/dtc/checks.c:check_graph_reg() {
	...
	if (node->parent->addr_cells != 1)
		FAIL_PROP(c, dti, node, get_property(node, "#address-cells"),
			  "graph node '#address-cells' is %d, must be 1",
			  node->parent->addr_cells);
	if (node->parent->size_cells != 0)
		FAIL_PROP(c, dti, node, get_property(node, "#size-cells"),
			  "graph node '#size-cells' is %d, must be 0",
			  node->parent->size_cells);
}

Should port@0 define #address-cells = <1> and #size-cells = <0> (or
reference the endpoint label directly, or include reg and cell sizes on
ports and port@0) so that compiling the overlay does not trigger dtc
warnings?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261103-rk3399-puma-haikou-video-demo-cam-v1-1-9a49d97839b5@cherry.de?part=1