From: sashiko-bot@kernel.org
To: "Kuppuswamy Sathyanarayanan"
<sathyanarayanan.kuppuswamy@linux.intel.com>
Cc: linux-pci@vger.kernel.org
Subject: Re: [PATCH v5] PCI/PME: Resume Catlow Lake Root Ports on PME with PME Status clear
Date: Tue, 03 Nov 2026 19:39:42 +0000 [thread overview]
Message-ID: <sashiko-outbox-195930@kernel.org> (raw)
In-Reply-To: <20261103193136.2410148-1-sathyanarayanan.kuppuswamy@linux.intel.com>
> Intel Catlow Lake PCH Root Ports do not set PME Status in the Root
> Status register when they generate a PME for their own hotplug event.
> The PME interrupt itself is delivered. PMEs from devices below the Root
> Port are reported correctly.
>
> PME and hotplug share the same interrupt. When a hotplug Root Port
> runtime suspends to D3hot, pciehp disables hotplug interrupts and relies
> on PME to resume the Port. On a hot-add the Port signals PME, but Root
> Status stays clear. pcie_pme_irq() then returns IRQ_NONE. pciehp_isr()
> also returns IRQ_NONE because hotplug interrupts are disabled. The Port
> stays in D3hot and the new device is never enumerated.
>
> Mark the affected Root Ports with a new PCI_DEV_FLAGS_PME_UNRELIABLE
> flag. If such a Port interrupts while not in D0 and PME Status is
> clear, pcie_pme_irq() resumes the Port. pciehp re-enables hotplug
> interrupts on runtime resume, and pciehp_check_presence() finds the new
> device. pciehp itself is unchanged.
>
> The workaround only applies to quirked Ports that are not in D0. AER,
> DPC and bandwidth notification also share the interrupt and stay enabled
> in D3hot. If one of them fires while a quirked Port is in D3hot, the
> Port is resumed without need and runtime suspends again later.
>
> This affects all steppings of the Catlow Lake PCH. A public erratum is
> not available yet.
>
> Suggested-by: Lukas Wunner <lukas@wunner.de>
> Link: https://lore.kernel.org/linux-pci/ara-_IPXV_i90if1@wunner.de/
> Signed-off-by: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261103193136.2410148-1-sathyanarayanan.kuppuswamy@linux.intel.com?part=1
next prev parent reply other threads:[~2026-11-03 19:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-03 19:31 [PATCH v5] PCI/PME: Resume Catlow Lake Root Ports on PME with PME Status clear Kuppuswamy Sathyanarayanan
2026-11-03 19:39 ` sashiko-bot [this message]
2026-11-04 14:24 ` Rafael J. Wysocki (Intel)
2026-11-16 11:27 ` Lukas Wunner
2026-11-16 16:06 ` Kuppuswamy Sathyanarayanan
2026-11-16 16:43 ` Lukas Wunner
2026-11-16 21:45 ` Kuppuswamy Sathyanarayanan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-195930@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=sathyanarayanan.kuppuswamy@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.