From: sashiko-bot@kernel.org
To: "Wentao Liang" <vulab@iscas.ac.cn>
Cc: linux-usb@vger.kernel.org
Subject: Re: [PATCH] usb: typec: thunderbolt: release a non-Thunderbolt cable plug
Date: Wed, 04 Nov 2026 02:26:16 +0000 [thread overview]
Message-ID: <sashiko-outbox-196458@kernel.org> (raw)
In-Reply-To: <20261104021516.1468625-1-vulab@iscas.ac.cn>
> tbt_ready() takes a reference on each cable plug with
> typec_altmode_get_plug() and keeps it in tbt->plug[] for the lifetime of
> the alternate mode. When a plug reports an SVID other than Thunderbolt,
> the loop breaks without storing the plug, so the reference taken for it
> is never dropped.
>
> Put that plug before leaving the loop on the SVID mismatch path.
>
> Fixes: 100e25738659 ("usb: typec: Add driver for Thunderbolt 3 Alternate Mode")
> Cc: stable@vger.kernel.org
> Assisted-by: DeepSeek-V4.1-Flash and OpenAI Codex
> Signed-off-by: Wentao Liang <vulab@iscas.ac.cn>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261104021516.1468625-1-vulab@iscas.ac.cn?part=1
next prev parent reply other threads:[~2026-11-04 2:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-04 2:15 [PATCH] usb: typec: thunderbolt: release a non-Thunderbolt cable plug Wentao Liang
2026-11-04 2:26 ` sashiko-bot [this message]
2026-11-06 17:42 ` Heikki Krogerus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-196458@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=vulab@iscas.ac.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.