From: sashiko-bot@kernel.org
To: "Wentao Liang" <vulab@iscas.ac.cn>
Cc: linux-serial@vger.kernel.org
Subject: Re: [PATCH] serial: meson: unregister the UART driver if port registration fails
Date: Wed, 04 Nov 2026 02:26:22 +0000 [thread overview]
Message-ID: <sashiko-outbox-196460@kernel.org> (raw)
In-Reply-To: <20261104021501.1468500-1-vulab@iscas.ac.cn>
> meson_uart_probe() registers the shared uart_driver on the first port and
> relies on meson_uart_remove() to unregister it once the last port is
> removed. If uart_add_one_port() fails, probe returns an error, so remove
> is never called and the driver stays registered, leaking its tty driver
> and per-port state.
>
> Remember whether this probe registered the driver and unregister it again
> when adding the port fails.
>
> Fixes: e71aab9d6132 ("tty: serial: meson: apply ttyS devname instead of ttyAML for new SoCs")
> Cc: stable@vger.kernel.org
> Assisted-by: DeepSeek-V4.1-Flash and OpenAI Codex
> Signed-off-by: Wentao Liang <vulab@iscas.ac.cn>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261104021501.1468500-1-vulab@iscas.ac.cn?part=1
next prev parent reply other threads:[~2026-11-04 2:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-04 2:15 [PATCH] serial: meson: unregister the UART driver if port registration fails Wentao Liang
2026-11-04 2:15 ` Wentao Liang
2026-11-04 2:26 ` sashiko-bot [this message]
2026-11-04 7:02 ` Jiri Slaby
2026-11-04 7:02 ` Jiri Slaby
2026-11-04 10:49 ` Greg Kroah-Hartman
2026-11-04 10:49 ` Greg Kroah-Hartman
2026-11-04 8:45 ` Neil Armstrong
2026-11-04 8:45 ` Neil Armstrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-196460@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=vulab@iscas.ac.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.