From: sashiko-bot@kernel.org
To: "Wentao Liang" <vulab@iscas.ac.cn>
Cc: v9fs@lists.linux.dev
Subject: Re: [PATCH] 9p: put the request on a duplicate RDMA reply
Date: Wed, 04 Nov 2026 02:38:10 +0000 [thread overview]
Message-ID: <sashiko-outbox-196506@kernel.org> (raw)
In-Reply-To: <20261104022806.1484080-1-vulab@iscas.ac.cn>
> recv_done() gets a reference on the request from p9_tag_lookup(), which
> the normal path hands over to p9_client_cb() and that puts it. The
> duplicate reply path jumps to err_out without calling p9_client_cb(), so
> the reference taken by the lookup is never dropped and the request, its
> tag and its buffers are leaked. A duplicated reply for a request that is
> still in the idr is exactly what this path is here to handle, so drop
> the reference before bailing out.
>
> Fixes: 728356dedeff ("9p: Add refcount to p9_req_t")
> Cc: stable@vger.kernel.org
> Assisted-by: DeepSeek-V4.1-Flash and OpenAI Codex
> Signed-off-by: Wentao Liang <vulab@iscas.ac.cn>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261104022806.1484080-1-vulab@iscas.ac.cn?part=1
next prev parent reply other threads:[~2026-11-04 2:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-04 2:28 [PATCH] 9p: put the request on a duplicate RDMA reply Wentao Liang
2026-11-04 2:38 ` sashiko-bot [this message]
2026-11-04 7:11 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-196506@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=v9fs@lists.linux.dev \
--cc=vulab@iscas.ac.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.