All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Nathan Lynch" <nathan.lynch@amd.com>
Cc: linux-pci@vger.kernel.org
Subject: Re: [PATCH v4 08/25] dmaengine: sdxi: Introduce submission queue
Date: Wed, 04 Nov 2026 02:56:32 +0000	[thread overview]
Message-ID: <sashiko-outbox-196550@kernel.org> (raw)
In-Reply-To: <20261103-sdxi-base-v4-8-3668ccc7aab8@amd.com>

> From: Nathan Lynch <nathan.lynch@amd.com>
> 
> Add the sdxi_sq (submission queue) type and APIs that act on it. The
> sq contains three control structures shared with hardware: descriptor
> ring, write index, and context status block (which contains the read
> index). Define the hardware context-status and generic descriptor
> layouts, including assertions for their sizes.
> 
> The descriptor ring requires only 64-byte alignment, so it's practical
> to implement it as a flexible array member. The write index and context
> status are small enough to place in the struct as well, so we have a
> single DMA coherent allocation to manage.
> 
> Signed-off-by: Nathan Lynch <nathan.lynch@amd.com>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261103-sdxi-base-v4-0-3668ccc7aab8@amd.com?part=8


  reply	other threads:[~2026-11-04  2:56 UTC|newest]

Thread overview: 82+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-04  2:49 [PATCH v4 00/25] dmaengine: Smart Data Accelerator Interface (SDXI) basic support Nathan Lynch
2026-11-04  2:49 ` Nathan Lynch via B4 Relay
2026-11-04  2:49 ` [PATCH v4 01/25] PCI: Add SNIA SDXI accelerator sub-class Nathan Lynch
2026-11-04  2:49   ` Nathan Lynch via B4 Relay
2026-11-04  2:55   ` sashiko-bot
2026-11-05 18:10   ` Frank Li
2026-11-05 18:25     ` Lynch, Nathan
2026-11-04  2:49 ` [PATCH v4 02/25] MAINTAINERS: Add entry for SDXI driver Nathan Lynch
2026-11-04  2:49   ` Nathan Lynch via B4 Relay
2026-11-04  2:49 ` [PATCH v4 03/25] dmaengine: sdxi: Add PCI initialization Nathan Lynch
2026-11-04  2:49   ` Nathan Lynch via B4 Relay
2026-11-04  2:56   ` sashiko-bot
2026-11-05 17:59   ` Frank Li
2026-11-05 18:07     ` Lynch, Nathan
2026-11-04  2:49 ` [PATCH v4 04/25] dmaengine: sdxi: Prepare function and sanitize MMIO state Nathan Lynch
2026-11-04  2:49   ` Nathan Lynch via B4 Relay
2026-11-04  3:06   ` sashiko-bot
2026-11-04  2:49 ` [PATCH v4 05/25] dmaengine: sdxi: Feature discovery and initial configuration Nathan Lynch
2026-11-04  2:49   ` Nathan Lynch via B4 Relay
2026-11-04  2:54   ` sashiko-bot
2026-11-04  2:49 ` [PATCH v4 06/25] dmaengine: sdxi: Configure context tables Nathan Lynch
2026-11-04  2:49   ` Nathan Lynch via B4 Relay
2026-11-04  2:55   ` sashiko-bot
2026-11-04  2:49 ` [PATCH v4 07/25] dmaengine: sdxi: Allocate context control DMA pool Nathan Lynch
2026-11-04  2:49   ` Nathan Lynch via B4 Relay
2026-11-04  2:54   ` sashiko-bot
2026-11-04  2:49 ` [PATCH v4 08/25] dmaengine: sdxi: Introduce submission queue Nathan Lynch
2026-11-04  2:49   ` Nathan Lynch via B4 Relay
2026-11-04  2:56   ` sashiko-bot [this message]
2026-11-04  2:49 ` [PATCH v4 09/25] dmaengine: sdxi: Allocate administrative context Nathan Lynch
2026-11-04  2:49   ` Nathan Lynch via B4 Relay
2026-11-04  2:56   ` sashiko-bot
2026-11-04  2:49 ` [PATCH v4 10/25] dmaengine: sdxi: Install " Nathan Lynch
2026-11-04  2:49   ` Nathan Lynch via B4 Relay
2026-11-04  2:58   ` sashiko-bot
2026-11-04  2:49 ` [PATCH v4 11/25] dmaengine: sdxi: Start functions on probe, stop on remove Nathan Lynch
2026-11-04  2:49   ` Nathan Lynch via B4 Relay
2026-11-04  3:04   ` sashiko-bot
2026-11-04  2:49 ` [PATCH v4 12/25] dmaengine: sdxi: Add client context allocation API Nathan Lynch
2026-11-04  2:49   ` Nathan Lynch via B4 Relay
2026-11-04  3:02   ` sashiko-bot
2026-11-04  2:49 ` [PATCH v4 13/25] dmaengine: sdxi: Add descriptor ring management Nathan Lynch
2026-11-04  2:49   ` Nathan Lynch via B4 Relay
2026-11-04  3:08   ` sashiko-bot
2026-11-04  2:49 ` [PATCH v4 14/25] dmaengine: sdxi: Add unit tests for descriptor ring reservations Nathan Lynch
2026-11-04  2:49   ` Nathan Lynch via B4 Relay
2026-11-04  3:02   ` sashiko-bot
2026-11-04  2:49 ` [PATCH v4 15/25] dmaengine: sdxi: Per-context access key (AKey) table entry allocator Nathan Lynch
2026-11-04  2:49   ` Nathan Lynch via B4 Relay
2026-11-04  2:59   ` sashiko-bot
2026-11-04  2:49 ` [PATCH v4 16/25] dmaengine: sdxi: Add completion status block API Nathan Lynch
2026-11-04  2:49   ` Nathan Lynch via B4 Relay
2026-11-04  2:59   ` sashiko-bot
2026-11-04  2:49 ` [PATCH v4 17/25] dmaengine: sdxi: Add unit tests for completion pool ownership Nathan Lynch
2026-11-04  2:49   ` Nathan Lynch via B4 Relay
2026-11-04  3:00   ` sashiko-bot
2026-11-04  2:49 ` [PATCH v4 18/25] dmaengine: sdxi: Add context submission helper Nathan Lynch
2026-11-04  2:49   ` Nathan Lynch via B4 Relay
2026-11-04  3:01   ` sashiko-bot
2026-11-04  2:50 ` [PATCH v4 19/25] dmaengine: sdxi: Encode context start, stop, update, and sync descriptors Nathan Lynch
2026-11-04  2:50   ` Nathan Lynch via B4 Relay
2026-11-04  3:01   ` sashiko-bot
2026-11-05 16:52   ` Tycho Andersen
2026-11-04  2:50 ` [PATCH v4 20/25] dmaengine: sdxi: Add client context release with update and sync Nathan Lynch
2026-11-04  2:50   ` Nathan Lynch via B4 Relay
2026-11-04  3:12   ` sashiko-bot
2026-11-04  2:50 ` [PATCH v4 21/25] dmaengine: sdxi: Provide context start and stop APIs Nathan Lynch
2026-11-04  2:50   ` Nathan Lynch via B4 Relay
2026-11-04  3:04   ` sashiko-bot
2026-11-04  2:50 ` [PATCH v4 22/25] dmaengine: sdxi: Encode copy and interrupt descriptors Nathan Lynch
2026-11-04  2:50   ` Nathan Lynch via B4 Relay
2026-11-04  3:07   ` sashiko-bot
2026-11-05 17:00   ` Tycho Andersen
2026-11-04  2:50 ` [PATCH v4 23/25] dmaengine: sdxi: Add unit tests for descriptor encoding Nathan Lynch
2026-11-04  2:50   ` Nathan Lynch via B4 Relay
2026-11-04  3:05   ` sashiko-bot
2026-11-04  2:50 ` [PATCH v4 24/25] dmaengine: sdxi: MSI/MSI-X vector allocation and mapping Nathan Lynch
2026-11-04  2:50   ` Nathan Lynch via B4 Relay
2026-11-04  3:15   ` sashiko-bot
2026-11-04  2:50 ` [PATCH v4 25/25] dmaengine: sdxi: Add DMA engine provider Nathan Lynch
2026-11-04  2:50   ` Nathan Lynch via B4 Relay
2026-11-04  3:24   ` sashiko-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-196550@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=nathan.lynch@amd.com \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.