Re: [PATCH v17 1/3] dt-bindings: perf: Add Broadcom Raspberry Pi AXI PMU definition

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dt-bindings: perf: invalid plain scalar colon in brcm,bcm2835-axiperf.yaml
--

commit 585240cf0e14c8ec2eefa09a1ecc59a1d82cc72f
Author: Ian Rogers <irogers@google.com>

dt-bindings: perf: Add Broadcom Raspberry Pi AXI PMU definition

This commit adds the Device Tree binding schema for the Broadcom Raspberry Pi
AXI PMU block on BCM2835, BCM2711, and BCM2712 SoCs.

> diff --git a/Documentation/devicetree/bindings/perf/brcm,bcm2835-axiperf.yaml b/Documentation/devicetree/bindings/perf/brcm,bcm2835-axiperf.yaml
> new file mode 100644
> index 0000000000000..2f1f4f286ab57
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/perf/brcm,bcm2835-axiperf.yaml
> @@ -0,0 +1,44 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/perf/brcm,bcm2835-axiperf.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Broadcom BCM2835/2711/2712 AXI Performance Monitor
> +
> +maintainers:
> +  - Ian Rogers <irogers@google.com>
> +
> +description:
> +  The Broadcom BCM2835 series (including BCM2711 and BCM2712) features hardware
> +  performance monitors on the AXI bus for evaluating memory bandwidth and
> +  system traffic. Two monitor register blocks are present: the primary monitor
> +  evaluates the System fabric, while the secondary monitor evaluates the
> +  VideoCore VPU fabric. This block is distinct from the BCM5301X AXI Trace
> +  Module.

[Severity: Low]
In Documentation/devicetree/bindings/perf/brcm,bcm2835-axiperf.yaml, the
top-level description property is written as an unquoted multi-line plain
scalar and contains a colon followed by a space in "present: the primary
monitor".

In YAML 1.2, a colon followed by whitespace inside a plain scalar is parsed
as a mapping value indicator, which causes make dt_binding_check and yamllint
to fail with a syntax error ("mapping values are not allowed here").

Should description use a block scalar indicator (such as description: |) or
avoid the colon followed by a space?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261104030300.1140180-1-irogers@google.com?part=1