Re: [PATCH v8 5/6] IB/isert: do not build a new isert_device for a device being removed

[sashiko-bot@kernel.org]

> isert_device_get() looks the device up by node_guid and has no reason to
> refuse one.  A CONNECT_REQUEST arriving while isert_remove_one() runs
> therefore builds a new isert_device on an ib_device the core is about to
> free, and nothing waits for its QP, CQ or PD.  cma_process_remove() waits
> only for id destruction, and the core takes no device reference for them,
> so ib_dealloc_device() can run while they are still being released.
> 
> node_guid is also the wrong key.  Two ib_devices can share one, and an
> isert_device holds the PD and the DMA mappings of the device it was built
> on, while isert_remove_one() looks it up by the ib_device pointer.
> 
> Let the ib_client data say whether a device may be used, and match the
> ib_device pointer.  isert_add_one() stores a non-NULL value,
> isert_remove_one() clears it, and isert_device_get() refuses a device
> whose data is NULL.  The clear, the lookup, the reference and the removing
> [ ... ]
> 
> Fixes: b8d26b3be8b3 ("iser-target: Add iSCSI Extensions for RDMA (iSER) target driver")
> Fixes: 63b268d232b8 ("IB/isert: Properly release resources on DEVICE_REMOVAL")
> Cc: stable@vger.kernel.org
> Signed-off-by: Yehyeong Lee <yhlee@isslab.korea.ac.kr>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261104040318.1844865-1-yhlee@isslab.korea.ac.kr?part=5