Re: [PATCH v2 30/30] crypto: sa2ul - add SA3UL_CM AES support

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] crypto: sa2ul: missing kernel-doc entry for aes_cm in struct sa_crypto_data
--

commit bbd9935e2ba3dc8e6f81dc7c3285e99df2e66513
Author: Manorit Chawdhry <m-chawdhry@ti.com>

crypto: sa2ul - add SA3UL_CM AES support

This commit adds support for SA3UL_CM revision 3.1 by deriving an extra
key-schedule round 15 for AES-256 decryption and running a TRNG-seeded
AES-ECB priming operation during probe before registering algorithms.

> diff --git a/drivers/crypto/sa2ul.h b/drivers/crypto/sa2ul.h
> index ba3fb91daaa49..199eff4467d79 100644
> --- a/drivers/crypto/sa2ul.h
> +++ b/drivers/crypto/sa2ul.h
> @@ -194,6 +194,8 @@ struct sa_crypto_data {
>  	spinlock_t		request_lock; /* request admission */
>  	struct mutex		dma_lock; /* DMA setup and cancellation */
>  	bool			stopping;
> +	/* true if HW is SA3UL_CM (SA_REVISION major=3 minor=1) */
> +	bool aes_cm;
>  };

[Severity: Low]
This isn't a bug, but struct sa_crypto_data in drivers/crypto/sa2ul.h has a
kernel-doc comment block above it documenting its members. Should @aes_cm be
added to that kernel-doc comment so that running scripts/kernel-doc or
building with W=1 does not emit a warning?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261104-b4-upstream-sa2ul-cleanup-v2-0-15ab90b3f9c2@ti.com?part=30