From: sashiko-bot@kernel.org
To: "Joseph Telaak" <joseph@telaak.dev>
Cc: devicetree@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH 1/4] dt-bindings: mips: Add Siflower SF19A2890 based boards
Date: Wed, 04 Nov 2026 07:22:46 +0000 [thread overview]
Message-ID: <sashiko-outbox-196784@kernel.org> (raw)
In-Reply-To: <20261104-sf19a2890-mips-v1-1-eae80820af68@telaak.dev>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dt-bindings: mips: dangling drivers/gpio/gpio-siflower.c in MAINTAINERS
--
commit bd8c11a7f9d608cf21a8f34b06b16b91d2058197
Author: Joseph Telaak <joseph@telaak.dev>
dt-bindings: mips: Add Siflower SF19A2890 based boards
This commit adds the device tree binding schema for Siflower SF19A2890
MIPS SoC based boards, including the GL.iNet GL-SFT1200, and adds a
corresponding entry in MAINTAINERS.
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 93abbb315065d..2a7a083f2c470 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -25698,6 +25698,14 @@ N: sifive
> K: fu[57]40
> K: [^@]sifive
>
> +SIFLOWER SF19A2890 SOC SUPPORT
> +M: Joseph Telaak <joseph@telaak.dev>
> +L: linux-mips@vger.kernel.org
> +S: Maintained
> +F: Documentation/devicetree/bindings/mips/siflower.yaml
> +F: drivers/gpio/gpio-siflower.c
[Severity: Low]
Should the F: entry for drivers/gpio/gpio-siflower.c be deferred until
the commit that actually adds that driver?
Because drivers/gpio/gpio-siflower.c does not exist in the repository yet,
running scripts/get_maintainer.pl --self-test=patterns triggers a warning
in self_test() when checking the SIFLOWER SF19A2890 SOC SUPPORT section in
MAINTAINERS:
MAINTAINERS: warning: no file matches F: drivers/gpio/gpio-siflower.c
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261104-sf19a2890-mips-v1-0-eae80820af68@telaak.dev?part=1
next prev parent reply other threads:[~2026-11-04 7:22 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-04 7:16 [PATCH 0/4] MIPS: Add support for the Siflower SF19A2890 Joseph Telaak
2026-11-04 7:16 ` Joseph Telaak via B4 Relay
2026-11-04 7:16 ` [PATCH 1/4] dt-bindings: mips: Add Siflower SF19A2890 based boards Joseph Telaak
2026-11-04 7:16 ` Joseph Telaak via B4 Relay
2026-11-04 7:22 ` sashiko-bot [this message]
2026-11-05 0:06 ` Conor Dooley
2026-11-05 1:11 ` Joseph Telaak
2026-11-04 7:16 ` [PATCH 2/4] MIPS: Add support for Siflower MIPS SoCs Joseph Telaak
2026-11-04 7:16 ` Joseph Telaak via B4 Relay
2026-11-04 7:16 ` [PATCH 3/4] MIPS: dts: Add Siflower SF19A2890 and GL.iNet GL-SFT1200 Joseph Telaak
2026-11-04 7:16 ` Joseph Telaak via B4 Relay
2026-11-04 7:16 ` [PATCH 4/4] MIPS: configs: Add sf19a2890_defconfig Joseph Telaak
2026-11-04 7:16 ` Joseph Telaak via B4 Relay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-196784@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=joseph@telaak.dev \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.