Re: [PATCH 03/10] ARM: dts: imx6ulz: Enable RNGB on BSH SMM-M2

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] ARM: dts: imx6ulz: redundant status override on already-enabled rngb node
--

commit b4e06771ac0019a530bbaccfe9a26a1cf41ddf74
Author: Leonhard Hesse <leonhard.hesse@bshg.com>

ARM: dts: imx6ulz: Enable RNGB on BSH SMM-M2

This commit adds a status override to enable the rngb node in the BSH SMM-M2
device tree.

> diff --git a/arch/arm/boot/dts/nxp/imx/imx6ulz-bsh-smm-m2.dts b/arch/arm/boot/dts/nxp/imx/imx6ulz-bsh-smm-m2.dts
> index aac211a9f9ebd..39b7ee585860f 100644
> --- a/arch/arm/boot/dts/nxp/imx/imx6ulz-bsh-smm-m2.dts
> +++ b/arch/arm/boot/dts/nxp/imx/imx6ulz-bsh-smm-m2.dts
> @@ -30,6 +30,10 @@ &gpmi {
>  	status = "okay";
>  };
>  
> +&rngb {
> +	status = "okay";
> +};

[Severity: Low]
Is this status override for &rngb in
arch/arm/boot/dts/nxp/imx/imx6ulz-bsh-smm-m2.dts needed?

arch/arm/boot/dts/nxp/imx/imx6ulz-bsh-smm-m2.dts includes imx6ulz.dtsi,
which in turn includes arch/arm/boot/dts/nxp/imx/imx6ull.dtsi where the
rngb node is defined without a status property:

    rngb: rng@2284000 {
        compatible = "fsl,imx6ull-rngb", "fsl,imx25-rngb";
        reg = <0x02284000 0x4000>;
        interrupts = <GIC_SPI 6 IRQ_TYPE_LEVEL_HIGH>;
        clocks = <&clks IMX6UL_CLK_DUMMY>;
    };

Because neither imx6ull.dtsi nor imx6ulz.dtsi sets status = "disabled" on
rngb, __of_device_is_available() in drivers/of/base.c already treats the
node as enabled by default, making this change a functional no-op.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261104-add-bsh-smm-m2-v1-0-369f0a77e021@cn.bosch.com?part=3