Re: [PATCH bpf-next 2/2] selftests/bpf: Test local storage max value size

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] selftests/bpf: non-standard multi-line comment above find_max_value_size()
--

commit 1da8998ccd74b6171959f2da642b888d3db302bd
Author: Jonathan Bastari Thamrin <thamrinjonathan@gmail.com>

selftests/bpf: Test local storage max value size

This commit adds a selftest in task_local_storage.c that uses binary search
to find the largest value size accepted for a task storage map, verifies the
size is at least 4096 bytes, and checks that an element of that size can be
stored.

> diff --git a/tools/testing/selftests/bpf/prog_tests/task_local_storage.c b/tools/testing/selftests/bpf/prog_tests/task_local_storage.c
> index 5b2b56cc3a4f3..c7e9fa6743b93 100644
> --- a/tools/testing/selftests/bpf/prog_tests/task_local_storage.c
> +++ b/tools/testing/selftests/bpf/prog_tests/task_local_storage.c
> @@ -495,6 +495,91 @@ static void test_uptr_map_failure(const char *map_name, int expected_errno)

[ ... ]

> +/* Return the largest value_size the kernel accepts for a local storage
> + * map, or -1 on an unexpected error.
> + */
> +static int find_max_value_size(void)

[Severity: Low]
This isn't a bug, but in BPF selftests, should the multi-line comment above
find_max_value_size() in tools/testing/selftests/bpf/prog_tests/task_local_storage.c
place the opening /* on its own line with the comment text starting on the
next line?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261104-local-storage-max-v1-0-c836731bd184@gmail.com?part=2