From: sashiko-bot@kernel.org
To: "Ali Tariq" <alitariq45892@gmail.com>, linux-pci@vger.kernel.org
Subject: Re: [PATCH] PCI: spacemit: Ignore PERST# bit for controllers
Date: Wed, 04 Nov 2026 14:13:59 +0000 [thread overview]
Message-ID: <sashiko-outbox-197414@kernel.org> (raw)
In-Reply-To: <20261104140750.761330-1-alitariq45892@gmail.com>
> The k1_pcie_init() does not set PCIE_IGNORE_PERSTN bit of the
> control logic register, which causes controller to reset itself once
> PERST# signal is asserted even when acting as host.
> On Orange Pi RV2 (SpacemiT K1), this resets the controller and wipes
> the IDs. k1_pcie_deinit() leaves PERST# asserted, so when k1_pcie_init()
> runs again, its first DBI access hangs the CPU.
>
> Set PCIE_IGNORE_PERSTN bit of the control logic register of APMU
> in k1_pcie_init() before enabling resources so controllers
> dont end up resetting themselves when PERST# signal is asserted.
>
> Fixes: ff64e078e45f ("PCI: spacemit: Add SpacemiT PCIe host driver")
> Signed-off-by: Ali Tariq <alitariq45892@gmail.com>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261104140750.761330-1-alitariq45892@gmail.com?part=1
next prev parent reply other threads:[~2026-11-04 14:14 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-04 14:07 [PATCH] PCI: spacemit: Ignore PERST# bit for controllers Ali Tariq
2026-11-04 14:07 ` Ali Tariq
2026-11-04 14:13 ` sashiko-bot [this message]
2026-11-04 14:14 ` Troy Mitchell
2026-11-04 14:14 ` Troy Mitchell
2026-11-04 15:38 ` Ali Tariq
2026-11-04 15:38 ` Ali Tariq
2026-11-05 3:19 ` Encrow Thorne
2026-11-05 3:19 ` Encrow Thorne
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-197414@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=alitariq45892@gmail.com \
--cc=linux-pci@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.