Re: [PATCH v15 2/2] arm64: dts: rockchip: Add ALIENTEK QuarkPi-CA2

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] arm64: dts: rockchip: duplicate headphone DAPM routes in quarkpi-ca2
--

commit d54c424e615a629ab7734226a9aad65a4ab9cdd8
Author: Bob Hui <bg9oxa@163.com>

arm64: dts: rockchip: Add ALIENTEK QuarkPi-CA2

This commit adds a device tree for the ALIENTEK QuarkPi-CA2, an RK3588S-based
card computer, describing its regulators, storage, display, USB, networking,
and audio peripherals.

> diff --git a/arch/arm64/boot/dts/rockchip/rk3588s-quarkpi-ca2.dts b/arch/arm64/boot/dts/rockchip/rk3588s-quarkpi-ca2.dts
> new file mode 100644
> index 0000000000000..18b7e639076ab
> --- /dev/null
> +++ b/arch/arm64/boot/dts/rockchip/rk3588s-quarkpi-ca2.dts
> @@ -0,0 +1,1240 @@

[ ... ]

> +	analog_sound: analog-sound {
> +		compatible = "simple-audio-card";
> +		pinctrl-names = "default";
> +		pinctrl-0 = <&hp_det>;
> +		simple-audio-card,name = "QuarkPi-CA2 ES8388";
> +		simple-audio-card,format = "i2s";
> +		simple-audio-card,bitclock-master = <&sound_cpu>;
> +		simple-audio-card,frame-master = <&sound_cpu>;
> +		simple-audio-card,mclk-fs = <256>;
> +		simple-audio-card,aux-devs = <&hp_amp>;
> +		simple-audio-card,hp-det-gpios = <&gpio1 RK_PC4 GPIO_ACTIVE_HIGH>;
> +		simple-audio-card,pin-switches = "Headphones", "Headset Mic";
> +		simple-audio-card,widgets =
> +			"Headphone", "Headphones",
> +			"Microphone", "Headset Mic";
> +		simple-audio-card,routing =
> +			"Headphones", "LOUT1",
> +			"Headphones", "ROUT1",
> +			"Headphones", "Headphone Power OUTL",
> +			"Headphones", "Headphone Power OUTR",
> +			"Headphone Power INL", "LOUT1",
> +			"Headphone Power INR", "ROUT1",
> +			"LINPUT1", "Headset Mic",
> +			"RINPUT1", "Headset Mic";
> +
> +		sound_codec: simple-audio-card,codec {
> +			sound-dai = <&es8388>;
> +			system-clock-frequency = <12288000>;
> +		};
> +
> +		sound_cpu: simple-audio-card,cpu {
> +			sound-dai = <&i2s0_8ch>;
> +		};
> +	};
> +
> +	hp_amp: audio-amplifier {
> +		compatible = "simple-audio-amplifier";
> +		enable-gpios = <&gpio1 RK_PC6 GPIO_ACTIVE_HIGH>;
> +		pinctrl-names = "default";
> +		pinctrl-0 = <&hp_con>;
> +		sound-name-prefix = "Headphone Power";
> +	};

[Severity: Low]
As reported by Sashiko on v14 [1], in analog_sound, simple-audio-card,routing
connects LOUT1 and ROUT1 through the hp_amp simple-audio-amplifier widget
("Headphone Power INL" / "Headphone Power INR" -> "Headphone Power OUTL" /
"Headphone Power OUTR" -> "Headphones"), which internally routes INL and INR
through the DRV widget to OUTL and OUTR.

However, simple-audio-card,routing also connects LOUT1 and ROUT1 directly to
Headphones:

	"Headphones", "LOUT1",
	"Headphones", "ROUT1",

Should these two direct routes be removed so that the DAPM graph does not
define a parallel unamplified path bypassing the Headphone Power amplifier?

[1] https://lore.kernel.org/r/20261103-quarkpi-ca2-v14-2-290990440b67@163.com

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261105-quarkpi-ca2-v15-0-2347608d717a@163.com?part=2