Re: [PATCH net-next 10/15] net/mlx5: LAG, do not add a device to an already-active LAG

[sashiko-bot@kernel.org]

> From: Shay Drory <shayd@nvidia.com>
> 
> mlx5_ldev_add_mdev() would add a newly probed device to the LAG even
> when the LAG is already active, mutating membership while getters may be
> iterating it and while the active mapping assumes a fixed member set.
> 
> Reject the join when the group's LAG is active:
> __mlx5_lag_dev_add_mdev() returns -EOPNOTSUPP, and mlx5_lag_add_mdev()
> treats that as terminal - unregister the HCA devcom component and leave
> the device standalone, rather than the -EAGAIN retry used for the
> bounded mode-change window.
> The device stays out of the LAG until it is reprobed.
> 
> This keeps LAG membership stable while active. It is a no-op for
> existing configurations, where no device is added to a LAG once it is
> active.
> 
> In addition, do not register the eswitch devcom component of such a
> device, so it does not pair with the eswitches of the LAG members.
> 
> Signed-off-by: Shay Drory <shayd@nvidia.com>
> Reviewed-by: Mark Bloch <mbloch@nvidia.com>
> Reviewed-by: Moshe Shemesh <moshe@nvidia.com>
> Signed-off-by: Tariq Toukan <tariqt@nvidia.com>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261103171009.563034-1-tariqt@nvidia.com?part=10