Re: [PATCH 2/5] svcrdma: drop the extra reference on the backchannel transport

[sashiko-bot@kernel.org]

> From: Wentao Liang <vulab@iscas.ac.cn>
> 
> Beyond the reference xprt_alloc() returns to the caller,
> xprt_setup_rdma_bc() takes two more on the new rpc_xprt: one for the
> xpt_bc_xprt link, which svc_xprt_free() drops, and a second whose put
> was in __svc_rdma_free(). Commit 729580ddc53e ("svcrdma: xpt_bc_xprt
> is already clear in __svc_rdma_free()") removed that put as a
> duplicate of the one in svc_xprt_free(), but left the matching
> xprt_get() in place. The second reference is therefore never
> released: the rpc_xprt outlives the callback client and the
> connection, and the net namespace reference taken by xprt_alloc()
> leaks along with the rpc_xprt.
> 
> Take only the reference that svc_xprt_free() releases, as
> xs_setup_bc_tcp() does.
> 
> Fixes: 729580ddc53e ("svcrdma: xpt_bc_xprt is already clear in __svc_rdma_free()")
> Cc: stable@vger.kernel.org
> Assisted-by: DeepSeek-V4.1-Flash and OpenAI Codex
> Signed-off-by: Wentao Liang <vulab@iscas.ac.cn>
> Link: https://patch.msgid.link/20261104022813.1484267-1-vulab@iscas.ac.cn
> Signed-off-by: Chuck Lever <cel@kernel.org>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261104-liange-v1-0-f097e10cea1b@kernel.org?part=2