All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Tapio Reijonen" <tapio.reijonen@vaisala.com>
Cc: linux-serial@vger.kernel.org
Subject: Re: [PATCH v2 3/3] serial: core: Drive the transceiver interface select GPIO
Date: Thu, 05 Nov 2026 07:26:17 +0000	[thread overview]
Message-ID: <sashiko-outbox-198666@kernel.org> (raw)
In-Reply-To: <20261105-serial-rs485-mode-gpio-v2-3-027e5348892f@vaisala.com>

> Multiprotocol transceivers such as the LTC2873 provide both an RS232
> and an RS485 interface on the same bus pins and choose between them
> with an interface select input. There is no generic way to drive that
> input today, so a port wired to such a transceiver is stuck in
> whichever interface the pin is strapped to.
> 
> Add the optional rs485-select-gpios property to the GPIOs acquired by
> uart_get_rs485_mode() and drive it from the RS485 configuration state:
> the GPIO is active while RS485 is enabled, which selects the RS485
> interface, and inactive otherwise, which selects the alternative
> interface, typically RS232. RS422 is a mode of SER_RS485_ENABLED and
> therefore selects the RS485 interface as well.
> 
> The state is applied in uart_rs485_config() for the boot-time and
> resume paths and in uart_set_rs485_config() for the ioctl path. Unlike
> [ ... ]
> 
> Drivers calling uart_get_rs485_mode() need no change to support such
> transceivers.
> 
> Signed-off-by: Tapio Reijonen <tapio.reijonen@vaisala.com>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261105-serial-rs485-mode-gpio-v2-0-027e5348892f@vaisala.com?part=3


      reply	other threads:[~2026-11-05  7:26 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-05  7:12 [PATCH v2 0/3] serial: core: add transceiver interface select GPIO Tapio Reijonen
2026-11-05  7:12 ` [PATCH v2 1/3] serial: core: Forget the RS485 GPIO descriptors when a port is removed Tapio Reijonen
2026-11-05  7:25   ` sashiko-bot
2026-11-05  7:12 ` [PATCH v2 2/3] dt-bindings: serial: rs485: Add transceiver interface select GPIO Tapio Reijonen
2026-11-05  7:18   ` sashiko-bot
2026-11-05  7:12 ` [PATCH v2 3/3] serial: core: Drive the " Tapio Reijonen
2026-11-05  7:26   ` sashiko-bot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-198666@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=tapio.reijonen@vaisala.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.