Re: [PATCH v17 07/12] ALSA: virtio: retain PCM DMA buffers and validate capture completions

[sashiko-bot@kernel.org]

> Retain references to the pages backing ALSA's vmalloc buffer until its
> queued I/O messages are freed. On NOMMU systems, use driver-owned memory
> for DMA and copy playback data before submission and capture data after
> completion, so ALSA buffer release cannot invalidate an active request.
> 
> Validate the PCM buffer and each period before building scatterlists.
> Require a successful full-period response for ordinary capture before
> advancing its pointer. Each descriptor targets a fixed ring slice, so a
> short response would expose the unwritten remainder as captured data.
> 
> Require whole-byte periods whose total matches the negotiated buffer.
> Check offset, length and the final message index before indexing the
> message array, including empty transfers and arithmetic wraparound.
> 
> Seed the ordinary capture ring once per prepare. Native STOP preserves
> [ ... ]
> retire empty stopped completions without advancing capture state. Once
> an XRUN is latched, later completions only retire queue ownership. An
> out-of-order full completion reports XRUN rather than publishing an
> unwritten ring slice; this path does not reorder completed requests.
> Signed-off-by: Joonho Lee <mynameisjune111@gmail.com>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261105070845.6449-1-mynameisjune111@gmail.com?part=7