From: sashiko-bot@kernel.org
To: lirongqing <lirongqing@baidu.com>, linux-rtc@vger.kernel.org
Cc: "Alexandre Belloni" <alexandre.belloni@bootlin.com>
Subject: Re: [PATCH] rtc: interface: skip the RTC read in rtc_timer_do_work() on an empty queue
Date: Thu, 05 Nov 2026 07:47:50 +0000 [thread overview]
Message-ID: <sashiko-outbox-198697@kernel.org> (raw)
In-Reply-To: <20261105073742.2193-1-lirongqing@baidu.com>
> From: Li RongQing <lirongqing@baidu.com>
>
> After rtc_set_time(), the RTC core schedules rtc->irqwork to re-read
> the clock and reprocess the timer queue.
>
> When the timer queue is empty, there is no timer to expire and no
> next alarm to program, so reading the RTC is unnecessary. However,
> an RTC read can take up to 3ms on some systems, blocking the CPU for
> a significant amount of time. Even on faster systems, it can still
> take around 50us.
>
> Check whether the timer queue is empty under ops_lock before reading
> the RTC. If it is empty, release the lock and return immediately.
>
> Signed-off-by: Li RongQing <lirongqing@baidu.com>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261105073742.2193-1-lirongqing@baidu.com?part=1
prev parent reply other threads:[~2026-11-05 7:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-05 7:37 [PATCH] rtc: interface: skip the RTC read in rtc_timer_do_work() on an empty queue lirongqing
2026-11-05 7:47 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-198697@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=alexandre.belloni@bootlin.com \
--cc=linux-rtc@vger.kernel.org \
--cc=lirongqing@baidu.com \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.