From: sashiko-bot@kernel.org
To: "Yige Jiang" <yigejiang86@gmail.com>, linux-pci@vger.kernel.org
Subject: Re: [PATCH] PCI: switchtec: Fix PCI device reference leak on probe failure
Date: Thu, 05 Nov 2026 08:02:00 +0000 [thread overview]
Message-ID: <sashiko-outbox-198703@kernel.org> (raw)
In-Reply-To: <rc-review-20261105-vc-149-07fa7f0c8a18@gmail.com>
> stdev_create() takes a pci_dev reference for stdev->pdev. When a
> later step of switchtec_pci_probe() fails, err_put drops stdev->dev
> but omits the PCI device reference. stdev_release() only frees
> stdev, so the PCI device remains pinned after the failed probe.
>
> Return the PCI device reference before putting stdev->dev, matching
> the existing cleanup in stdev_create() and switchtec_pci_remove().
>
> Fixes: df25461119d9 ("PCI: switchtec: Fix stdev_release() crash after surprise hot remove")
> Signed-off-by: Yige Jiang <yigejiang86@gmail.com>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/rc-review-20261105-vc-149-07fa7f0c8a18@gmail.com?part=1
next prev parent reply other threads:[~2026-11-05 8:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-05 7:55 [PATCH] PCI: switchtec: Fix PCI device reference leak on probe failure Yige Jiang
2026-11-05 8:02 ` sashiko-bot [this message]
2026-11-05 17:37 ` Logan Gunthorpe
2026-11-05 19:14 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-198703@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=yigejiang86@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.