From: sashiko-bot@kernel.org
To: lirongqing <lirongqing@baidu.com>, linux-perf-users@vger.kernel.org
Subject: Re: [PATCH] perf iostat: Do not compute interval deltas a second time
Date: Thu, 05 Nov 2026 08:13:55 +0000 [thread overview]
Message-ID: <sashiko-outbox-198713@kernel.org> (raw)
In-Reply-To: <20261105080429.2472-1-lirongqing@baidu.com>
> From: Li RongQing <lirongqing@baidu.com>
>
> process_counter_values() now computes deltas directly in evsel->counts
> for global aggregation too. It saves the current cumulative raw count in
> prev_raw_counts before iostat prints the interval.
>
> Subtracting prev_raw_counts again can therefore underflow the count.
> Worse, replacing the saved raw count with the interval delta corrupts
> the baseline used to calculate the next interval.
>
> Use the already computed delta and leave prev_raw_counts untouched.
>
> Fixes: f976bc6b6bfc ("perf stat: Aggregate events using evsel->stats->aggr")
> Signed-off-by: Li RongQing <lirongqing@baidu.com>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261105080429.2472-1-lirongqing@baidu.com?part=1
next prev parent reply other threads:[~2026-11-05 8:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-05 8:04 [PATCH] perf iostat: Do not compute interval deltas a second time lirongqing
2026-11-05 8:13 ` sashiko-bot [this message]
2026-11-09 5:26 ` Namhyung Kim
2026-11-09 6:54 ` 答复: [外部邮件] " Li,Rongqing
2026-11-11 19:09 ` Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-198713@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=lirongqing@baidu.com \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.