From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2BA4E606A326 for ; Thu, 5 Nov 2026 09:01:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=t1Slj8ON; dkim=fail reason="signature verification failed" (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=Kw0M1BnE DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Reply-To:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Date:References: In-Reply-To:Cc:To:Subject:From:Message-ID:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Unsubscribe-Post:List-Owner; bh=wopSVd5xALsCuOaSIbIXFlqmZ4cme91E8giSAI8GB9Q=; b=t1Slj8ON9Rvvy9IqVSZaIYpMZg C9owm7ebDnn5MZR89FEfomdFYxDlMwGLCpQLB4StSU9USvYO0/MqCb+6+OcuAMedGb9fHhV7eHp8r 6Rj3hXLqIRtR1/nJpb7/jzZq2UlTTAL7yy9rNWCnmQBpcwNlsfW+01YDRJz7c6PBSAyBu0dlyP9Gf lmFJUCG7xZNlkuN3MHyTWuh0uTQ/9K788+QpiIhA9c/DJqPu1SEEwfn0l+jGYkNpJPNOna8ZlIqnl E/ZEavFFEHVjN1Joq+GxEJbltxsdvXyxISnE24R0Pl9cQxaxMn0PhM78x9gEjHxQeoCWN+zCN+nE2 lqDmm8VA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.100.1 #2 (Red Hat Linux)) id 1xOtLR-00000008EO3-3b6q; Thu, 05 Nov 2026 09:01:17 +0000 Received: from tor.source.kernel.org ([172.105.4.254]) by bombadil.infradead.org with esmtps (Exim 4.100.1 #2 (Red Hat Linux)) id 1xOtLQ-00000008ENs-32cJ for linux-i3c@lists.infradead.org; Thu, 05 Nov 2026 09:01:17 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id E8D1A60F2A; Thu, 5 Nov 2026 09:01:15 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4F3A91F000C1; Thu, 5 Nov 2026 09:01:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1793869275; bh=NceYa3NZayFxuHHB+QmpGXbPguwXwvX7k5dpGHlALec=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=Kw0M1BnExzPwaBnZ7Xyad9+a0J277W3l2fS0SmYCeFST97fiqz8ghyTfbT83DErZP c+bz3QVhQmO4n9lurexB72yiBKWBawHHWxKERChQENMsU10t70scHm+MnuOkUhNNaI wWP0gFa50mk1L0mur5Ph5rRhE2jNwArpY0hO0Z8GwNvohwJwnylUGcKk3CqXWBqx6/ GBiAB0BCqqGei1r224Z8F8Nsru6araoBV7c5rjmcvZfWHof6f5Nru+6+JHOtQuGiss meSfwVY7cv5kMLQCG9LAG7C/3HUklN0D6Uy9SjjZ8kVMnvY63bxh2ALbRxYnz9YCpj UDy6eTc36YmuA== Message-ID: From: sashiko-bot@kernel.org Subject: Re: [PATCH v2 2/3] i3c: dw: Track the transmit and receive buffer depths separately To: "Shubham Patil" Cc: linux-i3c@lists.infradead.org, devicetree@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org, Frank.Li@kernel.org, "Alexandre Belloni" In-Reply-To: <20261105085425.3418230-3-shubhamsanjay.patil@amd.com> References: <20261105085425.3418230-1-shubhamsanjay.patil@amd.com> <20261105085425.3418230-3-shubhamsanjay.patil@amd.com> Date: Thu, 05 Nov 2026 09:01:14 +0000 X-BeenThere: linux-i3c@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev X-Archived-By: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-i3c" X-Spam-Status: No, score=-8.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 VGhhbmsgeW91IGZvciB5b3VyIGNvbnRyaWJ1dGlvbiEgU2FzaGlrbyBBSSByZXZpZXcgZm91bmQg MSBwb3RlbnRpYWwgaXNzdWUocykgdG8gY29uc2lkZXI6Ci0gW0hpZ2hdIGkzYzogZHc6IHU4IHRy dW5jYXRpb24gb2YgcnhmaWZvZGVwdGggaW4gZHdfaTNjX2NvbW1vbl9wcm9iZSgpCi0tCgpjb21t aXQgYzkzY2M2ODQzYjU3OTkzZDA1M2RiMDNjYzNmN2NlZTI1ZGJkNDM3MQpBdXRob3I6IFNodWJo YW0gUGF0aWwgPHNodWJoYW1zYW5qYXkucGF0aWxAYW1kLmNvbT4KCmkzYzogZHc6IFRyYWNrIHRo ZSB0cmFuc21pdCBhbmQgcmVjZWl2ZSBidWZmZXIgZGVwdGhzIHNlcGFyYXRlbHkKClRoaXMgY29t bWl0IHNwbGl0cyBjYXBzLmRhdGFmaWZvZGVwdGggaW50byBjYXBzLnR4Zmlmb2RlcHRoIGFuZApj YXBzLnJ4Zmlmb2RlcHRoLCBwb3B1bGF0ZXMgY2Fwcy5yeGZpZm9kZXB0aCBmcm9tIHRoZSBRVUVV RV9TSVpFX0NBUEFCSUxJVFkKcmVnaXN0ZXIsIGFuZCBleHBvc2VzIHRoZSBGSUZPIGNhcGFjaXRp ZXMgdmlhIGJhc2UudHhfZmlmb19ieXRlcyBhbmQKYmFzZS5yeF9maWZvX2J5dGVzLgoKPiBkaWZm IC0tZ2l0IGEvZHJpdmVycy9pM2MvbWFzdGVyL2R3LWkzYy1tYXN0ZXIuYyBiL2RyaXZlcnMvaTNj L21hc3Rlci9kdy1pM2MtbWFzdGVyLmMKPiBpbmRleCBkMTExOWYyMDNkMWI2Li5kZDU0NjJiMTI5 NTE0IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvaTNjL21hc3Rlci9kdy1pM2MtbWFzdGVyLmMKPiAr KysgYi9kcml2ZXJzL2kzYy9tYXN0ZXIvZHctaTNjLW1hc3Rlci5jCj4gQEAgLTIwMyw3ICsyMDMs MTAgQEAKPiAgI2RlZmluZSBCVVNfSURMRV9USU1JTkcJCQkweGQ4Cj4gICNkZWZpbmUgSTNDX1ZF Ul9JRAkJCTB4ZTAKPiAgI2RlZmluZSBJM0NfVkVSX1RZUEUJCQkweGU0Cj4gLSNkZWZpbmUgRVhU RU5ERURfQ0FQQUJJTElUWQkJMHhlOAo+ICsjZGVmaW5lIFFVRVVFX1NJWkVfQ0FQQUJJTElUWQkJ MHhlOAo+ICsjZGVmaW5lIFFVRVVFX1NJWkVfQ0FQQUJJTElUWV9SWF9CVUYoeCkJKCgoeCkgJiBH RU5NQVNLKDcsIDQpKSA+PiA0KQo+ICsvKiBTaXplcyBhcmUgZW5jb2RlZCwgMCBtZWFuaW5nIDIg RFdPUkRzIGFuZCBldmVyeSBmdXJ0aGVyIHN0ZXAgZG91YmxpbmcgaXQuICovCj4gKyNkZWZpbmUg UVVFVUVfU0laRV9UT19EV09SRFMoeCkJCSgyVSA8PCAoeCkpCj4gICNkZWZpbmUgU0xBVkVfQ09O RklHCQkJMHhlYwo+ICAKPiAgI2RlZmluZSBEWU5fQUREUl9MT19NQVNLIEdFTk1BU0soNCwgMCkK PiBAQCAtOTc4LDggKzk4MSw4IEBAIHN0YXRpYyBpbnQgZHdfaTNjX21hc3Rlcl9pM2NfeGZlcnMo c3RydWN0IGkzY19kZXZfZGVzYyAqZGV2LAo+ICAJCQludHh3b3JkcyArPSBESVZfUk9VTkRfVVAo aTNjX3hmZXJzW2ldLmxlbiwgNCk7Cj4gIAl9Cj4gIAo+IC0JaWYgKG50eHdvcmRzID4gbWFzdGVy LT5jYXBzLmRhdGFmaWZvZGVwdGggfHwKPiAtCSAgICBucnh3b3JkcyA+IG1hc3Rlci0+Y2Fwcy5k YXRhZmlmb2RlcHRoKQo+ICsJaWYgKG50eHdvcmRzID4gbWFzdGVyLT5jYXBzLnR4Zmlmb2RlcHRo IHx8Cj4gKwkgICAgbnJ4d29yZHMgPiBtYXN0ZXItPmNhcHMucnhmaWZvZGVwdGgpCj4gIAkJcmV0 dXJuIC1FT1BOT1RTVVBQOwo+ICAKPiAgCXN0cnVjdCBkd19pM2NfeGZlciAqeGZlciBfX2ZyZWUo a2ZyZWUpID0gZHdfaTNjX21hc3Rlcl9hbGxvY194ZmVyKG1hc3RlciwgaTNjX254ZmVycyk7Cj4g QEAgLTExMzYsOCArMTEzOSw4IEBAIHN0YXRpYyBpbnQgZHdfaTNjX21hc3Rlcl9pMmNfeGZlcnMo c3RydWN0IGkyY19kZXZfZGVzYyAqZGV2LAo+ICAJCQludHh3b3JkcyArPSBESVZfUk9VTkRfVVAo aTJjX3hmZXJzW2ldLmxlbiwgNCk7Cj4gIAl9Cj4gIAo+IC0JaWYgKG50eHdvcmRzID4gbWFzdGVy LT5jYXBzLmRhdGFmaWZvZGVwdGggfHwKPiAtCSAgICBucnh3b3JkcyA+IG1hc3Rlci0+Y2Fwcy5k YXRhZmlmb2RlcHRoKQo+ICsJaWYgKG50eHdvcmRzID4gbWFzdGVyLT5jYXBzLnR4Zmlmb2RlcHRo IHx8Cj4gKwkgICAgbnJ4d29yZHMgPiBtYXN0ZXItPmNhcHMucnhmaWZvZGVwdGgpCj4gIAkJcmV0 dXJuIC1FT1BOT1RTVVBQOwo+ICAKPiAgCXN0cnVjdCBkd19pM2NfeGZlciAqeGZlciBfX2ZyZWUo a2ZyZWUpID0gZHdfaTNjX21hc3Rlcl9hbGxvY194ZmVyKG1hc3RlciwgaTJjX254ZmVycyk7Cj4g QEAgLTE3MzgsNyArMTc0MSwxNCBAQCBpbnQgZHdfaTNjX2NvbW1vbl9wcm9iZShzdHJ1Y3QgZHdf aTNjX21hc3RlciAqbWFzdGVyLAo+ICAJbWFzdGVyLT5jYXBzLmNtZGZpZm9kZXB0aCA9IFFVRVVF X1NUQVRVU19MRVZFTF9DTUQocmV0KTsKPiAgCj4gIAlyZXQgPSByZWFkbChtYXN0ZXItPnJlZ3Mg KyBEQVRBX0JVRkZFUl9TVEFUVVNfTEVWRUwpOwo+IC0JbWFzdGVyLT5jYXBzLmRhdGFmaWZvZGVw dGggPSBEQVRBX0JVRkZFUl9TVEFUVVNfTEVWRUxfVFgocmV0KTsKPiArCW1hc3Rlci0+Y2Fwcy50 eGZpZm9kZXB0aCA9IERBVEFfQlVGRkVSX1NUQVRVU19MRVZFTF9UWChyZXQpOwo+ICsKPiArCXJl dCA9IHJlYWRsKG1hc3Rlci0+cmVncyArIFFVRVVFX1NJWkVfQ0FQQUJJTElUWSk7Cj4gKwltYXN0 ZXItPmNhcHMucnhmaWZvZGVwdGggPQo+ICsJCVFVRVVFX1NJWkVfVE9fRFdPUkRTKFFVRVVFX1NJ WkVfQ0FQQUJJTElUWV9SWF9CVUYocmV0KSk7Cj4gKwo+ICsJbWFzdGVyLT5iYXNlLnR4X2ZpZm9f Ynl0ZXMgPSBtYXN0ZXItPmNhcHMudHhmaWZvZGVwdGggKiA0Owo+ICsJbWFzdGVyLT5iYXNlLnJ4 X2ZpZm9fYnl0ZXMgPSBtYXN0ZXItPmNhcHMucnhmaWZvZGVwdGggKiA0Owo+ICAKPiAgCXJldCA9 IHJlYWRsKG1hc3Rlci0+cmVncyArIERFVklDRV9BRERSX1RBQkxFX1BPSU5URVIpOwo+ICAJbWFz dGVyLT5kYXRzdGFydGFkZHIgPSByZXQ7Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvaTNjL21hc3Rl ci9kdy1pM2MtbWFzdGVyLmggYi9kcml2ZXJzL2kzYy9tYXN0ZXIvZHctaTNjLW1hc3Rlci5oCj4g aW5kZXggZjViNDQ5MWIyNDdhMC4uZTIzNTU0YmZjNWU0OSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJz L2kzYy9tYXN0ZXIvZHctaTNjLW1hc3Rlci5oCj4gKysrIGIvZHJpdmVycy9pM2MvbWFzdGVyL2R3 LWkzYy1tYXN0ZXIuaAo+IEBAIC0xNCw3ICsxNCw4IEBACj4gIAo+ICBzdHJ1Y3QgZHdfaTNjX21h c3Rlcl9jYXBzIHsKPiAgCXU4IGNtZGZpZm9kZXB0aDsKPiAtCXU4IGRhdGFmaWZvZGVwdGg7Cj4g Kwl1OCB0eGZpZm9kZXB0aDsKPiArCXU4IHJ4Zmlmb2RlcHRoOwoKW1NldmVyaXR5OiBIaWdoXQpD YW4gbWFzdGVyLT5jYXBzLnJ4Zmlmb2RlcHRoIG92ZXJmbG93IHU4IGFuZCB0cnVuY2F0ZSB0byAw IGluCmR3X2kzY19jb21tb25fcHJvYmUoKT8KCkluIHRoZSBEZXNpZ25XYXJlIEkzQyBjb250cm9s bGVyLCBRVUVVRV9TSVpFX0NBUEFCSUxJVFlfUlhfQlVGKHJldCkgY2FuCnJldHVybiB1cCB0byAw eDcgKDI1NiAzMi1iaXQgd29yZHMsIG9yIDEwMjQgYnl0ZXMpLiBXaGVuIHRoYXQgaGFwcGVucywK UVVFVUVfU0laRV9UT19EV09SRFMoNykgZXZhbHVhdGVzIHRvIDI1NiAoMHgxMDApLCB3aGljaCB0 cnVuY2F0ZXMgdG8gMCB3aGVuCnN0b3JlZCBpbnRvIHRoZSB1OCByeGZpZm9kZXB0aCBmaWVsZCBp biBzdHJ1Y3QgZHdfaTNjX21hc3Rlcl9jYXBzLgoKV2l0aCBtYXN0ZXItPmNhcHMucnhmaWZvZGVw dGggc2V0IHRvIDAsIG1hc3Rlci0+YmFzZS5yeF9maWZvX2J5dGVzIGFsc28KYmVjb21lcyAwIGlu IGR3X2kzY19jb21tb25fcHJvYmUoKSwgYW5kIHRoZSBucnh3b3JkcyA+Cm1hc3Rlci0+Y2Fwcy5y eGZpZm9kZXB0aCBjaGVjayBpbiBib3RoIGR3X2kzY19tYXN0ZXJfaTNjX3hmZXJzKCkgYW5kCmR3 X2kzY19tYXN0ZXJfaTJjX3hmZXJzKCkgd2lsbCByZWplY3QgZXZlcnkgbm9uLWVtcHR5IHJlYWQg dHJhbnNmZXIgd2l0aAotRU9QTk9UU1VQUC4KClNob3VsZCByeGZpZm9kZXB0aCAoYW5kIHR4Zmlm b2RlcHRoKSBpbiBzdHJ1Y3QgZHdfaTNjX21hc3Rlcl9jYXBzIGJlIHUxNgppbnN0ZWFkIG9mIHU4 PwoKLS0gClNhc2hpa28gQUkgcmV2aWV3IMK3IGh0dHBzOi8vc2FzaGlrby5kZXYvIy9wYXRjaHNl dC8yMDI2MTEwNTA4NTQyNS4zNDE4MjMwLTEtc2h1YmhhbXNhbmpheS5wYXRpbEBhbWQuY29tP3Bh cnQ9MgoKLS0gCmxpbnV4LWkzYyBtYWlsaW5nIGxpc3QKbGludXgtaTNjQGxpc3RzLmluZnJhZGVh ZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1p M2MK From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793869276; b=sNu/F9x4Mgp/wjdhaQ5SDZZWCmGCag0jmLmANe2gTWB282ulv3Dcvz7U4uoNZmDi3a7V DrgITtDg/9SA6C8pSD3n+5fdrn9/Y4Uju2T4/pqrgmXQTD2neL5OPDkDbw6PPYn/78sst qpXW2bb9xvXwd1PMXMNNpVKZKbSPg8bxF+ZXK7+pkYmc7jXES/qT3AGVvetpbnB3myKFU ZGoZfbcEBaYa3Fnb8PRnK2VwdYakBml+dA2kgn7V6070NutWa/hGRIHTIWVGl6vCf2jOF fUidl5qb7x9MByvR5JLaaGykdtI6I+9LApy3FmgbP57crUPOPuSSdGiQJK04/oAidbw== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793869276; h=Received:DKIM-Signature:Message-ID:From:Subject:Reply-To:To:Cc: In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date; bh=NceYa3NZayFxuHHB+QmpGXbPguwXwvX7k5dpGHlALec=; b=y9erbQWUUPKWWLWokx+GF6VYarxN68PL5r4bm12s3oA4n5MQpur+6IqMdpUpwaf3zfyf GFqTF1i0XQEXXpVZVKbf33L5cH5b7v4SWsgR3HXa0qAu3Fa0+T3HvQZzM0UIm5xkEH50R H7u6ySB8OQM2MeqshxL2NRHuSfLCNk02oONO/l5zQ9k4/K4uNtCdAY2ZCUYownqU22GUc G5eLj293+JuMp5FhMaXWB3CaQZ42o13ZCty0fUx2WXDGXU/8TYRZNEH9ctGzcE1OvxhbD 71td52/hQSCoSS5gqoiIkSRdfFqnR+sDehNGQaSVaZMnjlN219IhXbypNnE0n8HkIlA== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=Kw0M1BnE; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0B67C606A31B for ; Thu, 5 Nov 2026 09:01:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=Kw0M1BnE Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4F3A91F000C1; Thu, 5 Nov 2026 09:01:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1793869275; bh=NceYa3NZayFxuHHB+QmpGXbPguwXwvX7k5dpGHlALec=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=Kw0M1BnExzPwaBnZ7Xyad9+a0J277W3l2fS0SmYCeFST97fiqz8ghyTfbT83DErZP c+bz3QVhQmO4n9lurexB72yiBKWBawHHWxKERChQENMsU10t70scHm+MnuOkUhNNaI wWP0gFa50mk1L0mur5Ph5rRhE2jNwArpY0hO0Z8GwNvohwJwnylUGcKk3CqXWBqx6/ GBiAB0BCqqGei1r224Z8F8Nsru6araoBV7c5rjmcvZfWHof6f5Nru+6+JHOtQuGiss meSfwVY7cv5kMLQCG9LAG7C/3HUklN0D6Uy9SjjZ8kVMnvY63bxh2ALbRxYnz9YCpj UDy6eTc36YmuA== Message-ID: From: sashiko-bot@kernel.org Subject: Re: [PATCH v2 2/3] i3c: dw: Track the transmit and receive buffer depths separately Reply-To: sashiko-reviews@lists.linux.dev To: "Shubham Patil" Cc: linux-i3c@lists.infradead.org, devicetree@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org, Frank.Li@kernel.org, "Alexandre Belloni" In-Reply-To: <20261105085425.3418230-3-shubhamsanjay.patil@amd.com> References: <20261105085425.3418230-1-shubhamsanjay.patil@amd.com> <20261105085425.3418230-3-shubhamsanjay.patil@amd.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Thu, 05 Nov 2026 09:01:14 +0000 X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list Thank you for your contribution! Sashiko AI review found 1 potential issue(= s) to consider: - [High] i3c: dw: u8 truncation of rxfifodepth in dw_i3c_common_probe() -- commit c93cc6843b57993d053db03cc3f7cee25dbd4371 Author: Shubham Patil i3c: dw: Track the transmit and receive buffer depths separately This commit splits caps.datafifodepth into caps.txfifodepth and caps.rxfifodepth, populates caps.rxfifodepth from the QUEUE_SIZE_CAPABILITY register, and exposes the FIFO capacities via base.tx_fifo_bytes and base.rx_fifo_bytes. > diff --git a/drivers/i3c/master/dw-i3c-master.c b/drivers/i3c/master/dw-i= 3c-master.c > index d1119f203d1b6..dd5462b129514 100644 > --- a/drivers/i3c/master/dw-i3c-master.c > +++ b/drivers/i3c/master/dw-i3c-master.c > @@ -203,7 +203,10 @@ > #define BUS_IDLE_TIMING 0xd8 > #define I3C_VER_ID 0xe0 > #define I3C_VER_TYPE 0xe4 > -#define EXTENDED_CAPABILITY 0xe8 > +#define QUEUE_SIZE_CAPABILITY 0xe8 > +#define QUEUE_SIZE_CAPABILITY_RX_BUF(x) (((x) & GENMASK(7, 4)) >> 4) > +/* Sizes are encoded, 0 meaning 2 DWORDs and every further step doubling= it. */ > +#define QUEUE_SIZE_TO_DWORDS(x) (2U << (x)) > #define SLAVE_CONFIG 0xec > =20 > #define DYN_ADDR_LO_MASK GENMASK(4, 0) > @@ -978,8 +981,8 @@ static int dw_i3c_master_i3c_xfers(struct i3c_dev_des= c *dev, > ntxwords +=3D DIV_ROUND_UP(i3c_xfers[i].len, 4); > } > =20 > - if (ntxwords > master->caps.datafifodepth || > - nrxwords > master->caps.datafifodepth) > + if (ntxwords > master->caps.txfifodepth || > + nrxwords > master->caps.rxfifodepth) > return -EOPNOTSUPP; > =20 > struct dw_i3c_xfer *xfer __free(kfree) =3D dw_i3c_master_alloc_xfer(mas= ter, i3c_nxfers); > @@ -1136,8 +1139,8 @@ static int dw_i3c_master_i2c_xfers(struct i2c_dev_d= esc *dev, > ntxwords +=3D DIV_ROUND_UP(i2c_xfers[i].len, 4); > } > =20 > - if (ntxwords > master->caps.datafifodepth || > - nrxwords > master->caps.datafifodepth) > + if (ntxwords > master->caps.txfifodepth || > + nrxwords > master->caps.rxfifodepth) > return -EOPNOTSUPP; > =20 > struct dw_i3c_xfer *xfer __free(kfree) =3D dw_i3c_master_alloc_xfer(mas= ter, i2c_nxfers); > @@ -1738,7 +1741,14 @@ int dw_i3c_common_probe(struct dw_i3c_master *mast= er, > master->caps.cmdfifodepth =3D QUEUE_STATUS_LEVEL_CMD(ret); > =20 > ret =3D readl(master->regs + DATA_BUFFER_STATUS_LEVEL); > - master->caps.datafifodepth =3D DATA_BUFFER_STATUS_LEVEL_TX(ret); > + master->caps.txfifodepth =3D DATA_BUFFER_STATUS_LEVEL_TX(ret); > + > + ret =3D readl(master->regs + QUEUE_SIZE_CAPABILITY); > + master->caps.rxfifodepth =3D > + QUEUE_SIZE_TO_DWORDS(QUEUE_SIZE_CAPABILITY_RX_BUF(ret)); > + > + master->base.tx_fifo_bytes =3D master->caps.txfifodepth * 4; > + master->base.rx_fifo_bytes =3D master->caps.rxfifodepth * 4; > =20 > ret =3D readl(master->regs + DEVICE_ADDR_TABLE_POINTER); > master->datstartaddr =3D ret; > diff --git a/drivers/i3c/master/dw-i3c-master.h b/drivers/i3c/master/dw-i= 3c-master.h > index f5b4491b247a0..e23554bfc5e49 100644 > --- a/drivers/i3c/master/dw-i3c-master.h > +++ b/drivers/i3c/master/dw-i3c-master.h > @@ -14,7 +14,8 @@ > =20 > struct dw_i3c_master_caps { > u8 cmdfifodepth; > - u8 datafifodepth; > + u8 txfifodepth; > + u8 rxfifodepth; [Severity: High] Can master->caps.rxfifodepth overflow u8 and truncate to 0 in dw_i3c_common_probe()? In the DesignWare I3C controller, QUEUE_SIZE_CAPABILITY_RX_BUF(ret) can return up to 0x7 (256 32-bit words, or 1024 bytes). When that happens, QUEUE_SIZE_TO_DWORDS(7) evaluates to 256 (0x100), which truncates to 0 when stored into the u8 rxfifodepth field in struct dw_i3c_master_caps. With master->caps.rxfifodepth set to 0, master->base.rx_fifo_bytes also becomes 0 in dw_i3c_common_probe(), and the nrxwords > master->caps.rxfifodepth check in both dw_i3c_master_i3c_xfers() and dw_i3c_master_i2c_xfers() will reject every non-empty read transfer with -EOPNOTSUPP. Should rxfifodepth (and txfifodepth) in struct dw_i3c_master_caps be u16 instead of u8? --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20261105085425.3418= 230-1-shubhamsanjay.patil@amd.com?part=3D2