Re: [PATCH v3 3/3] arm64: dts: qcom: qcm6490-fairphone-fp5: Fix DW9800K support

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Low] dt-bindings: media: dw9800k: invalid dongwoon,vcm-presc property in example
- [Low] media: i2c: dw9719: declaration after case label in dw9719_power_up()
--

commit 3e8104f7ee643adcd7e1f98dbb0c3e1ed1a9c762
Author: Griffin Kroah-Hartman <griffin.kroah@fairphone.com>

arm64: dts: qcom: qcm6490-fairphone-fp5: Fix DW9800K support

This series splits out the device tree binding documentation for the Dongwoon
DW9800K voice coil motor controller, updates the dw9719 driver with proper
register programming for the DW9800K, and updates the Fairphone 5 device tree
node to match.

> diff --git a/Documentation/devicetree/bindings/media/i2c/dongwoon,dw9800k.yaml b/Documentation/devicetree/bindings/media/i2c/dongwoon,dw9800k.yaml
> new file mode 100644
> index 0000000000000..f5bae7b287f1b
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/i2c/dongwoon,dw9800k.yaml

[ ... ]

> +  dongwoon,vcm-prescale:
> +    description:
> +      Indication of VCM internal clock dividing rate select, as one multiple
> +      factor to calculate VCM ring periodic time Tvib.
> +    $ref: /schemas/types.yaml#/definitions/uint32
> +    enum:
> +      - 0 #  Dividing Rate -  2
> +      - 1 #  Dividing Rate -  1
> +      - 2 #  Dividing Rate -  1/2
> +      - 3 #  Dividing Rate -  1/4
> +      - 4 #  Dividing Rate -  8
> +      - 5 #  Dividing Rate -  4
> +    default: 1

[ ... ]

> +additionalProperties: false
> +
> +examples:
> +  - |
> +    i2c {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +
> +        actuator@c {
> +            compatible = "dongwoon,dw9800k";
> +            reg = <0x0c>;
> +
> +            vdd-supply = <&pm8937_l17>;
> +
> +            dongwoon,sac-mode = <4>;
> +            dongwoon,vcm-presc = <0>;

[Severity: Low]
Should this property in the actuator@c example node be dongwoon,vcm-prescale
instead of dongwoon,vcm-presc? With additionalProperties set to false in
Documentation/devicetree/bindings/media/i2c/dongwoon,dw9800k.yaml,
dongwoon,vcm-presc causes make dt_binding_check to fail schema validation.

> diff --git a/drivers/media/i2c/dw9719.c b/drivers/media/i2c/dw9719.c
> index 3b7ba88fd67c0..3b99c5492522c 100644
> --- a/drivers/media/i2c/dw9719.c
> +++ b/drivers/media/i2c/dw9719.c

[ ... ]

> @@ -185,14 +196,50 @@ static int dw9719_power_up(struct dw9719_device *dw9719, bool detect)
>  		/* Optional indication of VCM prescale */
>  		device_property_read_u32(dw9719->dev, "dongwoon,vcm-prescale",
>  					 &dw9719->vcm_freq);
> +
> +		/* Optional indication of SAC timing */
> +		device_property_read_u32(dw9719->dev, "dongwoon,timing-control",
> +					 &dw9719->sac_time);
>  	}
>  
>  	switch (dw9719->model) {
>  	case DW9800K:
> -		cci_write(dw9719->regmap, DW9719_CONTROL, DW9719_ENABLE_RINGING, &ret);
> +		int ring, sac;

[Severity: Low]
In dw9719_power_up(), can the declaration of ring and sac be moved to the top
of the function or wrapped in a compound statement block for case DW9800K?

Under -std=gnu11 prior to C23, placing a variable declaration directly after a
case label without braces causes a build failure on older supported GCC
versions (such as GCC 8 through 10) and sparse when building
drivers/media/i2c/dw9719.c.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261105-b4-dw9800k_cleanup-v3-0-6850ee6a5a5a@fairphone.com?part=3