Re: [PATCH v1] arm64: dts: qcom: glymur-crd: add DisplayPort audio DAI link

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] arm64: dts: qcom: glymur-crd: dp-dai-link breaks sound probe on mahua-crd
--

commit a434cb6530336de83a46c26f22333629bcaaf510
Author: Chiluka Rohith <rohith.chiluka@oss.qualcomm.com>

arm64: dts: qcom: glymur-crd: add DisplayPort audio DAI link

This commit adds a DisplayPort RX DAI link to the sound node in
glymur-crd.dtsi, wiring the DISPLAY_PORT_RX_1 backend of q6apmbedai to the
mdss_dp1 controller.

> diff --git a/arch/arm64/boot/dts/qcom/glymur-crd.dtsi b/arch/arm64/boot/dts/qcom/glymur-crd.dtsi
> index 58158b51fe295..eee75da201983 100644
> --- a/arch/arm64/boot/dts/qcom/glymur-crd.dtsi
> +++ b/arch/arm64/boot/dts/qcom/glymur-crd.dtsi
> @@ -268,6 +268,22 @@ platform {
>  			};
>  		};
>  
> +		dp-dai-link {
> +			link-name = "DISPLAY_PORT-RX";
> +
> +			codec {
> +				sound-dai = <&mdss_dp1>;
> +			};
> +
> +			cpu {
> +				sound-dai = <&q6apmbedai DISPLAY_PORT_RX_1>;
> +			};
> +
> +			platform {
> +				sound-dai = <&q6apm>;
> +			};
> +		};

[Severity: High]
Will adding this unconditionally enabled dp-dai-link node in glymur-crd.dtsi
break sound card probe on mahua-crd?

arch/arm64/boot/dts/qcom/glymur-crd.dtsi is shared by both glymur-crd.dts and
mahua-crd.dts:

arch/arm64/boot/dts/qcom/mahua-crd.dts:
    #include "mahua.dtsi"
    #include "glymur-crd.dtsi"

In arch/arm64/boot/dts/qcom/glymur.dtsi (included by both glymur-crd.dts and
mahua.dtsi), mdss_dp0 and mdss_dp1 default to disabled:

arch/arm64/boot/dts/qcom/glymur.dtsi:
    mdss_dp1: displayport-controller@aea0000 {
        ...
        #sound-dai-cells = <0>;

        status = "disabled";

mdss_dp0 and mdss_dp1 are only enabled in glymur-crd.dts, while remaining
disabled in mahua.dtsi and mahua-crd.dts:

arch/arm64/boot/dts/qcom/glymur-crd.dts:
    &mdss_dp0 {
        status = "okay";
    };

    &mdss_dp1 {
        status = "okay";
    };

When x1e80100_platform_probe() -> qcom_snd_parse_of() parses the available
child nodes of /sound on mahua-crd, it calls:

qcom_snd_parse_of()
  -> snd_soc_of_get_dai_link_codecs()
    -> snd_soc_of_get_dlc()
      -> snd_soc_get_dlc()

Because mdss_dp1 is disabled on mahua-crd, the DP controller never probes or
registers its hdmi-audio-codec ASoC component, causing snd_soc_get_dlc() to
return -EPROBE_DEFER indefinitely and preventing the entire sound card (and
existing WSA speaker and VA capture links) from probing on Mahua CRD.

In addition, glymur-crd.dts enables both mdss_dp0 and mdss_dp1, whereas this
patch only adds a DAI link for mdss_dp1. Should the DP DAI link(s) match the
enabled DP controllers and only be enabled where the corresponding mdss_dp
nodes are enabled?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261105104624.621024-1-rohith.chiluka@oss.qualcomm.com?part=1