Re: [PATCH 6/7] arm64: dts: apple: t603x-j514-j516: Add PCIe device nodes

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] arm64: dts: apple: wrong wifi0/bluetooth0 PCI IDs in t603x-j514-j516.dtsi
--

commit 93b064f5082472a65526181caee83a837e8be25d
Author: Yureka Lilian <yureka@cyberchaos.dev>

arm64: dts: apple: t603x-j514-j516: Add PCIe device nodes

This commit adds PCIe device nodes for Wi-Fi, Bluetooth, and the SD-card
reader to the M3 Pro and M3 Max MacBook Pro device trees, along with
board-specific brcm,board-type properties.

> diff --git a/arch/arm64/boot/dts/apple/t603x-j514-j516.dtsi b/arch/arm64/boot/dts/apple/t603x-j514-j516.dtsi
> index bbee373044f94..403a9cb3979c7 100644
> --- a/arch/arm64/boot/dts/apple/t603x-j514-j516.dtsi
> +++ b/arch/arm64/boot/dts/apple/t603x-j514-j516.dtsi
[ ... ]
> @@ -67,3 +69,42 @@ &serial0 {
>  &fpwm0 {
>  	status = "okay";
>  };
> +
> +/* PCIe devices */
> +
> +/*
> + * Force the bus number assignments so that we can declare some of the
> + * on-board devices and properties that are populated by the bootloader
> + * (such as MAC addresses).
> + */
> +&port00 {
> +	/* WLAN */
> +	bus-range = <1 1>;
> +
> +	wifi0: wifi@0,0 {
> +		compatible = "pci14e4,4433";
> +		reg = <0x10000 0x0 0x0 0x0 0x0>;
> +		/* To be filled by the loader */
> +		local-mac-address = [00 10 18 00 00 10];
> +		apple,antenna-sku = "XX";
> +	};
> +
> +	bluetooth0: bluetooth@0,1 {
> +		compatible = "pci14e4,5f71";
> +		reg = <0x10100 0x0 0x0 0x0 0x0>;
> +		/* To be filled by the loader */
> +		local-bd-address = [00 00 00 00 00 00];
> +	};
> +};

[Severity: Medium]
Should wifi0 and bluetooth0 under port00 in
arch/arm64/boot/dts/apple/t603x-j514-j516.dtsi use the Broadcom BCM4388
PCIe IDs ("pci14e4,4434" and "pci14e4,5f72") instead of the BCM4387 IDs
("pci14e4,4433" and "pci14e4,5f71")?

In arch/arm64/boot/dts/apple/t600x-j314-j316.dtsi (M1 Pro/Max), wifi0 and
bluetooth0 use "pci14e4,4433" and "pci14e4,5f71", which
arch/arm64/boot/dts/apple/t602x-j414-j416.dtsi (M2 Pro/Max) then
overrides for BCM4388:

&wifi0 {
	compatible = "pci14e4,4434";
};

&bluetooth0 {
	compatible = "pci14e4,5f72";
};

The base M3 MacBook Pro J504 in arch/arm64/boot/dts/apple/t8122-jxxx.dtsi
also uses "pci14e4,4434" and "pci14e4,5f72" for wifi0 and bluetooth0. It
looks like when the port00 node was copied from t600x-j314-j316.dtsi into
t603x-j514-j516.dtsi, the overrides from t602x-j414-j416.dtsi were missed,
leaving all six M3 Pro and M3 Max MacBook Pro device trees with the older
BCM4387 compatible strings.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261105-apple-m3-pcie-v1-0-e00a72a604f8@jannau.net?part=6