Re: [PATCH v4 02/16] dt-bindings: clock: at91: Split up per SoC partially

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dt-bindings: usb: at91sam9rl-udc: SAM9RL clock macro in SAM9G45 example
--

commit 42b3b9bce6c46bb748afcf89b465e4d50b66ad5b
Author: Alexander Dahl <ada@thorsis.com>

dt-bindings: clock: at91: Split up per SoC partially

This commit splits core PMC clock index definitions into per-SoC device
tree binding headers for the AT91/Microchip family and updates two device
tree binding examples to use the new SoC-specific macros.

Link: https://lore.kernel.org/linux-devicetree/20250207-jailbird-circus-bcc04ee90e05@thorsis.com/T/#u

> diff --git a/Documentation/devicetree/bindings/usb/atmel,at91sam9rl-udc.yaml b/Documentation/devicetree/bindings/usb/atmel,at91sam9rl-udc.yaml
> index cdbbd17f80363..15f5bb51fd8a7 100644
> --- a/Documentation/devicetree/bindings/usb/atmel,at91sam9rl-udc.yaml
> +++ b/Documentation/devicetree/bindings/usb/atmel,at91sam9rl-udc.yaml
> @@ -61,13 +61,14 @@ examples:
>    - |
>      #include <dt-bindings/interrupt-controller/irq.h>
>      #include <dt-bindings/clock/at91.h>
> +    #include <dt-bindings/clock/atmel,at91sam9rl-pmc.h>
>      #include <dt-bindings/gpio/gpio.h>
>      gadget@fff78000 {
>          compatible = "atmel,at91sam9g45-udc";
>          reg = <0x00600000 0x80000
>                 0xfff78000 0x400>;
>          interrupts = <27 IRQ_TYPE_LEVEL_HIGH 0>;
> -        clocks = <&pmc PMC_TYPE_PERIPHERAL 27>, <&pmc PMC_TYPE_CORE PMC_UTMI>;
> +        clocks = <&pmc PMC_TYPE_PERIPHERAL 27>, <&pmc PMC_TYPE_CORE AT91SAM9RL_PMC_UTMI>;

[Severity: Low]
In Documentation/devicetree/bindings/usb/atmel,at91sam9rl-udc.yaml, the
example node gadget@fff78000 has compatible "atmel,at91sam9g45-udc" with
interrupt 27 and peripheral clock 27, matching the USBA controller in
at91sam9g45.dtsi.

Should this example include dt-bindings/clock/atmel,at91sam9g45-pmc.h and
use AT91SAM9G45_PMC_UPLLCK instead of AT91SAM9RL_PMC_UTMI?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261105110715.2486432-1-ada@thorsis.com?part=2