Re: [PATCH v3] pinctrl: nxp: s32g2: Enable by default on ARCH_S32

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] pinctrl: nxp: s32g2: broken COMPILE_TEST prompt with strict ARCH_S32 dependency
--

commit 065380d0c7f62b7d0370fd1bcacf175935178d8a
Author: Khristine Andreea Barbulescu <khristineandreea.barbulescu@oss.nxp.com>

pinctrl: nxp: s32g2: Enable by default on ARCH_S32

This commit enables PINCTRL_S32G2 by default on ARCH_S32 and restricts its
Kconfig prompt to COMPILE_TEST so that S32G boards have the SIUL2 pin
controller driver built in by default.

> diff --git a/drivers/pinctrl/nxp/Kconfig b/drivers/pinctrl/nxp/Kconfig
> index abca7ef97003d..d6d97c944b94e 100644
> --- a/drivers/pinctrl/nxp/Kconfig
> +++ b/drivers/pinctrl/nxp/Kconfig
> @@ -8,8 +8,14 @@ config PINCTRL_S32CC
>  	select REGMAP_MMIO
>  
>  config PINCTRL_S32G2
> +	bool "NXP S32G2 pinctrl driver" if COMPILE_TEST
>  	depends on ARCH_S32 && OF
> -	bool "NXP S32G2 pinctrl driver"
> +	default ARCH_S32
>  	select PINCTRL_S32CC

[Severity: Medium]
As reported by Sashiko on v2 [1], does gating the PINCTRL_S32G2 prompt on
COMPILE_TEST work as intended when both PINCTRL_S32G2 and PINCTRL_S32CC keep
a strict dependency on ARCH_S32 && OF?

In drivers/pinctrl/nxp/Kconfig, PINCTRL_S32CC also requires ARCH_S32:

config PINCTRL_S32CC
	bool
	depends on ARCH_S32 && OF

Because a symbol's depends on expression bounds its prompt visibility, the
prompt and help text for PINCTRL_S32G2 are only reachable when ARCH_S32, OF,
and COMPILE_TEST are all enabled simultaneously.

When ARCH_S32=n and COMPILE_TEST=y, depends on ARCH_S32 && OF evaluates to n
on both PINCTRL_S32G2 and PINCTRL_S32CC, preventing the driver from being
enabled for compile-testing on non-ARCH_S32 builds.

Conversely, when ARCH_S32=y and COMPILE_TEST=n, the prompt is hidden and
PINCTRL_S32G2 is forced to y with no way to disable it, even when building
for non-S32G platforms in the ARCH_S32 family found in
arch/arm64/boot/dts/freescale/Makefile:

dtb-$(CONFIG_ARCH_S32) += s32g274a-evb.dtb
dtb-$(CONFIG_ARCH_S32) += s32g274a-rdb2.dtb
dtb-$(CONFIG_ARCH_S32) += s32g399a-rdb3.dtb
dtb-$(CONFIG_ARCH_S32) += s32n79-rdb.dtb
dtb-$(CONFIG_ARCH_S32) += s32v234-evb.dtb

Should both PINCTRL_S32G2 and PINCTRL_S32CC instead use depends on
(ARCH_S32 || COMPILE_TEST) && OF (or keep the prompt visible so non-S32G
ARCH_S32 builds can disable PINCTRL_S32G2)?

[1] https://lore.kernel.org/r/20261104113905.96582-1-khristineandreea.barbulescu@oss.nxp.com

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261105141347.488850-1-khristineandreea.barbulescu@oss.nxp.com?part=1