Re: [PATCH v2 6/6] arm64: dts: mediatek: Add Amazon Echo Dot (2016)

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] arm64: dts: mediatek: unmatched mediatek,mt8163-wdt compatible in mt8163.dtsi
--

commit 1dcf4259a2a7c0a8d0a32ef9d20a66f3c078542e
Author: Ben Grisdale <bengris32@protonmail.ch>

arm64: dts: mediatek: Add Amazon Echo Dot (2016)

This commit adds a device tree for the Amazon Echo Dot (2nd generation, 2016),
codenamed "biscuit", based on the MediaTek MT8163 SoC, and enables building
mt8163-amazon-biscuit.dtb.

> diff --git a/arch/arm64/boot/dts/mediatek/mt8163-amazon-biscuit.dts b/arch/arm64/boot/dts/mediatek/mt8163-amazon-biscuit.dts
> new file mode 100644
> index 0000000000000..5fb5d59e4ed25
> --- /dev/null
> +++ b/arch/arm64/boot/dts/mediatek/mt8163-amazon-biscuit.dts
> @@ -0,0 +1,68 @@
> +// SPDX-License-Identifier: GPL-2.0-only OR MIT
> +/*
> + * Copyright (c) 2026 Ben Grisdale <bengris32@protonmail.ch>
> + */
> +
> +/dts-v1/;
> +#include "mt8163.dtsi"

[Severity: Medium]
Building mt8163-amazon-biscuit.dtb includes arch/arm64/boot/dts/mediatek/mt8163.dtsi,
which defines watchdog@10007000 without a fallback compatible:

arch/arm64/boot/dts/mediatek/mt8163.dtsi:
		watchdog: watchdog@10007000 {
			compatible = "mediatek,mt8163-wdt";
			reg = <0 0x10007000 0 0x1000>;
			interrupts = <GIC_SPI 128 IRQ_TYPE_EDGE_FALLING>;
			#reset-cells = <1>;
		};

However, mediatek,mt8163-wdt is not documented in
Documentation/devicetree/bindings/watchdog/mediatek,mtk-wdt.yaml, nor is it
present in mtk_wdt_dt_ids[] in drivers/watchdog/mtk_wdt.c:

drivers/watchdog/mtk_wdt.c:
static const struct of_device_id mtk_wdt_dt_ids[] = {
	{ .compatible = "mediatek,mt2712-wdt", .data = &mt2712_data },
	{ .compatible = "mediatek,mt6589-wdt", .data = &mt6589_data },
	...

Will this cause dtbs_check to fail on mt8163-amazon-biscuit.dtb and prevent
the MediaTek watchdog and TOPRGU reset controller driver from binding to
watchdog@10007000 at runtime? Should watchdog@10007000 in mt8163.dtsi include
a fallback compatible such as "mediatek,mt6589-wdt" (along with the binding
update), or should mediatek,mt8163-wdt be added to the binding and driver?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261105-arm64-initial-support-for-mediatek-mt8163-soc-v2-0-e68d7d428f99@protonmail.ch?part=6