Re: [PATCH 1/2] dt-bindings: crypto: qcom,inline-crypto-engine: Add SM8350

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] dt-bindings: crypto: qcom,inline-crypto-engine: wrong allOf rule for SM8350
--

commit 6fe4d61044ad335d59b80ff5b3c25ea2445e069d
Author: Demeter Barna <me@fromdisposition.org>

dt-bindings: crypto: qcom,inline-crypto-engine: Add SM8350

This commit documents the qcom,sm8350-inline-crypto-engine compatible in the
Qualcomm Inline Crypto Engine DT binding schema.

> diff --git a/Documentation/devicetree/bindings/crypto/qcom,inline-crypto-engine.yaml b/Documentation/devicetree/bindings/crypto/qcom,inline-crypto-engine.yaml
> index 23bf98c2b9fa0..198002f582484 100644
> --- a/Documentation/devicetree/bindings/crypto/qcom,inline-crypto-engine.yaml
> +++ b/Documentation/devicetree/bindings/crypto/qcom,inline-crypto-engine.yaml

[ ... ]

> @@ -74,6 +75,7 @@ allOf:
>                  - qcom,sa8775p-inline-crypto-engine
>                  - qcom,sc7180-inline-crypto-engine
>                  - qcom,sc7280-inline-crypto-engine
> +                - qcom,sm8350-inline-crypto-engine

[Severity: Medium]
Should qcom,sm8350-inline-crypto-engine be omitted from this allOf list?

The commit message states that this patch requires the power domain and clock
names for SM8350, However, the allOf block uses a negated condition to exempt
legacy SoCs from requiring power-domains, clock-names, and two clocks:

# Do not extend the list.
# Legacy SoCs are allowed for single clock.
# New SoCs must provide both clocks and power domains.
allOf:
  - if:
      not:
        properties:
          compatible:
            contains:
              enum:
                ...
                - qcom,sm8350-inline-crypto-engine
                ...
    then:
      required:
        - power-domains
        - clock-names
      properties:
        clocks:
          minItems: 2
        clock-names:
          minItems: 2

Adding qcom,sm8350-inline-crypto-engine under the negated if condition causes
dtbs_check to skip the then clause, exempting SM8350 from those requirements
instead of enforcing them.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261105-b4-sm8350-ice-v1-0-f55e6ea8e1ca@fromdisposition.org?part=1