Re: [PATCH RFC v3 11/14] i2c: nomadik: save I2C_CR register before resetting HW in IRQ handler

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] i2c: nomadik: commit subject refers to I2C_CR register instead of I2C_SR
--

commit d218bb5af34fbc63fe8a8b9dff6e05c3496a8824
Author: Dmitry Guzman <Dmitry.Guzman@mobileye.com>

i2c: nomadik: save I2C_CR register before resetting HW in IRQ handler

This commit adds an i2c_sr field to struct nmk_i2c_dev to save the
I2C_SR status register value in i2c_irq_handler() before calling
init_hw(), preserving the status for fault reporting in
nmk_i2c_xfer_one().

>     i2c: nomadik: save I2C_CR register before resetting HW in IRQ handler
>     
>     On some interrupts, such as Bus Error interrupt or Arbitration Lost
>     interrupt, the interrupt handler calls init_hw() to reset the I2C
>     controller. This clears I2C_SR register value that might be used for
>     fault reporting.
>     
>     Add i2c_sr field to nmk_i2c_dev structure, store there I2C_SR register
>     value before resetting the hardware, and use this value instead of
>     reading it directly in nmk_i2c_xfer_one() if it was read in IRQ handler.
>     
>     Signed-off-by: Dmitry Guzman <Dmitry.Guzman@mobileye.com>

[Severity: Low]
This isn't a bug, but should the commit subject refer to the I2C_SR
register instead of I2C_CR? Both the commit message body and the changes
in drivers/i2c/busses/i2c-nomadik.c (in struct nmk_i2c_dev,
nmk_i2c_xfer_one(), and i2c_irq_handler()) save and inspect I2C_SR rather
than the I2C_CR control register.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261105-i2c-fault-reporting-v3-0-515ad74ac4c9@mobileye.com?part=11