All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: xujiahao <xujiahao@cmss.chinamobile.com>
Cc: linux-pci@vger.kernel.org
Subject: Re: [PATCH v2] PCI: octep: Size the interrupt name buffer for the full format range
Date: Fri, 06 Nov 2026 01:33:38 +0000	[thread overview]
Message-ID: <sashiko-outbox-200520@kernel.org> (raw)
In-Reply-To: <20261106012126.3385789-1-xujiahao@cmss.chinamobile.com>

> octep_hp_request_irq() formats the interrupt name with "octep_hp_%d"
> into a 16-byte array.  The prefix is 9 bytes and a full-range %d
> argument can add up to 11 more, so the worst case needs 21 bytes
> including the terminator and 0-day reports:
> 
>   drivers/pci/hotplug/octep_hp.c:312:53: warning: '%d' directive output may be truncated writing between 1 and 10 bytes into a region of size 7 [-Wformat-truncation=]
>   note: 'snprintf' output between 11 and 20 bytes into a destination of size 16
> 
> The values passed today are OCTEP_HP_INTR_ENA (0) and OCTEP_HP_INTR_DIS (1),
> so no truncation actually happens, but the buffer carries no margin over the
> format's worst case.  Give it the room so the warning stops coming back from
> builds that cannot narrow the argument.
> 
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202507261457.SXXHOjUk-lkp@intel.com/
> Signed-off-by: xujiahao <xujiahao@cmss.chinamobile.com>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261106012126.3385789-1-xujiahao@cmss.chinamobile.com?part=1


  reply	other threads:[~2026-11-06  1:33 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-06  1:21 [PATCH v2] PCI: octep: Size the interrupt name buffer for the full format range xujiahao
2026-11-06  1:33 ` sashiko-bot [this message]
2026-11-09 23:39 ` Bjorn Helgaas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-200520@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=xujiahao@cmss.chinamobile.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.