From: sashiko-bot@kernel.org
To: lirongqing <lirongqing@baidu.com>, linux-perf-users@vger.kernel.org
Subject: Re: [PATCH] perf iostat: Preserve the port count when growing the list fails
Date: Fri, 06 Nov 2026 02:24:43 +0000 [thread overview]
Message-ID: <sashiko-outbox-200590@kernel.org> (raw)
In-Reply-To: <20261106021913.2341-1-lirongqing@baidu.com>
> From: Li RongQing <lirongqing@baidu.com>
>
> The root port insertion helper increments nr_entries before reallocating
> its pointer array. If realloc() fails, both the scan and filter error
> paths free the list using the increased count, reading one pointer past
> the allocation. Failure of the first insertion instead dereferences a
> NULL array.
>
> Grow the array before changing the entry count or the port index so a
> failed insertion leaves the list valid for cleanup.
>
> Fixes: 19776d3cede7 ("perf stat: Helper functions for PCIe root ports list in iostat mode")
> Signed-off-by: Li RongQing <lirongqing@baidu.com>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261106021913.2341-1-lirongqing@baidu.com?part=1
next prev parent reply other threads:[~2026-11-06 2:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-06 2:19 [PATCH] perf iostat: Preserve the port count when growing the list fails lirongqing
2026-11-06 2:24 ` sashiko-bot [this message]
2026-11-10 2:52 ` Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-200590@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=lirongqing@baidu.com \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.