Re: [PATCH v2 1/3] arm64: dts: mediatek: mt8390-genio-common: Fix type C port mode and connection

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential
issues to consider:
- [Low] arm64: dts: mediatek: missing PDO_FIXED_USB_COMM in mt8390
  source-pdos
- [Low] arm64: dts: mediatek: mt8390-genio: hub ports nodes violate
  ti,usb8020b schema
--

commit b958daa221ebf8e15b905e203df3fc6aa4fbfaae
Author: Chen-Yu Tsai <wenst@chromium.org>

arm64: dts: mediatek: mt8390-genio-common: Fix type C port mode and connection

This commit updates the USB controller and Type-C connector on MT8390
Genio boards to host-only and source-only mode, routing the connector's
High-Speed and SuperSpeed endpoints through the onboard TI TUSB8020B hub.

> diff --git a/arch/arm64/boot/dts/mediatek/mt8390-genio-common.dtsi b/arch/arm64/boot/dts/mediatek/mt8390-genio-common.dtsi
> index 669eaec662f33..d10ee1603103f 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8390-genio-common.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8390-genio-common.dtsi
> @@ -512,18 +512,11 @@ rt1715@4e {
>  		connector {
>  			compatible = "usb-c-connector";
>  			label = "USB-C";
> -			data-role = "dual";
> -			op-sink-microwatt = <10000000>;
> -			power-role = "dual";
> -			try-power-role  = "sink";
> +			data-role = "host";
> +			power-role = "source";
>  			pd-revision = /bits/ 8 <0x03 0x00 0x01 0x08>;
>  
> -			sink-pdos = <PDO_FIXED(5000, 2000,
> -					       PDO_FIXED_DUAL_ROLE |
> -					       PDO_FIXED_DATA_SWAP)>;
> -			source-pdos = <PDO_FIXED(5000, 2000,
> -						 PDO_FIXED_DUAL_ROLE |
> -						 PDO_FIXED_DATA_SWAP)>;
> +			source-pdos = <PDO_FIXED(5000, 1000, 0)>;

[Severity: Low]
Should source-pdos pass PDO_FIXED_USB_COMM instead of 0?  This connector
routes High-Speed and SuperSpeed data lines to the onboard USB hub, so
passing 0 causes tcpm_pd_send_source_caps() and
usb_communication_capable_show() to advertise the port as incapable of
USB data communication.

[ ... ]

> @@ -1555,6 +1541,19 @@ hub_2_0: hub@1 {
>  		peer-hub = <&hub_3_0>;
>  		reset-gpios = <&pio 7 GPIO_ACTIVE_HIGH>;
>  		vdd-supply = <&usb_hub_fixed_3v3>;
> +
> +		ports {
> +			#address-cells = <1>;
> +			#size-cells = <0>;
> +
> +			port@2 {
> +				reg = <2>;
> +
> +				usb_3_0_p2: endpoint {
> +					remote-endpoint = <&typec_con_ss>;
> +				};
> +			};
> +		};
>  	};
>  
>  	hub_3_0: hub@2 {
> @@ -1563,11 +1562,18 @@ hub_3_0: hub@2 {
>  		peer-hub = <&hub_2_0>;
>  		reset-gpios = <&pio 7 GPIO_ACTIVE_HIGH>;
>  		vdd-supply = <&usb_hub_fixed_3v3>;
> -	};
>  
> -	port {
> -		xhci_ss_ep: endpoint {
> -			remote-endpoint = <&typec_con_ss>;
> +		ports {
> +			#address-cells = <1>;
> +			#size-cells = <0>;
> +
> +			port@2 {
> +				reg = <2>;
> +
> +				usb_2_0_p2: endpoint {
> +					remote-endpoint = <&typec_con_hs>;
> +				};
> +			};
>  		};
>  	};
>  };

[Severity: Low]
Do the new ports child nodes under hub@1 (usb451,8025) and hub@2
(usb451,8027) cause dtbs_check to fail against
Documentation/devicetree/bindings/usb/ti,usb8020b.yaml?  That schema only
references usb-device.yaml# with additionalProperties: false, and the
prerequisite commit "dt-bindings: usb: ti,usb8041: Fold in TI USB8020B"
noted in the patch commentary is not present in the tree yet.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261106060621.2706658-1-wenst@chromium.org?part=1