From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793949780; b=WKTlv9Y/lYa76nxyGbotTgnRn9+AIB+tFagng5zE3qAJjkf4N3NIdj0yH3WyvdLJGgHu uedzpjDw1LJiDm6FTO1X9kJEw2mt6YyiIojJzqyECejDe6xHn/XaNkicJlcmZrzHev6a4 fjuDH+AIbiquaK6oTmnTb0DU1T/0vZzzQY26nN0Ape8/dT3RuRvheXWbMHMq8c4312amr /CzkBs4rKnYnLv/Bqhk+0wzjTBhimXPuDu8EGMgUXIcJ7USxEFyzYlVb4tWFpGaSjfuD5 OGpsMh9nmTH0rEutfB+gD6ch6qa9b63lrBlmlv7Ln4g+sJSlxUXGMqFeHsmKz5eKIyw== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793949780; h=Received:DKIM-Signature:Message-ID:From:Subject:Reply-To:To:Cc: In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date; bh=l+JJGuwRJM3z7N4kO/kgTH54i4ethXSyzCMfLiGeBfo=; b=ustqvkwZkLnm06uz0hoYIkNpNh5tmNFREkiBbg/k/TtRR5JM5BciGyvTTWJ8/WhP1b8v DVuSwQdBsMqKPJIY0SMyRUG1ljrzcAWa9lWPb1Vyh9R8jp0FScw3+g+kmmGlfZD0rJVBj TTC3Fl34eiB53wHH/X6dBlsMzr5+iy2g7hVihaxNQszuaYvv1etemVBbPCTRw+xdWLqX2 ZDQ66G27rG6i+h14Ta4T6h+MWGss83xBx/UCfuYqZxsCvrvG/euknY4+UZD0swIlA7+VZ 4w/4VkERYodbHKn+D9XFOCkK8W6KsQQeoKfvQ4moZAO1snj6x49/l/oPto9D0ZEnipg== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=lPb5vqkp; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5ACF1606A329; Fri, 6 Nov 2026 07:23:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=lPb5vqkp Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7B3DC1F0089F; Fri, 6 Nov 2026 07:22:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1793949779; bh=l+JJGuwRJM3z7N4kO/kgTH54i4ethXSyzCMfLiGeBfo=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=lPb5vqkp5peh+FGlxrIgMbxTsFX0re3sCatibuw+wXpGnX23nZuzPubjmu6xawIPT t0Hxcx27XKGjFyI7yEreLaIVcvB4P3PViVEdmTI5ymxZP64EzPduNxBt2X/4SnBEpA KTZKM741SufHk5Jw4O4P/B4hlRjB1gA55MOu6a3YTqOBEsyBLDbBMMeNu2plgk1ak/ n3YLpy42Hp8f/l8CnltK/dKphS6VwyVuVJoQLZFtpam1tMJK5rfyLtLIz9fE0+ja2p hCwY9yRaafS8Q9ARA+dp7MhTRnFsMLsjYBjDfSWi8QwVJnwcADgqkOqpkmbfQV3YiO aLennEEUfvdvA== Message-ID: From: sashiko-bot@kernel.org Subject: Re: [PATCH v3 2/2] dt-bindings: i3c: silvaco,i3c-master: Add Amlogic A9 support Reply-To: sashiko-reviews@lists.linux.dev To: "Junyi Zhao" Cc: linux-i3c@lists.infradead.org, devicetree@vger.kernel.org, linux-amlogic@lists.infradead.org, imx@lists.linux.dev, robh@kernel.org, conor+dt@kernel.org, Frank.Li@kernel.org, neil.armstrong@linaro.org, "Alexandre Belloni" In-Reply-To: <20261106-a9_i3c-v3-2-804b69b9095b@amlogic.com> References: <20261106-a9_i3c-v3-0-804b69b9095b@amlogic.com> <20261106-a9_i3c-v3-2-804b69b9095b@amlogic.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Fri, 06 Nov 2026 07:22:59 +0000 X-Mailing-List: imx@lists.linux.dev List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list Thank you for your contribution! Sashiko AI review found 2 potential issues to consider: - [Low] dt-bindings: i3c: silvaco: unwieldy per-compatible clock conditionals - [Low] dt-bindings: i3c: silvaco: single-item enum and description in if/then -- commit dbac4436ecc3f857ef0fa7dbe10d0fd5116cdb2d Author: Junyi Zhao dt-bindings: i3c: silvaco,i3c-master: Add Amlogic A9 support This commit adds the amlogic,a9-i3c and amlogic,a9-ao-i3c compatible strings and their per-variant clock constraints to the Silvaco I3C master Device Tree binding schema. > diff --git a/Documentation/devicetree/bindings/i3c/silvaco,i3c-master.yam= l b/Documentation/devicetree/bindings/i3c/silvaco,i3c-master.yaml > index 853092f7522d3..d892d42bee65c 100644 > --- a/Documentation/devicetree/bindings/i3c/silvaco,i3c-master.yaml > +++ b/Documentation/devicetree/bindings/i3c/silvaco,i3c-master.yaml > @@ -13,6 +13,8 @@ properties: > compatible: > oneOf: > - enum: > + - amlogic,a9-i3c > + - amlogic,a9-ao-i3c > - nuvoton,npcm845-i3c > - silvaco,i3c-master-v1 > - items: > @@ -28,14 +30,14 @@ properties: > maxItems: 1 > =20 > clocks: > - minItems: 2 > + minItems: 1 > items: > - description: system clock > - description: bus clock > - description: other (slower) events clock > =20 > clock-names: > - minItems: 2 > + minItems: 1 > items: > - const: pclk > - const: fast_clk > @@ -70,15 +72,35 @@ allOf: > compatible: > contains: > enum: > + - amlogic,a9-i3c > - nxp,imx94-i3c > - nxp,imx95-i3c > then: > properties: > clocks: > + minItems: 2 > maxItems: 2 > clock-names: > + minItems: 2 > maxItems: 2 [Severity: Low] Should the Amlogic A9 variants be split into a separate binding schema instead of adding more per-compatible conditionals here? Neither amlogic,a9-i3c nor amlogic,a9-ao-i3c uses the silvaco,i3c-master-v1 fallback, and accommodating the 1-clock AO variant weakens the top-level clocks and clock-names minItems to 1 so that 3-clock, 2-clock, and 1-clock variants all have to be constrained via separate if/then blocks in allOf. > + > + - if: > + properties: > + compatible: > + contains: > + enum: > + - amlogic,a9-ao-i3c > + then: > + properties: > + clocks: > + maxItems: 1 > + description: > + The "ao" variant is the controller instance in the Always-On= (AO) > + domain, which has no separate bus clock and derives the > + bus clock from an internal divider. > + clock-names: > + maxItems: 1 [Severity: Low] Does this new if/then block pass dt_binding_check? The dtschema meta-schema requires enum arrays to have at least two items, so matching the single amlogic,a9-ao-i3c string under contains needs const rather than a single-entry enum. Also, property descriptions belong in the top-level properties block rather than inside an if/then conditional. --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20261106-a9_i3c-v3-= 0-804b69b9095b@amlogic.com?part=3D2 From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 36AB7606A328 for ; Fri, 6 Nov 2026 07:23:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=SLvxOkiX; dkim=fail reason="signature verification failed" (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=lPb5vqkp DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Reply-To:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Date:References: In-Reply-To:Cc:To:Subject:From:Message-ID:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Unsubscribe-Post:List-Owner; bh=JBkX+1Si/CO2fkipssIFFuplI9yp7lRo2UOzKrdrxgI=; b=SLvxOkiXtESCxUtcP5Sjav/G1L gvpIft+KxtrLsS5CBjM/2nQ64pWV6AITx5ekBvm6emq3kx11ouSxqUp2r4SeWv2aHfklfAvqWRpuE ei3yV47GzhB+17niSSlqvJL8hQPeJ7nCO+av6p1Fil2xBjiHzLBm0jH5pufvJQndV8UqqaSu0tKHJ DB89i6w0MwPXpk0fnQ9Qf/xTGMSZRvkQamtodR6EtseAUynxWhoK+xK3SR88uSeMtzCoNQWaJEFVW 0XqEH3Z9RUDzE22458l1GPDJoM5mbvMWymcffttG6GUHAD867kXkZBQ8A3ZaTeQANaBajBLJIm64h 2QZpf7Kw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.100.1 #2 (Red Hat Linux)) id 1xPEHs-0000000BR69-408w; Fri, 06 Nov 2026 07:23:00 +0000 Received: from sea.source.kernel.org ([2600:3c0a:e001:78e:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.100.1 #2 (Red Hat Linux)) id 1xPEHs-0000000BR5z-1Fh1; Fri, 06 Nov 2026 07:23:00 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id 0D81B40103; Fri, 6 Nov 2026 07:23:00 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7B3DC1F0089F; Fri, 6 Nov 2026 07:22:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1793949779; bh=l+JJGuwRJM3z7N4kO/kgTH54i4ethXSyzCMfLiGeBfo=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=lPb5vqkp5peh+FGlxrIgMbxTsFX0re3sCatibuw+wXpGnX23nZuzPubjmu6xawIPT t0Hxcx27XKGjFyI7yEreLaIVcvB4P3PViVEdmTI5ymxZP64EzPduNxBt2X/4SnBEpA KTZKM741SufHk5Jw4O4P/B4hlRjB1gA55MOu6a3YTqOBEsyBLDbBMMeNu2plgk1ak/ n3YLpy42Hp8f/l8CnltK/dKphS6VwyVuVJoQLZFtpam1tMJK5rfyLtLIz9fE0+ja2p hCwY9yRaafS8Q9ARA+dp7MhTRnFsMLsjYBjDfSWi8QwVJnwcADgqkOqpkmbfQV3YiO aLennEEUfvdvA== Message-ID: From: sashiko-bot@kernel.org Subject: Re: [PATCH v3 2/2] dt-bindings: i3c: silvaco,i3c-master: Add Amlogic A9 support To: "Junyi Zhao" Cc: linux-i3c@lists.infradead.org, devicetree@vger.kernel.org, linux-amlogic@lists.infradead.org, imx@lists.linux.dev, robh@kernel.org, conor+dt@kernel.org, Frank.Li@kernel.org, neil.armstrong@linaro.org, "Alexandre Belloni" In-Reply-To: <20261106-a9_i3c-v3-2-804b69b9095b@amlogic.com> References: <20261106-a9_i3c-v3-0-804b69b9095b@amlogic.com> <20261106-a9_i3c-v3-2-804b69b9095b@amlogic.com> Date: Fri, 06 Nov 2026 07:22:59 +0000 X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev X-Archived-By: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-amlogic" X-Spam-Status: No, score=-8.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 VGhhbmsgeW91IGZvciB5b3VyIGNvbnRyaWJ1dGlvbiEgU2FzaGlrbyBBSSByZXZpZXcgZm91bmQg MiBwb3RlbnRpYWwKaXNzdWVzIHRvIGNvbnNpZGVyOgotIFtMb3ddIGR0LWJpbmRpbmdzOiBpM2M6 IHNpbHZhY286IHVud2llbGR5IHBlci1jb21wYXRpYmxlIGNsb2NrCiAgY29uZGl0aW9uYWxzCi0g W0xvd10gZHQtYmluZGluZ3M6IGkzYzogc2lsdmFjbzogc2luZ2xlLWl0ZW0gZW51bSBhbmQgZGVz Y3JpcHRpb24gaW4KICBpZi90aGVuCi0tCgpjb21taXQgZGJhYzQ0MzZlY2MzZjg1N2VmMGZhN2Ri ZTEwZDBmZDUxMTZjZGIyZApBdXRob3I6IEp1bnlpIFpoYW8gPGp1bnlpLnpoYW9AYW1sb2dpYy5j b20+CgpkdC1iaW5kaW5nczogaTNjOiBzaWx2YWNvLGkzYy1tYXN0ZXI6IEFkZCBBbWxvZ2ljIEE5 IHN1cHBvcnQKClRoaXMgY29tbWl0IGFkZHMgdGhlIGFtbG9naWMsYTktaTNjIGFuZCBhbWxvZ2lj LGE5LWFvLWkzYyBjb21wYXRpYmxlCnN0cmluZ3MgYW5kIHRoZWlyIHBlci12YXJpYW50IGNsb2Nr IGNvbnN0cmFpbnRzIHRvIHRoZSBTaWx2YWNvIEkzQyBtYXN0ZXIKRGV2aWNlIFRyZWUgYmluZGlu ZyBzY2hlbWEuCgo+IGRpZmYgLS1naXQgYS9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGlu Z3MvaTNjL3NpbHZhY28saTNjLW1hc3Rlci55YW1sIGIvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVl L2JpbmRpbmdzL2kzYy9zaWx2YWNvLGkzYy1tYXN0ZXIueWFtbAo+IGluZGV4IDg1MzA5MmY3NTIy ZDMuLmQ4OTJkNDJiZWU2NWMgMTAwNjQ0Cj4gLS0tIGEvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVl L2JpbmRpbmdzL2kzYy9zaWx2YWNvLGkzYy1tYXN0ZXIueWFtbAo+ICsrKyBiL0RvY3VtZW50YXRp b24vZGV2aWNldHJlZS9iaW5kaW5ncy9pM2Mvc2lsdmFjbyxpM2MtbWFzdGVyLnlhbWwKPiBAQCAt MTMsNiArMTMsOCBAQCBwcm9wZXJ0aWVzOgo+ICAgIGNvbXBhdGlibGU6Cj4gICAgICBvbmVPZjoK PiAgICAgICAgLSBlbnVtOgo+ICsgICAgICAgICAgLSBhbWxvZ2ljLGE5LWkzYwo+ICsgICAgICAg ICAgLSBhbWxvZ2ljLGE5LWFvLWkzYwo+ICAgICAgICAgICAgLSBudXZvdG9uLG5wY204NDUtaTNj Cj4gICAgICAgICAgICAtIHNpbHZhY28saTNjLW1hc3Rlci12MQo+ICAgICAgICAtIGl0ZW1zOgo+ IEBAIC0yOCwxNCArMzAsMTQgQEAgcHJvcGVydGllczoKPiAgICAgIG1heEl0ZW1zOiAxCj4gIAo+ ICAgIGNsb2NrczoKPiAtICAgIG1pbkl0ZW1zOiAyCj4gKyAgICBtaW5JdGVtczogMQo+ICAgICAg aXRlbXM6Cj4gICAgICAgIC0gZGVzY3JpcHRpb246IHN5c3RlbSBjbG9jawo+ICAgICAgICAtIGRl c2NyaXB0aW9uOiBidXMgY2xvY2sKPiAgICAgICAgLSBkZXNjcmlwdGlvbjogb3RoZXIgKHNsb3dl cikgZXZlbnRzIGNsb2NrCj4gIAo+ICAgIGNsb2NrLW5hbWVzOgo+IC0gICAgbWluSXRlbXM6IDIK PiArICAgIG1pbkl0ZW1zOiAxCj4gICAgICBpdGVtczoKPiAgICAgICAgLSBjb25zdDogcGNsawo+ ICAgICAgICAtIGNvbnN0OiBmYXN0X2Nsawo+IEBAIC03MCwxNSArNzIsMzUgQEAgYWxsT2Y6Cj4g ICAgICAgICAgY29tcGF0aWJsZToKPiAgICAgICAgICAgIGNvbnRhaW5zOgo+ICAgICAgICAgICAg ICBlbnVtOgo+ICsgICAgICAgICAgICAgIC0gYW1sb2dpYyxhOS1pM2MKPiAgICAgICAgICAgICAg ICAtIG54cCxpbXg5NC1pM2MKPiAgICAgICAgICAgICAgICAtIG54cCxpbXg5NS1pM2MKPiAgICAg IHRoZW46Cj4gICAgICAgIHByb3BlcnRpZXM6Cj4gICAgICAgICAgY2xvY2tzOgo+ICsgICAgICAg ICAgbWluSXRlbXM6IDIKPiAgICAgICAgICAgIG1heEl0ZW1zOiAyCj4gICAgICAgICAgY2xvY2st bmFtZXM6Cj4gKyAgICAgICAgICBtaW5JdGVtczogMgo+ICAgICAgICAgICAgbWF4SXRlbXM6IDIK CltTZXZlcml0eTogTG93XQpTaG91bGQgdGhlIEFtbG9naWMgQTkgdmFyaWFudHMgYmUgc3BsaXQg aW50byBhIHNlcGFyYXRlIGJpbmRpbmcgc2NoZW1hCmluc3RlYWQgb2YgYWRkaW5nIG1vcmUgcGVy LWNvbXBhdGlibGUgY29uZGl0aW9uYWxzIGhlcmU/CgpOZWl0aGVyIGFtbG9naWMsYTktaTNjIG5v ciBhbWxvZ2ljLGE5LWFvLWkzYyB1c2VzIHRoZSBzaWx2YWNvLGkzYy1tYXN0ZXItdjEKZmFsbGJh Y2ssIGFuZCBhY2NvbW1vZGF0aW5nIHRoZSAxLWNsb2NrIEFPIHZhcmlhbnQgd2Vha2VucyB0aGUg dG9wLWxldmVsCmNsb2NrcyBhbmQgY2xvY2stbmFtZXMgbWluSXRlbXMgdG8gMSBzbyB0aGF0IDMt Y2xvY2ssIDItY2xvY2ssIGFuZCAxLWNsb2NrCnZhcmlhbnRzIGFsbCBoYXZlIHRvIGJlIGNvbnN0 cmFpbmVkIHZpYSBzZXBhcmF0ZSBpZi90aGVuIGJsb2NrcyBpbiBhbGxPZi4KCj4gKwo+ICsgIC0g aWY6Cj4gKyAgICAgIHByb3BlcnRpZXM6Cj4gKyAgICAgICAgY29tcGF0aWJsZToKPiArICAgICAg ICAgIGNvbnRhaW5zOgo+ICsgICAgICAgICAgICBlbnVtOgo+ICsgICAgICAgICAgICAgIC0gYW1s b2dpYyxhOS1hby1pM2MKPiArICAgIHRoZW46Cj4gKyAgICAgIHByb3BlcnRpZXM6Cj4gKyAgICAg ICAgY2xvY2tzOgo+ICsgICAgICAgICAgbWF4SXRlbXM6IDEKPiArICAgICAgICAgIGRlc2NyaXB0 aW9uOgo+ICsgICAgICAgICAgICBUaGUgImFvIiB2YXJpYW50IGlzIHRoZSBjb250cm9sbGVyIGlu c3RhbmNlIGluIHRoZSBBbHdheXMtT24gKEFPKQo+ICsgICAgICAgICAgICBkb21haW4sIHdoaWNo IGhhcyBubyBzZXBhcmF0ZSBidXMgY2xvY2sgYW5kIGRlcml2ZXMgdGhlCj4gKyAgICAgICAgICAg IGJ1cyBjbG9jayBmcm9tIGFuIGludGVybmFsIGRpdmlkZXIuCj4gKyAgICAgICAgY2xvY2stbmFt ZXM6Cj4gKyAgICAgICAgICBtYXhJdGVtczogMQoKW1NldmVyaXR5OiBMb3ddCkRvZXMgdGhpcyBu ZXcgaWYvdGhlbiBibG9jayBwYXNzIGR0X2JpbmRpbmdfY2hlY2s/CgpUaGUgZHRzY2hlbWEgbWV0 YS1zY2hlbWEgcmVxdWlyZXMgZW51bSBhcnJheXMgdG8gaGF2ZSBhdCBsZWFzdCB0d28gaXRlbXMs CnNvIG1hdGNoaW5nIHRoZSBzaW5nbGUgYW1sb2dpYyxhOS1hby1pM2Mgc3RyaW5nIHVuZGVyIGNv bnRhaW5zIG5lZWRzIGNvbnN0CnJhdGhlciB0aGFuIGEgc2luZ2xlLWVudHJ5IGVudW0uICBBbHNv LCBwcm9wZXJ0eSBkZXNjcmlwdGlvbnMgYmVsb25nIGluIHRoZQp0b3AtbGV2ZWwgcHJvcGVydGll cyBibG9jayByYXRoZXIgdGhhbiBpbnNpZGUgYW4gaWYvdGhlbiBjb25kaXRpb25hbC4KCi0tIApT YXNoaWtvIEFJIHJldmlldyDCtyBodHRwczovL3Nhc2hpa28uZGV2LyMvcGF0Y2hzZXQvMjAyNjEx MDYtYTlfaTNjLXYzLTAtODA0YjY5YjkwOTViQGFtbG9naWMuY29tP3BhcnQ9MgoKX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYW1sb2dpYyBtYWls aW5nIGxpc3QKbGludXgtYW1sb2dpY0BsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5p bmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYW1sb2dpYwo= From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 41A0A606A329 for ; Fri, 6 Nov 2026 07:23:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=SH8Dkbrs; dkim=fail reason="signature verification failed" (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=lPb5vqkp DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Reply-To:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Date:References: In-Reply-To:Cc:To:Subject:From:Message-ID:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Unsubscribe-Post:List-Owner; bh=E+4moQjtrQas1yBFK6KNYbwtQwCi7Reectpvn1fRfH8=; b=SH8Dkbrs82YSBz74MmlzPfNKZo hldNjCvYXRVqNM8Lr24E5QCcXXYRdlfE/mtj1icLgryFH7gLXX5/uA3EQmT2s2vwU1gM8LnB4Oye0 aHz7HvPu3IHDJsIdHTsABPVZBAwp4DQOvzykqj+SBJlqRaJ6FeOm0qdiIJaKHncqzwy7BsG+V1P9W T+1HwyEOuOZqvMTXfFpke8+FxxL9F1CFGwb9KU+EL7j+7gmm0PRLL2z7oG6xUU/5e7/sHpaOSYRJf 2EyKPoSHlz+ZVWdeB/bGiAC0b8xx1zp4ZmnK8582hQoS0Pk9fMlADooljEWojo7o/yKWOsG89oCgO AYLZX+Og==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.100.1 #2 (Red Hat Linux)) id 1xPEHt-0000000BR6L-4Bsg; Fri, 06 Nov 2026 07:23:02 +0000 Received: from sea.source.kernel.org ([2600:3c0a:e001:78e:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.100.1 #2 (Red Hat Linux)) id 1xPEHs-0000000BR5z-1Fh1; Fri, 06 Nov 2026 07:23:00 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id 0D81B40103; Fri, 6 Nov 2026 07:23:00 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7B3DC1F0089F; Fri, 6 Nov 2026 07:22:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1793949779; bh=l+JJGuwRJM3z7N4kO/kgTH54i4ethXSyzCMfLiGeBfo=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=lPb5vqkp5peh+FGlxrIgMbxTsFX0re3sCatibuw+wXpGnX23nZuzPubjmu6xawIPT t0Hxcx27XKGjFyI7yEreLaIVcvB4P3PViVEdmTI5ymxZP64EzPduNxBt2X/4SnBEpA KTZKM741SufHk5Jw4O4P/B4hlRjB1gA55MOu6a3YTqOBEsyBLDbBMMeNu2plgk1ak/ n3YLpy42Hp8f/l8CnltK/dKphS6VwyVuVJoQLZFtpam1tMJK5rfyLtLIz9fE0+ja2p hCwY9yRaafS8Q9ARA+dp7MhTRnFsMLsjYBjDfSWi8QwVJnwcADgqkOqpkmbfQV3YiO aLennEEUfvdvA== Message-ID: From: sashiko-bot@kernel.org Subject: Re: [PATCH v3 2/2] dt-bindings: i3c: silvaco,i3c-master: Add Amlogic A9 support To: "Junyi Zhao" Cc: linux-i3c@lists.infradead.org, devicetree@vger.kernel.org, linux-amlogic@lists.infradead.org, imx@lists.linux.dev, robh@kernel.org, conor+dt@kernel.org, Frank.Li@kernel.org, neil.armstrong@linaro.org, "Alexandre Belloni" In-Reply-To: <20261106-a9_i3c-v3-2-804b69b9095b@amlogic.com> References: <20261106-a9_i3c-v3-0-804b69b9095b@amlogic.com> <20261106-a9_i3c-v3-2-804b69b9095b@amlogic.com> Date: Fri, 06 Nov 2026 07:22:59 +0000 X-BeenThere: linux-i3c@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev X-Archived-By: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-i3c" X-Spam-Status: No, score=-8.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 VGhhbmsgeW91IGZvciB5b3VyIGNvbnRyaWJ1dGlvbiEgU2FzaGlrbyBBSSByZXZpZXcgZm91bmQg MiBwb3RlbnRpYWwKaXNzdWVzIHRvIGNvbnNpZGVyOgotIFtMb3ddIGR0LWJpbmRpbmdzOiBpM2M6 IHNpbHZhY286IHVud2llbGR5IHBlci1jb21wYXRpYmxlIGNsb2NrCiAgY29uZGl0aW9uYWxzCi0g W0xvd10gZHQtYmluZGluZ3M6IGkzYzogc2lsdmFjbzogc2luZ2xlLWl0ZW0gZW51bSBhbmQgZGVz Y3JpcHRpb24gaW4KICBpZi90aGVuCi0tCgpjb21taXQgZGJhYzQ0MzZlY2MzZjg1N2VmMGZhN2Ri ZTEwZDBmZDUxMTZjZGIyZApBdXRob3I6IEp1bnlpIFpoYW8gPGp1bnlpLnpoYW9AYW1sb2dpYy5j b20+CgpkdC1iaW5kaW5nczogaTNjOiBzaWx2YWNvLGkzYy1tYXN0ZXI6IEFkZCBBbWxvZ2ljIEE5 IHN1cHBvcnQKClRoaXMgY29tbWl0IGFkZHMgdGhlIGFtbG9naWMsYTktaTNjIGFuZCBhbWxvZ2lj LGE5LWFvLWkzYyBjb21wYXRpYmxlCnN0cmluZ3MgYW5kIHRoZWlyIHBlci12YXJpYW50IGNsb2Nr IGNvbnN0cmFpbnRzIHRvIHRoZSBTaWx2YWNvIEkzQyBtYXN0ZXIKRGV2aWNlIFRyZWUgYmluZGlu ZyBzY2hlbWEuCgo+IGRpZmYgLS1naXQgYS9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGlu Z3MvaTNjL3NpbHZhY28saTNjLW1hc3Rlci55YW1sIGIvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVl L2JpbmRpbmdzL2kzYy9zaWx2YWNvLGkzYy1tYXN0ZXIueWFtbAo+IGluZGV4IDg1MzA5MmY3NTIy ZDMuLmQ4OTJkNDJiZWU2NWMgMTAwNjQ0Cj4gLS0tIGEvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVl L2JpbmRpbmdzL2kzYy9zaWx2YWNvLGkzYy1tYXN0ZXIueWFtbAo+ICsrKyBiL0RvY3VtZW50YXRp b24vZGV2aWNldHJlZS9iaW5kaW5ncy9pM2Mvc2lsdmFjbyxpM2MtbWFzdGVyLnlhbWwKPiBAQCAt MTMsNiArMTMsOCBAQCBwcm9wZXJ0aWVzOgo+ICAgIGNvbXBhdGlibGU6Cj4gICAgICBvbmVPZjoK PiAgICAgICAgLSBlbnVtOgo+ICsgICAgICAgICAgLSBhbWxvZ2ljLGE5LWkzYwo+ICsgICAgICAg ICAgLSBhbWxvZ2ljLGE5LWFvLWkzYwo+ICAgICAgICAgICAgLSBudXZvdG9uLG5wY204NDUtaTNj Cj4gICAgICAgICAgICAtIHNpbHZhY28saTNjLW1hc3Rlci12MQo+ICAgICAgICAtIGl0ZW1zOgo+ IEBAIC0yOCwxNCArMzAsMTQgQEAgcHJvcGVydGllczoKPiAgICAgIG1heEl0ZW1zOiAxCj4gIAo+ ICAgIGNsb2NrczoKPiAtICAgIG1pbkl0ZW1zOiAyCj4gKyAgICBtaW5JdGVtczogMQo+ICAgICAg aXRlbXM6Cj4gICAgICAgIC0gZGVzY3JpcHRpb246IHN5c3RlbSBjbG9jawo+ICAgICAgICAtIGRl c2NyaXB0aW9uOiBidXMgY2xvY2sKPiAgICAgICAgLSBkZXNjcmlwdGlvbjogb3RoZXIgKHNsb3dl cikgZXZlbnRzIGNsb2NrCj4gIAo+ICAgIGNsb2NrLW5hbWVzOgo+IC0gICAgbWluSXRlbXM6IDIK PiArICAgIG1pbkl0ZW1zOiAxCj4gICAgICBpdGVtczoKPiAgICAgICAgLSBjb25zdDogcGNsawo+ ICAgICAgICAtIGNvbnN0OiBmYXN0X2Nsawo+IEBAIC03MCwxNSArNzIsMzUgQEAgYWxsT2Y6Cj4g ICAgICAgICAgY29tcGF0aWJsZToKPiAgICAgICAgICAgIGNvbnRhaW5zOgo+ICAgICAgICAgICAg ICBlbnVtOgo+ICsgICAgICAgICAgICAgIC0gYW1sb2dpYyxhOS1pM2MKPiAgICAgICAgICAgICAg ICAtIG54cCxpbXg5NC1pM2MKPiAgICAgICAgICAgICAgICAtIG54cCxpbXg5NS1pM2MKPiAgICAg IHRoZW46Cj4gICAgICAgIHByb3BlcnRpZXM6Cj4gICAgICAgICAgY2xvY2tzOgo+ICsgICAgICAg ICAgbWluSXRlbXM6IDIKPiAgICAgICAgICAgIG1heEl0ZW1zOiAyCj4gICAgICAgICAgY2xvY2st bmFtZXM6Cj4gKyAgICAgICAgICBtaW5JdGVtczogMgo+ICAgICAgICAgICAgbWF4SXRlbXM6IDIK CltTZXZlcml0eTogTG93XQpTaG91bGQgdGhlIEFtbG9naWMgQTkgdmFyaWFudHMgYmUgc3BsaXQg aW50byBhIHNlcGFyYXRlIGJpbmRpbmcgc2NoZW1hCmluc3RlYWQgb2YgYWRkaW5nIG1vcmUgcGVy LWNvbXBhdGlibGUgY29uZGl0aW9uYWxzIGhlcmU/CgpOZWl0aGVyIGFtbG9naWMsYTktaTNjIG5v ciBhbWxvZ2ljLGE5LWFvLWkzYyB1c2VzIHRoZSBzaWx2YWNvLGkzYy1tYXN0ZXItdjEKZmFsbGJh Y2ssIGFuZCBhY2NvbW1vZGF0aW5nIHRoZSAxLWNsb2NrIEFPIHZhcmlhbnQgd2Vha2VucyB0aGUg dG9wLWxldmVsCmNsb2NrcyBhbmQgY2xvY2stbmFtZXMgbWluSXRlbXMgdG8gMSBzbyB0aGF0IDMt Y2xvY2ssIDItY2xvY2ssIGFuZCAxLWNsb2NrCnZhcmlhbnRzIGFsbCBoYXZlIHRvIGJlIGNvbnN0 cmFpbmVkIHZpYSBzZXBhcmF0ZSBpZi90aGVuIGJsb2NrcyBpbiBhbGxPZi4KCj4gKwo+ICsgIC0g aWY6Cj4gKyAgICAgIHByb3BlcnRpZXM6Cj4gKyAgICAgICAgY29tcGF0aWJsZToKPiArICAgICAg ICAgIGNvbnRhaW5zOgo+ICsgICAgICAgICAgICBlbnVtOgo+ICsgICAgICAgICAgICAgIC0gYW1s b2dpYyxhOS1hby1pM2MKPiArICAgIHRoZW46Cj4gKyAgICAgIHByb3BlcnRpZXM6Cj4gKyAgICAg ICAgY2xvY2tzOgo+ICsgICAgICAgICAgbWF4SXRlbXM6IDEKPiArICAgICAgICAgIGRlc2NyaXB0 aW9uOgo+ICsgICAgICAgICAgICBUaGUgImFvIiB2YXJpYW50IGlzIHRoZSBjb250cm9sbGVyIGlu c3RhbmNlIGluIHRoZSBBbHdheXMtT24gKEFPKQo+ICsgICAgICAgICAgICBkb21haW4sIHdoaWNo IGhhcyBubyBzZXBhcmF0ZSBidXMgY2xvY2sgYW5kIGRlcml2ZXMgdGhlCj4gKyAgICAgICAgICAg IGJ1cyBjbG9jayBmcm9tIGFuIGludGVybmFsIGRpdmlkZXIuCj4gKyAgICAgICAgY2xvY2stbmFt ZXM6Cj4gKyAgICAgICAgICBtYXhJdGVtczogMQoKW1NldmVyaXR5OiBMb3ddCkRvZXMgdGhpcyBu ZXcgaWYvdGhlbiBibG9jayBwYXNzIGR0X2JpbmRpbmdfY2hlY2s/CgpUaGUgZHRzY2hlbWEgbWV0 YS1zY2hlbWEgcmVxdWlyZXMgZW51bSBhcnJheXMgdG8gaGF2ZSBhdCBsZWFzdCB0d28gaXRlbXMs CnNvIG1hdGNoaW5nIHRoZSBzaW5nbGUgYW1sb2dpYyxhOS1hby1pM2Mgc3RyaW5nIHVuZGVyIGNv bnRhaW5zIG5lZWRzIGNvbnN0CnJhdGhlciB0aGFuIGEgc2luZ2xlLWVudHJ5IGVudW0uICBBbHNv LCBwcm9wZXJ0eSBkZXNjcmlwdGlvbnMgYmVsb25nIGluIHRoZQp0b3AtbGV2ZWwgcHJvcGVydGll cyBibG9jayByYXRoZXIgdGhhbiBpbnNpZGUgYW4gaWYvdGhlbiBjb25kaXRpb25hbC4KCi0tIApT YXNoaWtvIEFJIHJldmlldyDCtyBodHRwczovL3Nhc2hpa28uZGV2LyMvcGF0Y2hzZXQvMjAyNjEx MDYtYTlfaTNjLXYzLTAtODA0YjY5YjkwOTViQGFtbG9naWMuY29tP3BhcnQ9MgoKLS0gCmxpbnV4 LWkzYyBtYWlsaW5nIGxpc3QKbGludXgtaTNjQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xp c3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1pM2MK