All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Johan Hovold" <johan@kernel.org>
Cc: linux-usb@vger.kernel.org
Subject: Re: [PATCH] USB: serial: mct_u232: fix NULL-deref on open() failure
Date: Fri, 06 Nov 2026 08:06:17 +0000	[thread overview]
Message-ID: <sashiko-outbox-201021@kernel.org> (raw)
In-Reply-To: <20261106080155.1967097-1-johan@kernel.org>

> The driver uses a second interrupt endpoint for reading but still
> dereferences the port bulk-in URB pointer, which is no longer overridden
> by the driver, in an error path.
> 
> Fix the dev_err() on failure to submit the read interrupt URB to avoid
> dereferencing a NULL-pointer.
> 
> Fixes: 35807187e4b3 ("USB: mct_u232: clean up read implementation")
> Reported-by: syzbot+58b2d8b19cd6761a395b@syzkaller.appspotmail.com
> Closes: https://lore.kernel.org/6aed834c.dadc8e63.45095.0003.GAE@google.com
> Cc: stable@vger.kernel.org	# 3.10
> Signed-off-by: Johan Hovold <johan@kernel.org>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261106080155.1967097-1-johan@kernel.org?part=1


      reply	other threads:[~2026-11-06  8:06 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-06  8:01 [PATCH] USB: serial: mct_u232: fix NULL-deref on open() failure Johan Hovold
2026-11-06  8:06 ` sashiko-bot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-201021@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=johan@kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.