Re: [PATCH v3 1/7] dt-bindings: mfd: Describe the BCM6846 PMC complex

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 3 potential
issues to consider:
- [Low] dt-bindings: mfd: brcm,bcm6846-pmc references files added in
  next patch
- [Low] dt-bindings: mfd: brcm,bcm6846-pmc example child nodes out of
  name order
- [Low] dt-bindings: mfd: brcm,bcm6846-pmc expands PMB as Processor
  Monitor Bus
--

commit 843b048574d4c45f386b5f401c61ae92d14a122f
Author: Linus Walleij <linusw@kernel.org>

dt-bindings: mfd: Describe the BCM6846 PMC complex

This commit adds a Device Tree binding schema for the Broadcom BCM6846
third generation Power Management Controller (PMC3) complex.

> diff --git a/Documentation/devicetree/bindings/mfd/brcm,bcm6846-pmc.yaml b/Documentation/devicetree/bindings/mfd/brcm,bcm6846-pmc.yaml
> new file mode 100644
> index 0000000000000..d4c927cabb3f4
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mfd/brcm,bcm6846-pmc.yaml
> @@ -0,0 +1,82 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/mfd/brcm,bcm6846-pmc.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Broadcom BCM6846 Power Management Controller
> +
> +maintainers:
> +  - Linus Walleij <linusw@kernel.org>
> +
> +description:
> +  The third generation Power Management Controller (PMC3) contains several
> +  register banks. This binding describes the Processor Monitor Bus (PMB)
> +  interface within Procmon. The PMB child owns its register bank. The parent
> +  provides address translation and does not own a register bank.

[Severity: Low]
As reported by William Zhang on v2 [1], should PMB be expanded as Power
Management Bus instead of Processor Monitor Bus here and in the example
comment below, matching Documentation/devicetree/bindings/power/brcm,bcm-pmb.yaml?

> +
> +properties:
> +  compatible:
> +    items:
> +      - const: brcm,bcm6846-pmc
> +      - const: simple-mfd
> +
> +  ranges:
> +    maxItems: 1
> +
> +  "#address-cells":
> +    const: 1
> +
> +  "#size-cells":
> +    const: 1
> +
> +patternProperties:
> +  '^bus@[0-9a-f]+$':
> +    $ref: /schemas/soc/bcm/brcm,bcm6846-pmb.yaml#
> +    description: PMB configuration, keyhole and address mapping registers
> +
> +required:
> +  - compatible
> +  - ranges
> +  - '#address-cells'
> +  - '#size-cells'
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    #include <dt-bindings/clock/brcm,bcm6846-pmb.h>
> +    #include <dt-bindings/reset/brcm,bcm6846-pmb.h>

[Severity: Low]
As reported by Krzysztof Kozlowski on RFC [2], does make dt_binding_check
fail at this commit because /schemas/soc/bcm/brcm,bcm6846-pmb.yaml#, the
dt-bindings/clock/brcm,bcm6846-pmb.h and dt-bindings/reset/brcm,bcm6846-pmb.h
headers, and the child node bindings used in the example are not introduced
until the next patch in the series, commit "dt-bindings: soc: Describe the
BCM6846 Processor Monitor Bus"?  Ordering that patch before this one would
keep dt_binding_check bisectable across the series.

> +
> +    system-controller@ffb00000 {
> +        /* Broadcom BCM6846 Power Management Controller complex */
> +        compatible = "brcm,bcm6846-pmc", "simple-mfd";
> +        ranges = <0x0 0xffb00000 0x21000>;
> +        #address-cells = <1>;
> +        #size-cells = <1>;
> +
> +        /* Processor Monitor Bus */
> +        bus@20100 {
> +            compatible = "brcm,bcm6846-pmb";
> +            reg = <0x20100 0x200>;
> +
> +            pmb_clk: clock-controller {
> +                compatible = "brcm,bcm6846-pmb-clock";
> +                clocks = <&osc50m>;
> +                clock-names = "ref";
> +                #clock-cells = <1>;
> +            };
> +
> +            pmb_reset: reset-controller {
> +                compatible = "brcm,bcm6846-pmb-reset";
> +                #reset-cells = <1>;
> +            };
> +
> +            hwmon {
> +                compatible = "brcm,bcm6846-pmb-pvtmon";
> +                clocks = <&pmb_clk BCM6846_CLK_PVTMON>;
> +                resets = <&pmb_reset BCM6846_RESET_PVTMON>;
> +                #thermal-sensor-cells = <0>;
> +            };

[Severity: Low]
Should the hwmon node be placed before reset-controller so that the child
nodes without unit addresses under bus@20100 are ordered alphabetically by
node name?  Otherwise scripts/dtc/dt-check-style --mode=strict warns that
child node hwmon is out of name order.

[1] https://lore.kernel.org/r/CAHi4H7GOMM9K6XG15vPyFMLOza3QQ7QPxUkCi85jA_e9D6YbKg@mail.gmail.com
[2] https://lore.kernel.org/r/ddfe83b7-d4b8-4d56-a295-fde63519bdde@kernel.org

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261106-xg6846b-bcmbca-xrdp-reset-v3-0-d6adeb71afc9@kernel.org?part=1