All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Tiezhu Yang" <yangtiezhu@loongson.cn>
Cc: linux-perf-users@vger.kernel.org
Subject: Re: [PATCH v1 1/2] perf tests: Assign return value of ioctl in wp_modify test
Date: Fri, 06 Nov 2026 09:36:18 +0000	[thread overview]
Message-ID: <sashiko-outbox-201127@kernel.org> (raw)
In-Reply-To: <20261106092808.6914-2-yangtiezhu@loongson.cn>

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] perf tests: missing Fixes trailer for test__wp_modify() ioctl
  check
--

commit 36cc478a3007ff125acd9f095ef1c72b59deb4aa
Author: Tiezhu Yang <yangtiezhu@loongson.cn>

> perf tests: Assign return value of ioctl in wp_modify test
>
> In test__wp_modify(), the return value of ioctl PERF_EVENT_IOC_ENABLE
> was not being captured. As a result, the subsequent error handling was
> checking a stalled value of `ret` instead of the actual result of the
> enablement operation.
>
> Fix this by properly assigning the return value of the ioctl call to
> `ret` so that the test can correctly catch and report failures when
> enabling the watchpoint event.
>
> Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>

[Severity: Low]
This fixes a missing return value assignment introduced when the
watchpoint test was added.  Should the commit message include a Fixes
tag?

  Fixes: 2e85d5979e8d ("perf test: Add watchpoint test")

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261106092808.6914-1-yangtiezhu@loongson.cn?part=1

  reply	other threads:[~2026-11-06  9:36 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-06  9:28 [PATCH v1 0/2] perf tests: Fix and improve watchpoint tests Tiezhu Yang
2026-11-06  9:28 ` [PATCH v1 1/2] perf tests: Assign return value of ioctl in wp_modify test Tiezhu Yang
2026-11-06  9:36   ` sashiko-bot [this message]
2026-11-06  9:51     ` Tiezhu Yang
2026-11-09  4:54       ` Namhyung Kim
2026-11-06  9:28 ` [PATCH v1 2/2] perf tests: Use TEST_ASSERT_EQUAL for all watchpoint tests Tiezhu Yang
2026-11-06  9:34   ` sashiko-bot
2026-11-10  2:52 ` [PATCH v1 0/2] perf tests: Fix and improve " Namhyung Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-201127@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=yangtiezhu@loongson.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.