From: sashiko-bot@kernel.org
To: "Cunhao Lu" <1579567540@qq.com>
Cc: linux-usb@vger.kernel.org
Subject: Re: [PATCH] usb: core: hcd: Skip PHY rollback on failed autoresume
Date: Fri, 06 Nov 2026 09:48:54 +0000 [thread overview]
Message-ID: <sashiko-outbox-201150@kernel.org> (raw)
In-Reply-To: <20261106-fix-usb-hcd-autoresume-phy-rollback-v1-1-1ed900ddcd2d@qq.com>
> From: Cunhao Lu <1579567540@qq.com>
>
> hcd_bus_resume() resumes the root-hub PHYs only for non-automatic PM
> events, but its failure path suspends them unconditionally.
>
> A failed autoresume therefore drops PHY power references without a
> matching acquisition. If wakeup is disabled for the controller, it can
> also drop PHY initialization references. Subsequent cleanup can then
> report unbalanced regulator disables.
>
> Guard the failure-path PHY suspend with !PMSG_IS_AUTO(msg), matching
> the condition used for PHY resume.
>
> Fixes: 178a0bce05cb ("usb: core: hcd: integrate the PHY wrapper into the HCD core")
> Cc: stable@vger.kernel.org
> Signed-off-by: Cunhao Lu <1579567540@qq.com>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261106-fix-usb-hcd-autoresume-phy-rollback-v1-1-1ed900ddcd2d@qq.com?part=1
prev parent reply other threads:[~2026-11-06 9:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-06 9:28 [PATCH] usb: core: hcd: Skip PHY rollback on failed autoresume Cunhao Lu
2026-11-06 9:28 ` Cunhao Lu via B4 Relay
2026-11-06 9:48 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-201150@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=1579567540@qq.com \
--cc=linux-usb@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.