From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793958648; b=IAxCgYFDjqO8wtv6TcDdhEeyJVPLcjLTz/dMhOmuZm5ZAOPT5CpdXzvi5HkgCZkHFuqP D1vj5PY7UR3mIaEMywzYXTOUSyABqmFMuyNRY71lMEchBzNSUKdMBEYi+3NfQB/ZlvR5V YyqrPgg1iYsljleMoSbRS2i7F71GItNvsAPFQSmt0ZPRK9hr/h45sjXt0XAv8YXCjK+3/ wtNh7ionAtUonF8wGVSrWb8zMZdzPcvRzI11oQbEiabK9o58kccRzVXKgM8odpxycMibT xjbjNsGyEF8RdytS6JgJ3A8L1Ywir/bYs2fthMuq4mYd6wGO2HY4n7vNrc4YQnt/S/Q== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793958648; h=Received:DKIM-Signature:Message-ID:From:Subject:Reply-To:To:Cc: In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date; bh=+PeAqe5CPXxdSOZLrj9lW/HMctWWJka2EQwhjd7PBpk=; b=QF+uaDwAp/zaXbxuTygDu+Sdk0mkTvrcRaBX8ujDKXHjxsqLsAC5P3sHTojXVS+nxsRy 7SfmYP/miWpCBoC3+zi3k4e4US/hxt7osSeuTCV/u8GoVndmQ5nDJ+NBA+vd7T7EFLHxF d7PZbVOTjEfvUPq9z450gx+Rkf0nO4W5IpXoOBqgPmNewcI/GpXVt0Kg9Mb0HI0oKdHT8 vsHoEQrMPaWqKANA4ECmTvo3C0mKDi8Y1Vyd9UfgqlOoOOIG9S2Vl/EnUrxOBisEPDkqt Tx/aquEwnQ0BpTtaIAPB67Wynbxxe4HAaY6lHAeJwrICB8zyB5t4LKPaRfxZTU27KKA== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=ki2Y6VM1; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A2E226083608; Fri, 6 Nov 2026 09:50:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=ki2Y6VM1 Received: by smtp.kernel.org (Postfix) with ESMTPSA id D78831F0089F; Fri, 6 Nov 2026 09:50:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1793958647; bh=+PeAqe5CPXxdSOZLrj9lW/HMctWWJka2EQwhjd7PBpk=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=ki2Y6VM1yJg+RmSJZlGbytEO7ho2Ewa2faoib1xLWl/f4rDtUZ5yg9+dxnsnMYUXx r/FE9kk7ay4zXyc6Fe05bsAtSnag8b1NzupzBJJ5t/pPmq4bd+D1SK5LZpfSmZx1uY Md76NMuFif5M5bdZ4fU0kTIULQpj5hbJsEOhpEgJcW7AVh7xEUvL7MaBPSaJzxGvLu MTgjsyjPYI4OHeiBqmgMUQn8i27NUw3Ww08NtSziesS/jhfIjxvQ5Fn7djTb4BuoVG G3koUXls1RxaSEZDlPGO5oGJWQWH8UEjCmZ+fcGcz9+uPnc7C8wqpnnPwEiaI1tQwz ZDGZlrk16KRLg== Message-ID: From: sashiko-bot@kernel.org Subject: Re: [PATCH 24/25] riscv: add Metanoia MT2824 SoC and MT5824 EVB support Reply-To: sashiko-reviews@lists.linux.dev To: =?utf-8?b?QmVub8OudCBNb25pbg==?= Cc: devicetree@vger.kernel.org, linux-phy@lists.infradead.org, linux-usb@vger.kernel.org, linux-watchdog@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org, vkoul@kernel.org, neil.armstrong@linaro.org, olteanv@gmail.com In-Reply-To: <20261106-mt2824-v1-24-86087eaf5af4@bootlin.com> References: <20261106-mt2824-v1-0-86087eaf5af4@bootlin.com> <20261106-mt2824-v1-24-86087eaf5af4@bootlin.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Fri, 06 Nov 2026 09:50:46 +0000 X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list Thank you for your contribution! Sashiko AI review found 1 potential issue to consider: - [Medium] riscv: dts: metanoia: invalid uart0/uart1 aliases in mt5824-evb.dts -- commit 9f82e60e9d27daf0d2b50c91457b33d4fb60e507 Author: Beno=C3=AEt Monin riscv: add Metanoia MT2824 SoC and MT5824 EVB support This commit adds device tree files for the Metanoia MT2824 SoC and the MT5824 evaluation board. > diff --git a/arch/riscv/boot/dts/metanoia/mt5824-evb.dts b/arch/riscv/boo= t/dts/metanoia/mt5824-evb.dts > new file mode 100644 > index 0000000000000..d0e8eb0a49a43 > --- /dev/null > +++ b/arch/riscv/boot/dts/metanoia/mt5824-evb.dts > @@ -0,0 +1,81 @@ > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > +/* > + * Copyright (C) 2026 Metanoia Communications Inc.. All rights reserved. > + */ > + > +/dts-v1/; > + > +#include "mt2824.dtsi" > + > +/ { > + model =3D "Metanoia MT5824 EVB"; > + compatible =3D "metanoia,mt5824-evb", "metanoia,mt2824"; > + > + aliases { > + uart0 =3D &serial0; > + uart1 =3D &serial1; > + spi0 =3D &spi0; > + spi1 =3D &spi1; > + spi2 =3D &spi2; > + }; > + > + chosen { > + stdout-path =3D "uart0:115200n8"; > + }; [Severity: Medium] Should the UART aliases in /aliases and stdout-path be named serial0 and serial1 instead of uart0 and uart1? The devicetree serial binding (serial.yaml) requires UART aliases to use the serialN naming convention, so uart0 and uart1 fail dtbs_check validation. In addition, __uart_read_properties() looks up the "serial" alias stem via of_alias_get_id(dev_of_node(dev), "serial") when assigning port->line, causing the uart0 and uart1 alias indices to be ignored. --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20261106-mt2824-v1-= 0-86087eaf5af4@bootlin.com?part=3D24 From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 30159606A32F for ; Fri, 6 Nov 2026 09:50:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=qMp/G/Ok; dkim=fail reason="signature verification failed" (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=ki2Y6VM1 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Reply-To:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Date:References: In-Reply-To:Cc:To:Subject:From:Message-ID:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Unsubscribe-Post:List-Owner; bh=e0T52J2Qc+sLzZqwPpvMSIt/PUN+e9gyIg1NQ6mL+AE=; b=qMp/G/Okpl+r6G6DjGoPmCB1eT FzMTy/tG5ofTv+rSCr8tsNRzFdO5rsGmjkBI22NcN2vDkmxyWiYI7jGP8QuLXBhKuZsNFRoFCP617 1z+gmHYuMYLa6ezQ8vZyrjV/EQZJzumMCS/c7EIDfkHfgjUr09G9LTSlXEcKh+5oBNb6mNudw+A4z +ndnBrkwJzOdOPGJAQduDgLusUiFaUVyvF51oy3Zb74A/QETS5Gedf9FtvAbCzdABlzGD8kPUgxnH nPNRYcbm8c9sp9AsHNLNengbccXunQb+pGqcuQELwTroq05WSxmflyPUm1NBtPjCz/6GCr/j5LDNp IxGF39sw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.100.1 #2 (Red Hat Linux)) id 1xPGay-0000000BoVU-3tD4; Fri, 06 Nov 2026 09:50:52 +0000 Received: from sea.source.kernel.org ([172.234.252.31]) by bombadil.infradead.org with esmtps (Exim 4.100.1 #2 (Red Hat Linux)) id 1xPGat-0000000BoUK-440J for linux-phy@lists.infradead.org; Fri, 06 Nov 2026 09:50:49 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id 68EAF44530; Fri, 6 Nov 2026 09:50:47 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D78831F0089F; Fri, 6 Nov 2026 09:50:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1793958647; bh=+PeAqe5CPXxdSOZLrj9lW/HMctWWJka2EQwhjd7PBpk=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=ki2Y6VM1yJg+RmSJZlGbytEO7ho2Ewa2faoib1xLWl/f4rDtUZ5yg9+dxnsnMYUXx r/FE9kk7ay4zXyc6Fe05bsAtSnag8b1NzupzBJJ5t/pPmq4bd+D1SK5LZpfSmZx1uY Md76NMuFif5M5bdZ4fU0kTIULQpj5hbJsEOhpEgJcW7AVh7xEUvL7MaBPSaJzxGvLu MTgjsyjPYI4OHeiBqmgMUQn8i27NUw3Ww08NtSziesS/jhfIjxvQ5Fn7djTb4BuoVG G3koUXls1RxaSEZDlPGO5oGJWQWH8UEjCmZ+fcGcz9+uPnc7C8wqpnnPwEiaI1tQwz ZDGZlrk16KRLg== Message-ID: From: sashiko-bot@kernel.org Subject: Re: [PATCH 24/25] riscv: add Metanoia MT2824 SoC and MT5824 EVB support To: =?utf-8?b?QmVub8OudCBNb25pbg==?= Cc: devicetree@vger.kernel.org, linux-phy@lists.infradead.org, linux-usb@vger.kernel.org, linux-watchdog@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org, vkoul@kernel.org, neil.armstrong@linaro.org, olteanv@gmail.com In-Reply-To: <20261106-mt2824-v1-24-86087eaf5af4@bootlin.com> References: <20261106-mt2824-v1-0-86087eaf5af4@bootlin.com> <20261106-mt2824-v1-24-86087eaf5af4@bootlin.com> Date: Fri, 06 Nov 2026 09:50:46 +0000 X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev X-Archived-By: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-phy" X-Spam-Status: No, score=-8.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 VGhhbmsgeW91IGZvciB5b3VyIGNvbnRyaWJ1dGlvbiEgU2FzaGlrbyBBSSByZXZpZXcgZm91bmQg MSBwb3RlbnRpYWwKaXNzdWUgdG8gY29uc2lkZXI6Ci0gW01lZGl1bV0gcmlzY3Y6IGR0czogbWV0 YW5vaWE6IGludmFsaWQgdWFydDAvdWFydDEgYWxpYXNlcyBpbgogIG10NTgyNC1ldmIuZHRzCi0t Cgpjb21taXQgOWY4MmU2MGU5ZDI3ZGFmMGQyYjUwYzkxNDU3YjMzZDRmYjYwZTUwNwpBdXRob3I6 IEJlbm/DrnQgTW9uaW4gPGJlbm9pdC5tb25pbkBib290bGluLmNvbT4KCnJpc2N2OiBhZGQgTWV0 YW5vaWEgTVQyODI0IFNvQyBhbmQgTVQ1ODI0IEVWQiBzdXBwb3J0CgpUaGlzIGNvbW1pdCBhZGRz IGRldmljZSB0cmVlIGZpbGVzIGZvciB0aGUgTWV0YW5vaWEgTVQyODI0IFNvQyBhbmQgdGhlCk1U NTgyNCBldmFsdWF0aW9uIGJvYXJkLgoKPiBkaWZmIC0tZ2l0IGEvYXJjaC9yaXNjdi9ib290L2R0 cy9tZXRhbm9pYS9tdDU4MjQtZXZiLmR0cyBiL2FyY2gvcmlzY3YvYm9vdC9kdHMvbWV0YW5vaWEv bXQ1ODI0LWV2Yi5kdHMKPiBuZXcgZmlsZSBtb2RlIDEwMDY0NAo+IGluZGV4IDAwMDAwMDAwMDAw MDAuLmQwZThlYjBhNDlhNDMKPiAtLS0gL2Rldi9udWxsCj4gKysrIGIvYXJjaC9yaXNjdi9ib290 L2R0cy9tZXRhbm9pYS9tdDU4MjQtZXZiLmR0cwo+IEBAIC0wLDAgKzEsODEgQEAKPiArLy8gU1BE WC1MaWNlbnNlLUlkZW50aWZpZXI6IChHUEwtMi4wKyBPUiBNSVQpCj4gKy8qCj4gKyAqIENvcHly aWdodCAoQykgMjAyNiBNZXRhbm9pYSBDb21tdW5pY2F0aW9ucyBJbmMuLiBBbGwgcmlnaHRzIHJl c2VydmVkLgo+ICsgKi8KPiArCj4gKy9kdHMtdjEvOwo+ICsKPiArI2luY2x1ZGUgIm10MjgyNC5k dHNpIgo+ICsKPiArLyB7Cj4gKwltb2RlbCA9ICJNZXRhbm9pYSBNVDU4MjQgRVZCIjsKPiArCWNv bXBhdGlibGUgPSAibWV0YW5vaWEsbXQ1ODI0LWV2YiIsICJtZXRhbm9pYSxtdDI4MjQiOwo+ICsK PiArCWFsaWFzZXMgewo+ICsJCXVhcnQwID0gJnNlcmlhbDA7Cj4gKwkJdWFydDEgPSAmc2VyaWFs MTsKPiArCQlzcGkwID0gJnNwaTA7Cj4gKwkJc3BpMSA9ICZzcGkxOwo+ICsJCXNwaTIgPSAmc3Bp MjsKPiArCX07Cj4gKwo+ICsJY2hvc2VuIHsKPiArCQlzdGRvdXQtcGF0aCA9ICJ1YXJ0MDoxMTUy MDBuOCI7Cj4gKwl9OwoKW1NldmVyaXR5OiBNZWRpdW1dClNob3VsZCB0aGUgVUFSVCBhbGlhc2Vz IGluIC9hbGlhc2VzIGFuZCBzdGRvdXQtcGF0aCBiZSBuYW1lZCBzZXJpYWwwIGFuZApzZXJpYWwx IGluc3RlYWQgb2YgdWFydDAgYW5kIHVhcnQxPwoKVGhlIGRldmljZXRyZWUgc2VyaWFsIGJpbmRp bmcgKHNlcmlhbC55YW1sKSByZXF1aXJlcyBVQVJUIGFsaWFzZXMgdG8gdXNlCnRoZSBzZXJpYWxO IG5hbWluZyBjb252ZW50aW9uLCBzbyB1YXJ0MCBhbmQgdWFydDEgZmFpbCBkdGJzX2NoZWNrCnZh bGlkYXRpb24uICBJbiBhZGRpdGlvbiwgX191YXJ0X3JlYWRfcHJvcGVydGllcygpIGxvb2tzIHVw IHRoZSAic2VyaWFsIgphbGlhcyBzdGVtIHZpYSBvZl9hbGlhc19nZXRfaWQoZGV2X29mX25vZGUo ZGV2KSwgInNlcmlhbCIpIHdoZW4gYXNzaWduaW5nCnBvcnQtPmxpbmUsIGNhdXNpbmcgdGhlIHVh cnQwIGFuZCB1YXJ0MSBhbGlhcyBpbmRpY2VzIHRvIGJlIGlnbm9yZWQuCgotLSAKU2FzaGlrbyBB SSByZXZpZXcgwrcgaHR0cHM6Ly9zYXNoaWtvLmRldi8jL3BhdGNoc2V0LzIwMjYxMTA2LW10Mjgy NC12MS0wLTg2MDg3ZWFmNWFmNEBib290bGluLmNvbT9wYXJ0PTI0CgotLSAKbGludXgtcGh5IG1h aWxpbmcgbGlzdApsaW51eC1waHlAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwczovL2xpc3RzLmlu ZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1waHkK