From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0DCE7606A326 for ; Fri, 6 Nov 2026 10:59:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=rlgrKQ6Z; dkim=fail reason="signature verification failed" (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=GTfU6yHI DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Reply-To:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Date:References: In-Reply-To:Cc:To:Subject:From:Message-ID:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Unsubscribe-Post:List-Owner; bh=YeBoD4RcF3Yi2To0QD++Vo0NuO4qOMbbfxGL0cuS6os=; b=rlgrKQ6ZolKEyXP+L5eEhwdHMI wCrCWuxUnhzzVLwvkWj/TbEuQr08x4/N4Zx05Wj8y+wZRkSsn34+z7crcGUJPVt1fCaGie4Gi5gmA K/DK5gxrcq7ZmVsO9xT4TKzcdcBESw9jg49UvnRjzdELc4in3pGXFVsYorB/yv/aVCL7nTe5iB+FS ISlKw9GlaVY4wZTGqWNjUaGR28aTDdnc7CUeFZwQzLeFOO03cdnzaZQ+iYOojzcyOPJKu5/N9Quye aDiTujqOPI1cpm1EMz2zrgA2YlvKgBUbCSLERozTVbFgsRpqWmsKMBHYMq5L5U26b5q/KRbavOlgr eejQbMAg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.100.1 #2 (Red Hat Linux)) id 1xPHfl-0000000C4Zb-49yt; Fri, 06 Nov 2026 10:59:54 +0000 Received: from tor.source.kernel.org ([172.105.4.254]) by bombadil.infradead.org with esmtps (Exim 4.100.1 #2 (Red Hat Linux)) id 1xPHfk-0000000C4ZI-2kO1 for linux-amlogic@lists.infradead.org; Fri, 06 Nov 2026 10:59:52 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id DE1CD60232; Fri, 6 Nov 2026 10:59:51 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4F4051F0089F; Fri, 6 Nov 2026 10:59:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1793962791; bh=slv48Zzo7hdpis2W0rGmQzEpH7ISKDafg9bxgK1B+vc=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=GTfU6yHIBP1ckYhPmEDQcojpcSG8ZnvV7Ed2UwehB/HLhlYxUAD0pnIo9SH8zdv1n snQ864Dsn4FOD7s+04ioAoQWqe1m+SXKc/QmtAQkKWknAjnXE+BnoguFjguJNIYINK G6uw4etlu7KlKTS4PZh4vXmAqKme6Mp/I0pyMEJoFLJfq3+eyD/Crcgq6qtSTlO5Jj WPpZXKHk0j+r2ifTZc/QJGaPUpH3gW+qH2qML10HgzGixE6JrWuIwulrSRZHiyxd5o MGYppK61/pOoIB+sxn+H0MNWscw8JO44H6q/64TQ47i6xBV0MOBpQs+aaLn80Sq2rG KfRdHazxZ+gBA== Message-ID: From: sashiko-bot@kernel.org Subject: Re: [PATCH 08/10] arm64: dts: amlogic: meson-s4: add the USB host To: christian.koever-draxl@student.uibk.ac.at Cc: devicetree@vger.kernel.org, linux-amlogic@lists.infradead.org, robh@kernel.org, conor+dt@kernel.org, neil.armstrong@linaro.org In-Reply-To: <20261106104659.54656-9-christian.koever-draxl@student.uibk.ac.at> References: <20261106104659.54656-1-christian.koever-draxl@student.uibk.ac.at> <20261106104659.54656-9-christian.koever-draxl@student.uibk.ac.at> Date: Fri, 06 Nov 2026 10:59:50 +0000 X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev X-Archived-By: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-amlogic" X-Spam-Status: No, score=-8.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 VGhhbmsgeW91IGZvciB5b3VyIGNvbnRyaWJ1dGlvbiEgU2FzaGlrbyBBSSByZXZpZXcgZm91bmQg MyBwb3RlbnRpYWwKaXNzdWVzIHRvIGNvbnNpZGVyOgotIFtIaWdoXSBhcm02NDogZHRzOiBhbWxv Z2ljOiB1bm1hdGNoZWQgczQtdXNiMi1waHkgY29tcGF0aWJsZSBicmVha3MKICBVU0IgcHJvYmUK LSBbTWVkaXVtXSBhcm02NDogZHRzOiBhbWxvZ2ljOiBtZXNvbi1zNCBVU0IgZ2x1ZSBhbmQgeEhD SSB2aW9sYXRlIERUCiAgYmluZGluZwotIFtMb3ddIGFybTY0OiBkdHM6IGFtbG9naWM6IG1lc29u LXM0IFVTQjIgUEhZIG5vZGVzIG91dCBvZiBhZGRyZXNzCiAgb3JkZXIKLS0KCmNvbW1pdCA1MmFh Yzc2YzMxNjJmYjk4MWVlZjFmNGYxZTU1NDgxMWUzMjRhMDdlCkF1dGhvcjogQ2hyaXN0aWFuIFN0 ZWZhbiBLw7Z2w6lyLURyYXhsIDxja29ldmVyQG91dGxvb2suZGU+Cgphcm02NDogZHRzOiBhbWxv Z2ljOiBtZXNvbi1zNDogYWRkIHRoZSBVU0IgaG9zdAoKVGhpcyBjb21taXQgYWRkcyB0aGUgdHdv IFVTQjIgUEhZIG5vZGVzIGFuZCB0aGUgVVNCIGNvbnRyb2xsZXIgbm9kZSB3aXRoCml0cyBjaGls ZCB4SENJIGhvc3Qgbm9kZSB0byB0aGUgQW1sb2dpYyBNZXNvbiBTNCBTb0MgZGV2aWNlIHRyZWUu Cgo+IGRpZmYgLS1naXQgYS9hcmNoL2FybTY0L2Jvb3QvZHRzL2FtbG9naWMvbWVzb24tczQuZHRz aSBiL2FyY2gvYXJtNjQvYm9vdC9kdHMvYW1sb2dpYy9tZXNvbi1zNC5kdHNpCj4gaW5kZXggOGJi ZDcwZTUyYTI5OS4uMTU1OTk3NjQ5ZGMzYSAxMDA2NDQKPiAtLS0gYS9hcmNoL2FybTY0L2Jvb3Qv ZHRzL2FtbG9naWMvbWVzb24tczQuZHRzaQo+ICsrKyBiL2FyY2gvYXJtNjQvYm9vdC9kdHMvYW1s b2dpYy9tZXNvbi1zNC5kdHNpCj4gQEAgLTc3MCw2ICs3NzAsMjYgQEAgY3B1X3RlbXA6IHRlbXBl cmF0dXJlLXNlbnNvckAyMDAwMCB7Cj4gIAkJCQlhbWxvZ2ljLHNlY3VyZS1tb25pdG9yID0gPCZz bSAxPjsKPiAgCQkJfTsKPiAgCj4gKwkJCXVzYjJfcGh5MDogcGh5QDNjMDAwIHsKPiArCQkJCWNv bXBhdGlibGUgPSAiYW1sb2dpYyxzNC11c2IyLXBoeSI7Cj4gKwkJCQlyZWcgPSA8MHgwIDB4M2Mw MDAgMHgwIDB4MjAwMD47Cj4gKwkJCQljbG9ja3MgPSA8Jnh0YWw+Owo+ICsJCQkJY2xvY2stbmFt ZXMgPSAieHRhbCI7Cj4gKwkJCQlyZXNldHMgPSA8JnJlc2V0IFJFU0VUX1VTQlBIWTIwPjsKPiAr CQkJCXJlc2V0LW5hbWVzID0gInBoeSI7Cj4gKwkJCQkjcGh5LWNlbGxzID0gPDA+Owo+ICsJCQl9 Owo+ICsKPiArCQkJdXNiMl9waHkxOiBwaHlAM2UwMDAgewo+ICsJCQkJY29tcGF0aWJsZSA9ICJh bWxvZ2ljLHM0LXVzYjItcGh5IjsKPiArCQkJCXJlZyA9IDwweDAgMHgzZTAwMCAweDAgMHgyMDAw PjsKPiArCQkJCWNsb2NrcyA9IDwmeHRhbD47Cj4gKwkJCQljbG9jay1uYW1lcyA9ICJ4dGFsIjsK PiArCQkJCXJlc2V0cyA9IDwmcmVzZXQgUkVTRVRfVVNCUEhZMjE+Owo+ICsJCQkJcmVzZXQtbmFt ZXMgPSAicGh5IjsKPiArCQkJCSNwaHktY2VsbHMgPSA8MD47Cj4gKwkJCX07CgpbU2V2ZXJpdHk6 IEhpZ2hdCkRvZXMgImFtbG9naWMsczQtdXNiMi1waHkiIGhhdmUgYSBtYXRjaGluZyBkcml2ZXIg b3IgYmluZGluZyBpbiB0aGUga2VybmVsLApvciBkb2VzIGl0IG5lZWQgYSBmYWxsYmFjayBzdWNo IGFzICJhbWxvZ2ljLGcxMmEtdXNiMi1waHkiPwoKcGh5X21lc29uX2cxMmFfdXNiMl9vZl9tYXRj aFtdIGluIGRyaXZlcnMvcGh5L2FtbG9naWMvcGh5LW1lc29uLWcxMmEtdXNiMi5jCmFuZCBEb2N1 bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvcGh5L2FtbG9naWMsZzEyYS11c2IyLXBoeS55 YW1sIG9ubHkKbGlzdCAiYW1sb2dpYyxnMTJhLXVzYjItcGh5IiBhbmQgImFtbG9naWMsYTEtdXNi Mi1waHkiLiBXaXRob3V0IGEgbWF0Y2hpbmcKZHJpdmVyIG9yIGZhbGxiYWNrIGNvbXBhdGlibGUg b24gdXNiMl9waHkwIGFuZCB1c2IyX3BoeTEsIG5vIFBIWSBwcm92aWRlcgppcyByZWdpc3RlcmVk LCBzbyBkd2MzX21lc29uX2cxMmFfcHJvYmUoKSAtPiBkd2MzX21lc29uX2cxMmFfZ2V0X3BoeXMo KSAtPgpkZXZtX3BoeV9vcHRpb25hbF9nZXQoKSByZXR1cm5zIC1FUFJPQkVfREVGRVIgcGVybWFu ZW50bHkgd2hlbiB1c2JAZmUwM2EwMDAKaXMgZW5hYmxlZCwgYW5kIGR0YnNfY2hlY2sgZmFpbHMu Cgo+ICsKPiAgCQkJZXRoX3BoeTogbWRpby1tdWx0aXBsZXhlckAyODAwMCB7Cj4gIAkJCQljb21w YXRpYmxlID0gImFtbG9naWMsZzEyYS1tZGlvLW11eCI7Cj4gIAkJCQlyZWcgPSA8MHgwIDB4Mjgw MDAgMHgwIDB4YTQ+OwoKW1NldmVyaXR5OiBMb3ddClRoaXMgaXNuJ3QgYSBidWcsIGJ1dCBwaHlA M2MwMDAgYW5kIHBoeUAzZTAwMCBhcmUgcGxhY2VkIGJlZm9yZQptZGlvLW11bHRpcGxleGVyQDI4 MDAwIGluc3RlYWQgb2YgYWZ0ZXIgaXQgaW4gdW5pdC1hZGRyZXNzIG9yZGVyIHVuZGVyCmFwYjQu Cgo+IEBAIC05ODgsNiArMTAwOCwzMSBAQCBtZGlvMDogbWRpbyB7Cj4gIAkJCX07Cj4gIAkJfTsK PiAgCj4gKwkJdXNiOiB1c2JAZmUwM2EwMDAgewo+ICsJCQljb21wYXRpYmxlID0gImFtbG9naWMs bWVzb24tczQtdXNiLWN0cmwiLAo+ICsJCQkJICAgICAiYW1sb2dpYyxtZXNvbi1nMTJhLXVzYi1j dHJsIjsKPiArCQkJcmVnID0gPDB4MCAweGZlMDNhMDAwIDB4MCAweGEwPjsKPiArCQkJaW50ZXJy dXB0cyA9IDxHSUNfU1BJIDEyOSBJUlFfVFlQRV9MRVZFTF9ISUdIPjsKPiArCQkJI2FkZHJlc3Mt Y2VsbHMgPSA8Mj47Cj4gKwkJCSNzaXplLWNlbGxzID0gPDI+Owo+ICsJCQlyYW5nZXM7Cj4gKwkJ CWNsb2NrcyA9IDwmY2xrY19wZXJpcGhzIENMS0lEX1VTQj47Cj4gKwkJCXJlc2V0cyA9IDwmcmVz ZXQgUkVTRVRfVVNCQ1RSTD47Cj4gKwkJCXBvd2VyLWRvbWFpbnMgPSA8JnB3cmMgUFdSQ19TNF9V U0JfQ09NQl9JRD47Cj4gKwkJCWRyX21vZGUgPSAiaG9zdCI7Cj4gKwkJCXBoeXMgPSA8JnVzYjJf cGh5MD4sIDwmdXNiMl9waHkxPjsKPiArCQkJcGh5LW5hbWVzID0gInVzYjItcGh5MCIsICJ1c2Iy LXBoeTEiOwo+ICsJCQlzdGF0dXMgPSAiZGlzYWJsZWQiOwo+ICsKPiArCQkJY3JnX3hoY2k6IHVz YkBmZGUwMDAwMCB7Cj4gKwkJCQljb21wYXRpYmxlID0gImdlbmVyaWMteGhjaSI7Cj4gKwkJCQly ZWcgPSA8MHgwIDB4ZmRlMDAwMDAgMHgwIDB4MTAwMDAwPjsKPiArCQkJCWludGVycnVwdHMgPSA8 R0lDX1NQSSAxMzAgSVJRX1RZUEVfTEVWRUxfSElHSD47Cj4gKwkJCQljbG9ja3MgPSA8JmNsa2Nf cGVyaXBocyBDTEtJRF9VU0IxX1RPX0REUj47Cj4gKwkJCQlzdGF0dXMgPSAib2theSI7Cj4gKwkJ CX07Cj4gKwkJfTsKCltTZXZlcml0eTogTWVkaXVtXQpEbyB0aGUgY29tcGF0aWJsZSBzdHJpbmdz IG9uIHVzYkBmZTAzYTAwMCBhbmQgaXRzIGNoaWxkIHVzYkBmZGUwMDAwMCBtYXRjaApEb2N1bWVu dGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvdXNiL2FtbG9naWMsbWVzb24tZzEyYS11c2ItY3Ry bC55YW1sIGFuZApkcml2ZXJzL3VzYi9kd2MzL2R3YzMtbWVzb24tZzEyYS5jPwoKVGhlIGJpbmRp bmcgb25seSBhbGxvd3MgYSBzaW5nbGUgY29tcGF0aWJsZSBlbnRyeSBmcm9tIGl0cyBlbnVtICh3 aGljaCBkb2VzCm5vdCBpbmNsdWRlICJhbWxvZ2ljLG1lc29uLXM0LXVzYi1jdHJsIikgYW5kIHJl c3RyaWN0cyBjaGlsZCB1c2JAIG5vZGVzIHRvCmR3YzIueWFtbCMgb3Igc25wcyxkd2MzLnlhbWwj LCBzbyBib3RoIG5vZGVzIGZhaWwgZHRic19jaGVjay4gSW4gYWRkaXRpb24sCmR3YzNfbWVzb25f ZzEyYV9vdGdfaW5pdCgpIGxvb2tzIHVwIHRoZSBob3N0IGNoaWxkIHZpYQpkd2MzX21lc29uX2cx Ml9maW5kX2NoaWxkKGRldiwgInNucHMsZHdjMyIpLCB3aGljaCByZXR1cm5zIE5VTEwgd2hlbiB0 aGUKY2hpbGQgdXNlcyAiZ2VuZXJpYy14aGNpIi4KCi0tIApTYXNoaWtvIEFJIHJldmlldyDCtyBo dHRwczovL3Nhc2hpa28uZGV2LyMvcGF0Y2hzZXQvMjAyNjExMDYxMDQ2NTkuNTQ2NTYtMS1jaHJp c3RpYW4ua29ldmVyLWRyYXhsQHN0dWRlbnQudWliay5hYy5hdD9wYXJ0PTgKCl9fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFtbG9naWMgbWFpbGlu ZyBsaXN0CmxpbnV4LWFtbG9naWNAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5m cmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFtbG9naWMK From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793962792; b=keawglvdfjGeW/eswCbLgK/ufbrOwoaqnZro8vFLo1rZME+a7g/o1hjJF0Vl36Wy/KNv WQlKuGu5X/FGDoKziGH34nNfd7HCyV1GumjrhpEApRFGitC1qJfMFr26Z5Bnmk63ZsA8h kCMf/nKxFG5tUMFQKqlgqtHK9tl/ci53i1ZHezGwOmFpqmPS4HlAA4mSjyUKlL/d5HghR Wdul2MJ7InnEyByBD3+J+4QARAQAIIT8ZgqNAKbTPlt/Yixeg3dLhIz4dIImreaPoYKU/ Si9FVOVEG5a9YrelNp3nO/PljGDZjNaKaFD0khjsYyruMT1+f5wYwpMJd4syz7SJwvw== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793962792; h=Received:DKIM-Signature:Message-ID:From:Subject:Reply-To:To:Cc: In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date; bh=slv48Zzo7hdpis2W0rGmQzEpH7ISKDafg9bxgK1B+vc=; b=EWJlyaFKUB5tkNQesnjk9/ZT2PzENgL8UoNCcgUQEcl5s4m1k+dJU37QxLYrPglw0LQX EclFmA0L6zj2zFN371EhMjoVEeaWPQP/kh5nbxO30DJY7ZYlBNcl3BDwflaCyh5qhT3dY 74iGE9v3TmeRGXA5gj/w+kogUEs8/FsBi9k4mEYYiF1Yjhh15GiaPfWpfRPzFg4hSsA4Z e9l6CGeOK6ZJtxmR1xdptDbXVVXLQs9bGej9gPQkaCsBcTfBG39fs2PP4c662nEmujJZ6 IEweOBhr0oZvoOYo96+q4ejz0zE1xExlFpbtylwxHClnNGemz4elOkZseoTtWJ9fzyg== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=GTfU6yHI; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EE2C5606A326 for ; Fri, 6 Nov 2026 10:59:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=GTfU6yHI Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4F4051F0089F; Fri, 6 Nov 2026 10:59:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1793962791; bh=slv48Zzo7hdpis2W0rGmQzEpH7ISKDafg9bxgK1B+vc=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=GTfU6yHIBP1ckYhPmEDQcojpcSG8ZnvV7Ed2UwehB/HLhlYxUAD0pnIo9SH8zdv1n snQ864Dsn4FOD7s+04ioAoQWqe1m+SXKc/QmtAQkKWknAjnXE+BnoguFjguJNIYINK G6uw4etlu7KlKTS4PZh4vXmAqKme6Mp/I0pyMEJoFLJfq3+eyD/Crcgq6qtSTlO5Jj WPpZXKHk0j+r2ifTZc/QJGaPUpH3gW+qH2qML10HgzGixE6JrWuIwulrSRZHiyxd5o MGYppK61/pOoIB+sxn+H0MNWscw8JO44H6q/64TQ47i6xBV0MOBpQs+aaLn80Sq2rG KfRdHazxZ+gBA== Message-ID: From: sashiko-bot@kernel.org Subject: Re: [PATCH 08/10] arm64: dts: amlogic: meson-s4: add the USB host Reply-To: sashiko-reviews@lists.linux.dev To: christian.koever-draxl@student.uibk.ac.at Cc: devicetree@vger.kernel.org, linux-amlogic@lists.infradead.org, robh@kernel.org, conor+dt@kernel.org, neil.armstrong@linaro.org In-Reply-To: <20261106104659.54656-9-christian.koever-draxl@student.uibk.ac.at> References: <20261106104659.54656-1-christian.koever-draxl@student.uibk.ac.at> <20261106104659.54656-9-christian.koever-draxl@student.uibk.ac.at> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Fri, 06 Nov 2026 10:59:50 +0000 X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list Thank you for your contribution! Sashiko AI review found 3 potential issues to consider: - [High] arm64: dts: amlogic: unmatched s4-usb2-phy compatible breaks USB probe - [Medium] arm64: dts: amlogic: meson-s4 USB glue and xHCI violate DT binding - [Low] arm64: dts: amlogic: meson-s4 USB2 PHY nodes out of address order -- commit 52aac76c3162fb981eef1f4f1e554811e324a07e Author: Christian Stefan K=C3=B6v=C3=A9r-Draxl arm64: dts: amlogic: meson-s4: add the USB host This commit adds the two USB2 PHY nodes and the USB controller node with its child xHCI host node to the Amlogic Meson S4 SoC device tree. > diff --git a/arch/arm64/boot/dts/amlogic/meson-s4.dtsi b/arch/arm64/boot/= dts/amlogic/meson-s4.dtsi > index 8bbd70e52a299..155997649dc3a 100644 > --- a/arch/arm64/boot/dts/amlogic/meson-s4.dtsi > +++ b/arch/arm64/boot/dts/amlogic/meson-s4.dtsi > @@ -770,6 +770,26 @@ cpu_temp: temperature-sensor@20000 { > amlogic,secure-monitor =3D <&sm 1>; > }; > =20 > + usb2_phy0: phy@3c000 { > + compatible =3D "amlogic,s4-usb2-phy"; > + reg =3D <0x0 0x3c000 0x0 0x2000>; > + clocks =3D <&xtal>; > + clock-names =3D "xtal"; > + resets =3D <&reset RESET_USBPHY20>; > + reset-names =3D "phy"; > + #phy-cells =3D <0>; > + }; > + > + usb2_phy1: phy@3e000 { > + compatible =3D "amlogic,s4-usb2-phy"; > + reg =3D <0x0 0x3e000 0x0 0x2000>; > + clocks =3D <&xtal>; > + clock-names =3D "xtal"; > + resets =3D <&reset RESET_USBPHY21>; > + reset-names =3D "phy"; > + #phy-cells =3D <0>; > + }; [Severity: High] Does "amlogic,s4-usb2-phy" have a matching driver or binding in the kernel, or does it need a fallback such as "amlogic,g12a-usb2-phy"? phy_meson_g12a_usb2_of_match[] in drivers/phy/amlogic/phy-meson-g12a-usb2.c and Documentation/devicetree/bindings/phy/amlogic,g12a-usb2-phy.yaml only list "amlogic,g12a-usb2-phy" and "amlogic,a1-usb2-phy". Without a matching driver or fallback compatible on usb2_phy0 and usb2_phy1, no PHY provider is registered, so dwc3_meson_g12a_probe() -> dwc3_meson_g12a_get_phys() -> devm_phy_optional_get() returns -EPROBE_DEFER permanently when usb@fe03a000 is enabled, and dtbs_check fails. > + > eth_phy: mdio-multiplexer@28000 { > compatible =3D "amlogic,g12a-mdio-mux"; > reg =3D <0x0 0x28000 0x0 0xa4>; [Severity: Low] This isn't a bug, but phy@3c000 and phy@3e000 are placed before mdio-multiplexer@28000 instead of after it in unit-address order under apb4. > @@ -988,6 +1008,31 @@ mdio0: mdio { > }; > }; > =20 > + usb: usb@fe03a000 { > + compatible =3D "amlogic,meson-s4-usb-ctrl", > + "amlogic,meson-g12a-usb-ctrl"; > + reg =3D <0x0 0xfe03a000 0x0 0xa0>; > + interrupts =3D ; > + #address-cells =3D <2>; > + #size-cells =3D <2>; > + ranges; > + clocks =3D <&clkc_periphs CLKID_USB>; > + resets =3D <&reset RESET_USBCTRL>; > + power-domains =3D <&pwrc PWRC_S4_USB_COMB_ID>; > + dr_mode =3D "host"; > + phys =3D <&usb2_phy0>, <&usb2_phy1>; > + phy-names =3D "usb2-phy0", "usb2-phy1"; > + status =3D "disabled"; > + > + crg_xhci: usb@fde00000 { > + compatible =3D "generic-xhci"; > + reg =3D <0x0 0xfde00000 0x0 0x100000>; > + interrupts =3D ; > + clocks =3D <&clkc_periphs CLKID_USB1_TO_DDR>; > + status =3D "okay"; > + }; > + }; [Severity: Medium] Do the compatible strings on usb@fe03a000 and its child usb@fde00000 match Documentation/devicetree/bindings/usb/amlogic,meson-g12a-usb-ctrl.yaml and drivers/usb/dwc3/dwc3-meson-g12a.c? The binding only allows a single compatible entry from its enum (which does not include "amlogic,meson-s4-usb-ctrl") and restricts child usb@ nodes to dwc2.yaml# or snps,dwc3.yaml#, so both nodes fail dtbs_check. In addition, dwc3_meson_g12a_otg_init() looks up the host child via dwc3_meson_g12_find_child(dev, "snps,dwc3"), which returns NULL when the child uses "generic-xhci". --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20261106104659.5465= 6-1-christian.koever-draxl@student.uibk.ac.at?part=3D8