From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 61DBC606A329 for ; Fri, 6 Nov 2026 11:00:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=0q4WTBxs; dkim=fail reason="signature verification failed" (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=bkXh24YF DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Reply-To:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Date:References: In-Reply-To:Cc:To:Subject:From:Message-ID:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Unsubscribe-Post:List-Owner; bh=SmkYbH5NN+0GQ038gxfNt/gXXjMddTgjUzyxaSVS8js=; b=0q4WTBxsNnTJh/Eis7oorY8Nuq 1kQGtyUnGfWEYhacqiDYF3heEO8eqTUftEyoIf7/eLStDw7S6WWnumnXMIeNW/gyll/IRjhf+n/L6 wIk+qJla6E7n1yOf6DyxofLTk0UM2j46pa4LSmeyEbkmTLRhrM9Q6Cus52IL514L9bK2scV9ZHNWh PCmlvR7AoYTUEOZ3KjiD0HqJ6oZg3JPP1UtpgklpQiQjq841HBefraPK1lEJkQMVhWgk5MNdTuS7S hsEd/KQTqTe9WKE3Y5XkIzE72dmurLY+Dx3biu2QY3cg/Ixdi1+DQb7mpg+l5pP/QfIiVQbnsdsv1 GmUWJcvg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.100.1 #2 (Red Hat Linux)) id 1xPHgJ-0000000C4e1-0OA6; Fri, 06 Nov 2026 11:00:27 +0000 Received: from tor.source.kernel.org ([2600:3c04:e001:324:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.100.1 #2 (Red Hat Linux)) id 1xPHgH-0000000C4di-11JA for linux-amlogic@lists.infradead.org; Fri, 06 Nov 2026 11:00:25 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id 669D160232; Fri, 6 Nov 2026 11:00:24 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C64B41F0089F; Fri, 6 Nov 2026 11:00:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1793962824; bh=hwHd99ywMgYwfJC1nFZNiGjzvWRJKWtVA7N0uQzzsGY=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=bkXh24YFsYWI3AYpdeunIZ8hrEcnswsYlNowlcu6cYloJVAk8w6aQMQ7GpRKor8yL btjxAIpK2k/khTYn7nImZzjzv9orRJHXhNAaxPg2JPmOjC7vrJKbd2nL6imlrd1yhF etbuWTm5zLTEMJaBHAjV8FRdYRblPtyH6nSHB8Ygml0bb8Hg1kCTaIW35YQuGdLDBc Mb+JOjZqFMOjqAcH44DjbyZnZCuwXbeg/etZS1rlOwcSgsSHU9u5hmjvoYiegsyDtO 70nJOAsU5n1Enwc9hpZONtmgYVOcyA3YLrI7EJyyZy2NXSLpCpwGf5wfto2dtqUYb/ DzriljvgI/pqA== Message-ID: From: sashiko-bot@kernel.org Subject: Re: [PATCH 10/10] arm64: dts: amlogic: add the Amediatech X98Q To: christian.koever-draxl@student.uibk.ac.at Cc: devicetree@vger.kernel.org, linux-amlogic@lists.infradead.org, robh@kernel.org, conor+dt@kernel.org, neil.armstrong@linaro.org In-Reply-To: <20261106104659.54656-11-christian.koever-draxl@student.uibk.ac.at> References: <20261106104659.54656-1-christian.koever-draxl@student.uibk.ac.at> <20261106104659.54656-11-christian.koever-draxl@student.uibk.ac.at> Date: Fri, 06 Nov 2026 11:00:23 +0000 X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev X-Archived-By: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-amlogic" X-Spam-Status: No, score=-8.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 VGhhbmsgeW91IGZvciB5b3VyIGNvbnRyaWJ1dGlvbiEgU2FzaGlrbyBBSSByZXZpZXcgZm91bmQg NSBwb3RlbnRpYWwKaXNzdWVzIHRvIGNvbnNpZGVyOgotIFtIaWdoXSBhcm02NDogZHRzOiBhbWxv Z2ljOiB1bmltcGxlbWVudGVkIGFtbG9naWMsY29yZS1waGFzZS1kZWdyZWVzCiAgaW4geDk4cSBz ZCBub2RlCi0gW01lZGl1bV0gYXJtNjQ6IGR0czogYW1sb2dpYzogaW52YWxpZCByYy14OThxIG1h cCBhbmQgd2FrZXVwLXNvdXJjZSBvbgogIHg5OHEgaXIgbm9kZQotIFtNZWRpdW1dIGFybTY0OiBk dHM6IGFtbG9naWM6IHVuaW1wbGVtZW50ZWQgYW1sb2dpYyxzaGFyZWQtYW50ZW5uYSBvbgogIHg5 OHEgYmx1ZXRvb3RoCi0gW01lZGl1bV0gYXJtNjQ6IGR0czogYW1sb2dpYzogeDk4cSBlbmFibGVz IFM0IHVzYiwgZ2UyZCwgYW5kIHRoZXJtYWwKICB3aXRob3V0IGRyaXZlcnMKLSBbTG93XSBhcm02 NDogZHRzOiBhbWxvZ2ljOiB1bnVzZWQgc2RfM3YzIHJlZ3VsYXRvciBjbGFpbWluZyBHUElPRF80 IGluCiAgeDk4cSBkdHMKLS0KCmNvbW1pdCAzYjUwNzY3YTM5ZWU1OWVmZWY2NDU3YzRhYTk1YmJm MDMzODM0NzQ4CkF1dGhvcjogQ2hyaXN0aWFuIFN0ZWZhbiBLw7Z2w6lyLURyYXhsIDxja29ldmVy QG91dGxvb2suZGU+Cgphcm02NDogZHRzOiBhbWxvZ2ljOiBhZGQgdGhlIEFtZWRpYXRlY2ggWDk4 UQoKVGhpcyBjb21taXQgYWRkcyB0aGUgZGV2aWNlIHRyZWUgZm9yIHRoZSBBbWVkaWF0ZWNoIFg5 OFEgVFYgYm94IGJhc2VkIG9uCnRoZSBBbWxvZ2ljIFM5MDVXMiBTb0MuCgo+IGRpZmYgLS1naXQg YS9hcmNoL2FybTY0L2Jvb3QvZHRzL2FtbG9naWMvbWVzb24tczQtczkwNXcyLXg5OHEuZHRzIGIv YXJjaC9hcm02NC9ib290L2R0cy9hbWxvZ2ljL21lc29uLXM0LXM5MDV3Mi14OThxLmR0cwo+IG5l dyBmaWxlIG1vZGUgMTAwNjQ0Cj4gaW5kZXggMDAwMDAwMDAwMDAwMC4uMzg4MTk4NzU2YTNhMgo+ IC0tLSAvZGV2L251bGwKPiArKysgYi9hcmNoL2FybTY0L2Jvb3QvZHRzL2FtbG9naWMvbWVzb24t czQtczkwNXcyLXg5OHEuZHRzCgpbIC4uLiBdCgo+ICsJc2RfM3YzOiByZWd1bGF0b3Itc2QtM3Yz IHsKPiArCQljb21wYXRpYmxlID0gInJlZ3VsYXRvci1maXhlZCI7Cj4gKwkJcmVndWxhdG9yLW5h bWUgPSAiU0RfM1YzIjsKPiArCQlyZWd1bGF0b3ItbWluLW1pY3Jvdm9sdCA9IDwzMzAwMDAwPjsK PiArCQlyZWd1bGF0b3ItbWF4LW1pY3Jvdm9sdCA9IDwzMzAwMDAwPjsKPiArCQlncGlvID0gPCZn cGlvIEdQSU9EXzQgR1BJT19BQ1RJVkVfTE9XPjsKPiArCQlyZWd1bGF0b3ItYWx3YXlzLW9uOwo+ ICsJfTsKCltTZXZlcml0eTogTG93XQpTaG91bGQgJnNkIHVzZSAmc2RfM3YzIGZvciB2bW1jLXN1 cHBseSwgb3IgaXMgcmVndWxhdG9yLXNkLTN2MyB1bnVzZWQgb24KdGhpcyBib2FyZD8KCnJlZ3Vs YXRvci1zZC0zdjMgY2xhaW1zIEdQSU9EXzQgYW5kIGRyaXZlcyBpdCBsb3cgYXQgYm9vdCB2aWEK cmVndWxhdG9yLWFsd2F5cy1vbiwgYnV0ICZzZCBiZWxvdyBzZXRzIGJvdGggdm1tYy1zdXBwbHkg YW5kIHZxbW1jLXN1cHBseQp0byAmdmRkYW9fM3YzLCBsZWF2aW5nICZzZF8zdjMgdW5yZWZlcmVu Y2VkLgoKWyAuLi4gXQoKPiArJmlyIHsKPiArCXBpbmN0cmwtMCA9IDwmcmVtb3RlX3BpbnM+Owo+ ICsJcGluY3RybC1uYW1lcyA9ICJkZWZhdWx0IjsKPiArCWxpbnV4LHJjLW1hcC1uYW1lID0gInJj LXg5OHEiOwo+ICsJd2FrZXVwLXNvdXJjZTsKPiArCXN0YXR1cyA9ICJva2F5IjsKPiArfTsKCltT ZXZlcml0eTogTWVkaXVtXQpBcmUgInJjLXg5OHEiIGFuZCB3YWtldXAtc291cmNlIHN1cHBvcnRl ZCBvbiAmaXI/CgoicmMteDk4cSIgaXMgbm90IGluIERvY3VtZW50YXRpb24vZGV2aWNldHJlZS9i aW5kaW5ncy9tZWRpYS9yYy55YW1sIG9yCmRyaXZlcnMvbWVkaWEvcmMva2V5bWFwcy8uICBBdCBw cm9iZSwgcmNfcHJlcGFyZV9yeF9kZXZpY2UoKSBmYWxscyBiYWNrIHRvClJDX01BUF9FTVBUWSAo UkNfUFJPVE9fVU5LTk9XTikgYW5kIHBhc3NlcyB0aGF0IHRvCm1lc29uX2lyX2h3X2RlY29kZXJf aW5pdCgpLCB3aGljaCByZXR1cm5zIGVhcmx5IHdpdGhvdXQgc2V0dGluZwpJUl9ERUNfUkVHMV9F TkFCTEUgd2hlbiBSQ19QUk9UT19CSVRfTkVDIGlzIG5vdCBzZXQsIGxlYXZpbmcgdGhlIGhhcmR3 YXJlCklSIGRlY29kZXIgZGlzYWJsZWQgdW50aWwgcmVjb25maWd1cmVkIGZyb20gdXNlcnNwYWNl LgoKSW4gYWRkaXRpb24sIERvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9tZWRpYS9h bWxvZ2ljLG1lc29uNi1pci55YW1sCnNldHMgdW5ldmFsdWF0ZWRQcm9wZXJ0aWVzOiBmYWxzZSBh bmQgZG9lcyBub3QgYWxsb3cgd2FrZXVwLXNvdXJjZSwgYW5kCmRyaXZlcnMvbWVkaWEvcmMvbWVz b24taXIuYyBkb2VzIG5vdCBjb25maWd1cmUgd2FrZXVwIHN1cHBvcnQgYW5kIGRpc2FibGVzCklS X0RFQ19SRUcxX0VOQUJMRSBpbiBtZXNvbl9pcl9zdXNwZW5kKCkuCgpbIC4uLiBdCgo+ICsmc2Qg ewo+ICsJcGluY3RybC0wID0gPCZzZGNhcmRfcGlucz47Cj4gKwlwaW5jdHJsLTEgPSA8JnNkY2Fy ZF9jbGtfZ2F0ZV9waW5zPjsKPiArCXBpbmN0cmwtbmFtZXMgPSAiZGVmYXVsdCIsICJjbGstZ2F0 ZSI7Cj4gKwlidXMtd2lkdGggPSA8ND47Cj4gKwljYXAtc2QtaGlnaHNwZWVkOwo+ICsJLyogRmFp bHMgQ1JDIGF0IDUwIE1IeiB3aXRoIHRoZSBkZWZhdWx0IDE4MCBkZWdyZWUgcGhhc2UgKi8KPiAr CWFtbG9naWMsY29yZS1waGFzZS1kZWdyZWVzID0gPDI3MD47Cj4gKwltYXgtZnJlcXVlbmN5ID0g PDUwMDAwMDAwPjsKCltTZXZlcml0eTogSGlnaF0KRG9lcyBhbWxvZ2ljLGNvcmUtcGhhc2UtZGVn cmVlcyBoYXZlIGFueSBlZmZlY3QgaW4gbWFpbmxpbmU/CgpEb2N1bWVudGF0aW9uL2RldmljZXRy ZWUvYmluZGluZ3MvbW1jL2FtbG9naWMsbWVzb24tZ3gtbW1jLnlhbWwgc2V0cwp1bmV2YWx1YXRl ZFByb3BlcnRpZXM6IGZhbHNlIGFuZCBkb2VzIG5vdCBkZWZpbmUKYW1sb2dpYyxjb3JlLXBoYXNl LWRlZ3JlZXMsIHNvIGR0YnNfY2hlY2sgZmFpbHMuICBBdCBydW50aW1lLAptZXNvbl9tbWNfY2xr X2luaXQoKSBpbiBkcml2ZXJzL21tYy9ob3N0L21lc29uLWd4LW1tYy5jIHVuY29uZGl0aW9uYWxs eQpwcm9ncmFtcyBDTEtfUEhBU0VfMTgwIGFuZCBuZXZlciBwYXJzZXMgdGhpcyBwcm9wZXJ0eSwg bGVhdmluZyB0aGUgU0QKY29udHJvbGxlciBhdCB0aGUgMTgwLWRlZ3JlZSBwaGFzZSB3aGVyZSA1 MCBNSHogaGlnaC1zcGVlZCB0cmFuc2ZlcnMgZmFpbAp3aXRoIENSQyBlcnJvcnMuCgpbIC4uLiBd Cgo+ICsmdWFydF9hIHsKPiArCXBpbmN0cmwtMCA9IDwmdWFydF9hX3BpbnM+LCA8JnVhcnRfYV9j dHNfcnRzX3BpbnM+Owo+ICsJcGluY3RybC1uYW1lcyA9ICJkZWZhdWx0IjsKPiArCXVhcnQtaGFz LXJ0c2N0czsKPiArCXN0YXR1cyA9ICJva2F5IjsKPiArCj4gKwkvKiBCbHVldG9vdGggaGFsZiBv ZiB0aGUgQW1sb2dpYyBXMSBjb21ibyBjaGlwICovCj4gKwlibHVldG9vdGggewo+ICsJCWNvbXBh dGlibGUgPSAiYW1sb2dpYyx3MTU1czItYnQiOwo+ICsJCWNsb2NrcyA9IDwmc2Rpb18zMms+Owo+ ICsJCWVuYWJsZS1ncGlvcyA9IDwmZ3BpbyBHUElPWF8xNyBHUElPX0FDVElWRV9ISUdIPjsKPiAr CQl2ZGRpby1zdXBwbHkgPSA8JnZkZGlvX2FvMXY4PjsKPiArCQlmaXJtd2FyZS1uYW1lID0gImFt bG9naWMvYW1sX3cxX2J0X3VhcnQuYmluIjsKPiArCQlhbWxvZ2ljLHNoYXJlZC1hbnRlbm5hOwo+ ICsJfTsKPiArfTsKCltTZXZlcml0eTogTWVkaXVtXQpJcyBhbWxvZ2ljLHNoYXJlZC1hbnRlbm5h IHN1cHBvcnRlZCBieSB0aGUgYmluZGluZyBvciBkcml2ZXIgZm9yCmFtbG9naWMsdzE1NXMyLWJ0 PwoKRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL25ldC9ibHVldG9vdGgvYW1sb2dp Yyx3MTU1czItYnQueWFtbApzZXRzIGFkZGl0aW9uYWxQcm9wZXJ0aWVzOiBmYWxzZSBhbmQgZG9l cyBub3QgZGVmaW5lCmFtbG9naWMsc2hhcmVkLWFudGVubmEuICBJbiBkcml2ZXJzL2JsdWV0b290 aC9oY2lfYW1sLmMsIGFtbF9wYXJzZV9kdCgpCmRvZXMgbm90IHJlYWQgdGhpcyBwcm9wZXJ0eSBh bmQgYW1sX3NldHVwKCkgcGFzc2VzCmFtbGRldi0+YW1sX2Rldl9kYXRhLT5pc19jb2V4IChmYWxz ZSBmb3IgZGF0YV93MTU1czIpIHRvIGFtbF9jb25maWdfcmYoKSwKY29uZmlndXJpbmcgQU1MX1JG X0FOVF9ET1VCTEUgaW5zdGVhZCBvZiBBTUxfUkZfQU5UX1NJTkdMRS4KClsgLi4uIF0KCj4gKyZ1 c2Igewo+ICsJc3RhdHVzID0gIm9rYXkiOwo+ICt9Owo+ICsKPiArJnVzYjJfcGh5MCB7Cj4gKwlz dGF0dXMgPSAib2theSI7Cj4gK307Cj4gKwo+ICsmdXNiMl9waHkxIHsKPiArCXN0YXR1cyA9ICJv a2F5IjsKPiArfTsKCltTZXZlcml0eTogTWVkaXVtXQpDYW4gJnVzYiwgJmdlMmQsIG9yIEdQVSB0 aGVybWFsIHRocm90dGxpbmcgcHJvYmUgd2l0aCB0aGUgY29tcGF0aWJsZXMgaW4KbWVzb24tczQu ZHRzaT8KCkluIGFyY2gvYXJtNjQvYm9vdC9kdHMvYW1sb2dpYy9tZXNvbi1zNC5kdHNpLCB1c2Iy X3BoeTAgYW5kIHVzYjJfcGh5MSB1c2UKY29tcGF0aWJsZSA9ICJhbWxvZ2ljLHM0LXVzYjItcGh5 IiB3aXRob3V0IGFuICJhbWxvZ2ljLGcxMmEtdXNiMi1waHkiCmZhbGxiYWNrLCB3aGlsZSBkcml2 ZXJzL3BoeS9hbWxvZ2ljL3BoeS1tZXNvbi1nMTJhLXVzYjIuYyBvbmx5IG1hdGNoZXMKImFtbG9n aWMsZzEyYS11c2IyLXBoeSIgYW5kICJhbWxvZ2ljLGExLXVzYjItcGh5IiwgY2F1c2luZwpkd2Mz X21lc29uX2cxMmFfcHJvYmUoKSB0byBkZWZlciBpbmRlZmluaXRlbHkgaW4gZHdjM19tZXNvbl9n MTJhX2dldF9waHlzKCkuCkFsc28sIHVzYjJfcGh5MCBhbmQgdXNiMl9waHkxIGFyZSBhbHJlYWR5 IGVuYWJsZWQgaW4gbWVzb24tczQuZHRzaSwgc28gdGhlCnN0YXR1cyBvdmVycmlkZXMgaGVyZSBh cmUgcmVkdW5kYW50LgoKU2ltaWxhcmx5LCAmZ2UyZCB1c2VzICJhbWxvZ2ljLHM0LWdlMmQiIHdp dGhvdXQgYW4gImFtbG9naWMsYXhnLWdlMmQiCmZhbGxiYWNrIChkcml2ZXJzL21lZGlhL3BsYXRm b3JtL2FtbG9naWMvbWVzb24tZ2UyZC9nZTJkLmMgb25seSBtYXRjaGVzCiJhbWxvZ2ljLGF4Zy1n ZTJkIiksIGFuZCBjcHVfdGVtcCB1c2VzICJhbWxvZ2ljLHM0LXRoZXJtYWwiIHdpdGhvdXQgYW4K ImFtbG9naWMsdDctdGhlcm1hbCIgZmFsbGJhY2sgKGRyaXZlcnMvdGhlcm1hbC9hbWxvZ2ljX3Ro ZXJtYWwuYyBvbmx5Cm1hdGNoZXMgImFtbG9naWMsdDctdGhlcm1hbCIpLCBzbyBuZWl0aGVyIEdF MkQgbm9yIEdQVSB0aGVybWFsIHRocm90dGxpbmcKYmluZHMgYSBkcml2ZXIgZGVzcGl0ZSBiZWlu ZyBsaXN0ZWQgYXMgc3VwcG9ydGVkIGluIHRoZSBjb21taXQgbWVzc2FnZS4KCi0tIApTYXNoaWtv IEFJIHJldmlldyDCtyBodHRwczovL3Nhc2hpa28uZGV2LyMvcGF0Y2hzZXQvMjAyNjExMDYxMDQ2 NTkuNTQ2NTYtMS1jaHJpc3RpYW4ua29ldmVyLWRyYXhsQHN0dWRlbnQudWliay5hYy5hdD9wYXJ0 PTEwCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51 eC1hbWxvZ2ljIG1haWxpbmcgbGlzdApsaW51eC1hbWxvZ2ljQGxpc3RzLmluZnJhZGVhZC5vcmcK aHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hbWxvZ2lj Cg== From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793962824; b=dd9NuHtAws5IdU9FDGciT4uory1CAC4PyBVLNeIyb68XktHcCp3AocCy/7OE4G+hSYyh nWY/Eg/2+P52YOYrSJ+1g2/x58b6XdPEZR1dRe78NVl4PxG6HXvouPR1aq/CjUt1xgEKZ OjdDpcd2U58xYKzJEx3MbY2iT7moyTzqCzK0IkgXEq6UnDwigzgrTmAgxsEF19y7yF+eI 8j4Eb7XnllkqtmGDNyUGUzULqoYE6Dl8GJVlkQzVy/qGrc6qqgzE7L+8UHGNEgpwUU1Tu iUA7qcKLGigwGN4Z/Bki1E89gESJ0cuxrwINPb5YsKs0ypBi9gaZ8o2dwJnWAHa2NBQ== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793962824; h=Received:DKIM-Signature:Message-ID:From:Subject:Reply-To:To:Cc: In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date; bh=hwHd99ywMgYwfJC1nFZNiGjzvWRJKWtVA7N0uQzzsGY=; b=Nvp3oUICLjIQov6F3wKtKAKy+zC1ZpcyqfKyHJyY5Snq714AAsH3sBdh7zcQTOBrgfCj SLkUgXmVR+vETXhTHam1tjy+JC6Qbd4tXCTyZCQ6xIHEsRvYWCRZFJodcMk/Jk/s5USvE dTLz/5pk2eCNUnl+2r2bB/I/O+x61rdqhwbbpVpjFHAcMNKkvb2Ncq8iquvRVLlXwqGwV 9qo7bqbODnyY0B27gcVvEwJQgVD+AeR/zXM873sC7YxztyPZZ2OZ2hXoMBZDKLHoQ5yA5 0lGkJEWKdu5xd9tlFRKLjP3e3hcyvc1CgLFSkInimGEYFWtOK8L/8Du4HGPsx33Xj0Q== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=bkXh24YF; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7F35F606A32D for ; Fri, 6 Nov 2026 11:00:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=bkXh24YF Received: by smtp.kernel.org (Postfix) with ESMTPSA id C64B41F0089F; Fri, 6 Nov 2026 11:00:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1793962824; bh=hwHd99ywMgYwfJC1nFZNiGjzvWRJKWtVA7N0uQzzsGY=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=bkXh24YFsYWI3AYpdeunIZ8hrEcnswsYlNowlcu6cYloJVAk8w6aQMQ7GpRKor8yL btjxAIpK2k/khTYn7nImZzjzv9orRJHXhNAaxPg2JPmOjC7vrJKbd2nL6imlrd1yhF etbuWTm5zLTEMJaBHAjV8FRdYRblPtyH6nSHB8Ygml0bb8Hg1kCTaIW35YQuGdLDBc Mb+JOjZqFMOjqAcH44DjbyZnZCuwXbeg/etZS1rlOwcSgsSHU9u5hmjvoYiegsyDtO 70nJOAsU5n1Enwc9hpZONtmgYVOcyA3YLrI7EJyyZy2NXSLpCpwGf5wfto2dtqUYb/ DzriljvgI/pqA== Message-ID: From: sashiko-bot@kernel.org Subject: Re: [PATCH 10/10] arm64: dts: amlogic: add the Amediatech X98Q Reply-To: sashiko-reviews@lists.linux.dev To: christian.koever-draxl@student.uibk.ac.at Cc: devicetree@vger.kernel.org, linux-amlogic@lists.infradead.org, robh@kernel.org, conor+dt@kernel.org, neil.armstrong@linaro.org In-Reply-To: <20261106104659.54656-11-christian.koever-draxl@student.uibk.ac.at> References: <20261106104659.54656-1-christian.koever-draxl@student.uibk.ac.at> <20261106104659.54656-11-christian.koever-draxl@student.uibk.ac.at> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Fri, 06 Nov 2026 11:00:23 +0000 X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list Thank you for your contribution! Sashiko AI review found 5 potential issues to consider: - [High] arm64: dts: amlogic: unimplemented amlogic,core-phase-degrees in x98q sd node - [Medium] arm64: dts: amlogic: invalid rc-x98q map and wakeup-source on x98q ir node - [Medium] arm64: dts: amlogic: unimplemented amlogic,shared-antenna on x98q bluetooth - [Medium] arm64: dts: amlogic: x98q enables S4 usb, ge2d, and thermal without drivers - [Low] arm64: dts: amlogic: unused sd_3v3 regulator claiming GPIOD_4 in x98q dts -- commit 3b50767a39ee59efef6457c4aa95bbf033834748 Author: Christian Stefan K=C3=B6v=C3=A9r-Draxl arm64: dts: amlogic: add the Amediatech X98Q This commit adds the device tree for the Amediatech X98Q TV box based on the Amlogic S905W2 SoC. > diff --git a/arch/arm64/boot/dts/amlogic/meson-s4-s905w2-x98q.dts b/arch/= arm64/boot/dts/amlogic/meson-s4-s905w2-x98q.dts > new file mode 100644 > index 0000000000000..388198756a3a2 > --- /dev/null > +++ b/arch/arm64/boot/dts/amlogic/meson-s4-s905w2-x98q.dts [ ... ] > + sd_3v3: regulator-sd-3v3 { > + compatible =3D "regulator-fixed"; > + regulator-name =3D "SD_3V3"; > + regulator-min-microvolt =3D <3300000>; > + regulator-max-microvolt =3D <3300000>; > + gpio =3D <&gpio GPIOD_4 GPIO_ACTIVE_LOW>; > + regulator-always-on; > + }; [Severity: Low] Should &sd use &sd_3v3 for vmmc-supply, or is regulator-sd-3v3 unused on this board? regulator-sd-3v3 claims GPIOD_4 and drives it low at boot via regulator-always-on, but &sd below sets both vmmc-supply and vqmmc-supply to &vddao_3v3, leaving &sd_3v3 unreferenced. [ ... ] > +&ir { > + pinctrl-0 =3D <&remote_pins>; > + pinctrl-names =3D "default"; > + linux,rc-map-name =3D "rc-x98q"; > + wakeup-source; > + status =3D "okay"; > +}; [Severity: Medium] Are "rc-x98q" and wakeup-source supported on &ir? "rc-x98q" is not in Documentation/devicetree/bindings/media/rc.yaml or drivers/media/rc/keymaps/. At probe, rc_prepare_rx_device() falls back to RC_MAP_EMPTY (RC_PROTO_UNKNOWN) and passes that to meson_ir_hw_decoder_init(), which returns early without setting IR_DEC_REG1_ENABLE when RC_PROTO_BIT_NEC is not set, leaving the hardware IR decoder disabled until reconfigured from userspace. In addition, Documentation/devicetree/bindings/media/amlogic,meson6-ir.yaml sets unevaluatedProperties: false and does not allow wakeup-source, and drivers/media/rc/meson-ir.c does not configure wakeup support and disables IR_DEC_REG1_ENABLE in meson_ir_suspend(). [ ... ] > +&sd { > + pinctrl-0 =3D <&sdcard_pins>; > + pinctrl-1 =3D <&sdcard_clk_gate_pins>; > + pinctrl-names =3D "default", "clk-gate"; > + bus-width =3D <4>; > + cap-sd-highspeed; > + /* Fails CRC at 50 MHz with the default 180 degree phase */ > + amlogic,core-phase-degrees =3D <270>; > + max-frequency =3D <50000000>; [Severity: High] Does amlogic,core-phase-degrees have any effect in mainline? Documentation/devicetree/bindings/mmc/amlogic,meson-gx-mmc.yaml sets unevaluatedProperties: false and does not define amlogic,core-phase-degrees, so dtbs_check fails. At runtime, meson_mmc_clk_init() in drivers/mmc/host/meson-gx-mmc.c unconditionally programs CLK_PHASE_180 and never parses this property, leaving the SD controller at the 180-degree phase where 50 MHz high-speed transfers fail with CRC errors. [ ... ] > +&uart_a { > + pinctrl-0 =3D <&uart_a_pins>, <&uart_a_cts_rts_pins>; > + pinctrl-names =3D "default"; > + uart-has-rtscts; > + status =3D "okay"; > + > + /* Bluetooth half of the Amlogic W1 combo chip */ > + bluetooth { > + compatible =3D "amlogic,w155s2-bt"; > + clocks =3D <&sdio_32k>; > + enable-gpios =3D <&gpio GPIOX_17 GPIO_ACTIVE_HIGH>; > + vddio-supply =3D <&vddio_ao1v8>; > + firmware-name =3D "amlogic/aml_w1_bt_uart.bin"; > + amlogic,shared-antenna; > + }; > +}; [Severity: Medium] Is amlogic,shared-antenna supported by the binding or driver for amlogic,w155s2-bt? Documentation/devicetree/bindings/net/bluetooth/amlogic,w155s2-bt.yaml sets additionalProperties: false and does not define amlogic,shared-antenna. In drivers/bluetooth/hci_aml.c, aml_parse_dt() does not read this property and aml_setup() passes amldev->aml_dev_data->is_coex (false for data_w155s2) to aml_config_rf(), configuring AML_RF_ANT_DOUBLE instead of AML_RF_ANT_SINGLE. [ ... ] > +&usb { > + status =3D "okay"; > +}; > + > +&usb2_phy0 { > + status =3D "okay"; > +}; > + > +&usb2_phy1 { > + status =3D "okay"; > +}; [Severity: Medium] Can &usb, &ge2d, or GPU thermal throttling probe with the compatibles in meson-s4.dtsi? In arch/arm64/boot/dts/amlogic/meson-s4.dtsi, usb2_phy0 and usb2_phy1 use compatible =3D "amlogic,s4-usb2-phy" without an "amlogic,g12a-usb2-phy" fallback, while drivers/phy/amlogic/phy-meson-g12a-usb2.c only matches "amlogic,g12a-usb2-phy" and "amlogic,a1-usb2-phy", causing dwc3_meson_g12a_probe() to defer indefinitely in dwc3_meson_g12a_get_phys(). Also, usb2_phy0 and usb2_phy1 are already enabled in meson-s4.dtsi, so the status overrides here are redundant. Similarly, &ge2d uses "amlogic,s4-ge2d" without an "amlogic,axg-ge2d" fallback (drivers/media/platform/amlogic/meson-ge2d/ge2d.c only matches "amlogic,axg-ge2d"), and cpu_temp uses "amlogic,s4-thermal" without an "amlogic,t7-thermal" fallback (drivers/thermal/amlogic_thermal.c only matches "amlogic,t7-thermal"), so neither GE2D nor GPU thermal throttling binds a driver despite being listed as supported in the commit message. --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20261106104659.5465= 6-1-christian.koever-draxl@student.uibk.ac.at?part=3D10