Re: [PATCH 1/2] regulator: dt-bindings: willsemi,wl2868c: add the WL2868C camera PMIC

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential
issues to consider:
- [Low] regulator: dt-bindings: willsemi,wl2868c: unrelated node in
  binding example
- [Low] MAINTAINERS: nonexistent wl2868c-regulator.c path in dt-bindings
  patch
--

commit 445721dc45dd58c5fcd063ef3e6a8215d244f0d7
Author: Qianhui Xu <xiaqinghuan@mail.ustc.edu.cn>

regulator: dt-bindings: willsemi,wl2868c: add the WL2868C camera PMIC

This commit adds the Device Tree binding schema and maintainer entry for
the Will Semiconductor wl2868c camera power management chip.

> diff --git a/Documentation/devicetree/bindings/regulator/willsemi,wl2868c.yaml b/Documentation/devicetree/bindings/regulator/willsemi,wl2868c.yaml
> new file mode 100644
> index 0000000000000..df7990d0d8a4e
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/regulator/willsemi,wl2868c.yaml
[ ... ]
> +examples:
> +  - |
> +    i2c {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +
> +        pmic@2f {
> +            compatible = "willsemi,wl2868c";
> +            reg = <0x2f>;
> +            vsys-supply = <&vsys_reg>;
> +
> +            regulators {
> +                ldo1 {
> +                    regulator-max-microvolt = <1128000>;
> +                    regulator-min-microvolt = <1128000>;
> +                };
> +            };
> +        };
> +    };
> +
> +    vsys_reg: regulator-vsys {
> +        compatible = "regulator-fixed";
> +        regulator-name = "vsys";
> +    };
> +...

[Severity: Low]
Should regulator-vsys be dropped from the example?  Per
Documentation/devicetree/bindings/writing-schema.rst, binding examples
should only describe the binding being documented and do not need provider
nodes to resolve phandles such as vsys_reg.  Also, since the example
enables ldo1 and the description states that input supplies may be omitted
only when their outputs are unused, pmic@2f should include vin12-supply.

> diff --git a/MAINTAINERS b/MAINTAINERS
> index fe23913b1e432..08cfa3db0ecbe 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -30180,6 +30180,13 @@ L:	linux-input@vger.kernel.org
>  S:	Maintained
>  F:	drivers/hid/hid-wiimote*
>  
> +WILLSEMI WL2868C CAMERA PMIC
> +M:	Qianhui Xu <xiaqinghuan@mail.ustc.edu.cn>
> +L:	linux-kernel@vger.kernel.org
> +S:	Maintained
> +F:	Documentation/devicetree/bindings/regulator/willsemi,wl2868c.yaml
> +F:	drivers/regulator/wl2868c-regulator.c

[Severity: Low]
Should the drivers/regulator/wl2868c-regulator.c entry be deferred to
commit "regulator: willsemi,wl2868c: add the WL2868C camera PMIC driver"
where that file is created?  Adding the path here causes
scripts/get_maintainer.pl --self-test=patterns to warn that no file matches
drivers/regulator/wl2868c-regulator.c at this commit.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261106113005.970822-1-xiaqinghuan@mail.ustc.edu.cn?part=1