Re: [PATCH v14 7/9] arm64: dts: qcom: agatti: Add OPE node

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Medium] arm64: dts: qcom: agatti: duplicate OPE SMMU stream IDs in
  camss and isp_ope
--

commit 9d7482129728d89f99954ecd37376475c831380d
Author: Loic Poulain <loic.poulain@oss.qualcomm.com>

arm64: dts: qcom: agatti: Add OPE node

This commit adds the Offline Processing Engine (OPE) device tree node and its
OPP table for the Agatti (QCM2290) platform.

> diff --git a/arch/arm64/boot/dts/qcom/agatti.dtsi b/arch/arm64/boot/dts/qcom/agatti.dtsi
> index d9f4cbfd2861c..8f2b451b8f6e8 100644
> --- a/arch/arm64/boot/dts/qcom/agatti.dtsi
> +++ b/arch/arm64/boot/dts/qcom/agatti.dtsi
> @@ -1990,6 +1990,83 @@ port@1 {
>  			};
>  		};
>  
> +		isp_ope: isp@5c42000 {
> +			compatible = "qcom,qcm2290-camss-ope";
> +
> +			reg = <0x0 0x5c42000 0x0 0x400>,
> +			      <0x0 0x5c42400 0x0 0x200>,
> +			      <0x0 0x5c42600 0x0 0x200>,
> +			      <0x0 0x5c42800 0x0 0x4400>,
> +			      <0x0 0x5c46c00 0x0 0x190>,
> +			      <0x0 0x5c46d90 0x0 0xa00>;
> +			reg-names = "cdm",
> +				    "top",
> +				    "qos",
> +				    "pipeline",
> +				    "bus_read",
> +				    "bus_write";
> +
> +			clocks = <&gcc GCC_CAMSS_AXI_CLK>,
> +				 <&gcc GCC_CAMSS_OPE_CLK>,
> +				 <&gcc GCC_CAMSS_OPE_AHB_CLK>,
> +				 <&gcc GCC_CAMSS_NRT_AXI_CLK>,
> +				 <&gcc GCC_CAMSS_TOP_AHB_CLK>;
> +			clock-names = "axi",
> +				      "core",
> +				      "iface",
> +				      "nrt",
> +				      "top";
> +
> +			interrupts = <GIC_SPI 209 IRQ_TYPE_EDGE_RISING>;
> +
> +			interconnects = <&bimc MASTER_APPSS_PROC RPM_ACTIVE_TAG
> +					 &config_noc SLAVE_CAMERA_CFG RPM_ACTIVE_TAG>,
> +					<&mmnrt_virt MASTER_CAMNOC_SF RPM_ALWAYS_TAG
> +					 &bimc SLAVE_EBI1 RPM_ALWAYS_TAG>;
> +			interconnect-names = "config",
> +					     "data";
> +
> +			iommus = <&apps_smmu 0x800 0x0>,
> +				 <&apps_smmu 0x820 0x0>,
> +				 <&apps_smmu 0x840 0x0>;

[Severity: Medium]
Should the OPE SMMU stream IDs (0x800, 0x820, and 0x840) be removed from the
sibling camss node when adding isp_ope?

arch/arm64/boot/dts/qcom/agatti.dtsi:camss {
    ...
			iommus = <&apps_smmu 0x400 0x0>,
				 <&apps_smmu 0x800 0x0>,
				 <&apps_smmu 0x820 0x0>,
				 <&apps_smmu 0x840 0x0>;
    ...
}

When camss is enabled (for example via qrb2210-rb1-vision-mezzanine.dtso),
having both nodes claim stream IDs 0x800, 0x820, and 0x840 causes
arm_smmu_device_group() to merge camss and isp_ope into a single iommu_group
and shared DMA domain instead of isolating them.  In addition, when isp_ope is
probed before camss, arm_smmu_device_group() returns the existing group found
on 0x800 without setting smmu->s2crs[idx].group for camss's VFE stream ID
0x400.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261106-camss-isp-ope-v14-0-49c426cd2715@oss.qualcomm.com?part=7