Re: [PATCH net-next v4 4/8] dt-bindings: mfd: Add SoC-e SWIP parent

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential
issues to consider:
- [Low] dt-bindings: mfd: ranges ordered after
  #address-cells/#size-cells in soce,swip
- [Low] dt-bindings: mfd: mdio@204 ordered before mdio-mux@202 in
  soce,swip
--

commit 801ea0c5b85665a13499e976133e6d6ca196c4a0
Author: Vasilij Strassheim <v.strassheim@linutronix.de>

dt-bindings: mfd: Add SoC-e SWIP parent

This commit adds a devicetree binding schema for the SoC-e SWIP
multifunction Ethernet switch FPGA IP core, describing its shared MMIO
address space and child nodes.

> diff --git a/Documentation/devicetree/bindings/mfd/soce,swip.yaml b/Documentation/devicetree/bindings/mfd/soce,swip.yaml
> new file mode 100644
> index 0000000000000..625be299e262e
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mfd/soce,swip.yaml
> @@ -0,0 +1,137 @@

[ ... ]

> +properties:
> +  compatible:
> +    const: soce,swip
> +
> +  reg:
> +    maxItems: 1
> +
> +  '#address-cells':
> +    const: 1
> +
> +  '#size-cells':
> +    const: 1
> +
> +  ranges: true
> +
> +  mdio@204:
> +    $ref: /schemas/net/soce,swip-mdio.yaml#
> +    unevaluatedProperties: false
> +
> +  mdio-mux@202:
> +    $ref: /schemas/net/mdio-mux-mmioreg.yaml#
> +    unevaluatedProperties: false
> +
> +  ethernet-switch:
> +    $ref: /schemas/net/dsa/soce,swip-switch.yaml#
> +    unevaluatedProperties: false
> +
> +required:
> +  - compatible
> +  - reg
> +  - '#address-cells'
> +  - '#size-cells'
> +  - ranges
> +  - ethernet-switch
> +
> +dependentRequired:
> +  mdio-mux@202:
> +    - mdio@204
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    ethernet-switch@80020000 {
> +        compatible = "soce,swip";
> +        reg = <0x80020000 0x10000>;
> +        #address-cells = <1>;
> +        #size-cells = <1>;
> +        ranges = <0x0 0x80020000 0x10000>;

[Severity: Low]
In Documentation/devicetree/bindings/mfd/soce,swip.yaml, the properties,
required, and examples sections place ranges after #address-cells and
#size-cells.

Running scripts/dtc/dt-check-style --mode=strict on this binding reports a
property-order failure because Documentation/devicetree/bindings/dts-coding-style.rst
and Documentation/devicetree/bindings/writing-schema.rst place ranges before
standard properties like #address-cells and #size-cells.

Should ranges be moved before #address-cells and #size-cells in properties,
required, and examples?

> +
> +        mdio_parent: mdio@204 {
> +            compatible = "soce,swip-mdio";
> +            reg = <0x204 0xc>, <0x200 0x2>;
> +            reg-names = "data", "control";
> +            #address-cells = <1>;
> +            #size-cells = <0>;
> +        };
> +
> +        mdio-mux@202 {

[Severity: Low]
Similarly, in both properties and examples in
Documentation/devicetree/bindings/mfd/soce,swip.yaml, mdio@204 is placed
before mdio-mux@202, which causes scripts/dtc/dt-check-style --mode=strict
to report a child-address-order warning.

Could mdio-mux@202 be ordered before mdio@204 so the child nodes follow
ascending hexadecimal unit-address order?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261105-devel-vstrassheim-soce-dsa-ml-v4-0-02f3cde2afa1@linutronix.de?part=4