Re: [PATCH v5 06/14] linux/log2.h: Add 64-bit roundup/down_pow_of_two_u64() variants

[sashiko-bot@kernel.org]

> Generic sounding roundup_pow_of_two() and rounddown_pow_of_two() are
> internally based on fls_long() that limits types to unsigned long. The
> type limitation is unexpected and undocumented.
> 
> Worse yet, the typing seems also inconsistent between
> __builtin_constant_p() and __roundup/down_pow_of_two() branches, the
> former using full 64-bit size and the latter truncating type.
> 
> The most sensible way seems to be eventually changing types such that
> the return type for roundup/down_pow_of_two() is the same as the input
> but it requires auditing all the existing callers that have mixed
> input/output types.
> 
> As a stopgap solution, add roundup/down_pow_of_two_u64() that do not
> unexpectedly truncate 64-bit input.
> 
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261106134341.39493-1-ilpo.jarvinen@linux.intel.com?part=6