Re: [PATCH v7 12/19] drm/bridge: inno-hdmi: Make the PHY configuration table optional

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Medium] drm/bridge: inno-hdmi: unguarded integrated-PHY writes when
  phy_configs is NULL
--

commit f1f2bae7d85c6c615ff85796724277a1cd86c36d
Author: Michal Wilczynski <m.wilczynski@samsung.com>

drm/bridge: inno-hdmi: Make the PHY configuration table optional

This commit makes plat_data->phy_configs optional so platforms with a
separate PHY device skip the integrated-PHY register writes in
inno_hdmi_power_up() and the table lookup in inno_hdmi_bridge_mode_valid().

> diff --git a/drivers/gpu/drm/bridge/inno-hdmi.c b/drivers/gpu/drm/bridge/inno-hdmi.c
> index 3219558d6ef41..84d00ee52b732 100644
> --- a/drivers/gpu/drm/bridge/inno-hdmi.c
> +++ b/drivers/gpu/drm/bridge/inno-hdmi.c
> @@ -534,8 +534,14 @@ static void inno_hdmi_power_up(struct inno_hdmi *hdmi,
>  			       unsigned long mpixelclock)
>  {
>  	struct inno_hdmi_phy_config *phy_config;
> -	int ret = inno_hdmi_find_phy_config(hdmi, mpixelclock);
> +	int ret;
> +
> +	inno_hdmi_sys_power(hdmi, false);
> +
> +	if (!hdmi->plat_data->phy_configs)
> +		goto out;

[Severity: Medium]
Should inno_hdmi_standby() and inno_hdmi_config_video_timing() also skip
the integrated-PHY register writes when hdmi->plat_data->phy_configs is
NULL?

inno_hdmi_standby() (called from inno_hdmi_init_hw() at probe and
inno_hdmi_bridge_atomic_disable() on disable) still unconditionally writes
to the same HDMI_PHY_DRIVER, HDMI_PHY_PRE_EMPHASIS, HDMI_PHY_CHG_PWR, and
HDMI_PHY_SYS_CTL registers that inno_hdmi_power_up() now skips restoring.
inno_hdmi_config_video_timing() likewise still writes to
HDMI_PHY_PRE_DIV_RATIO, HDMI_PHY_FEEDBACK_DIV_RATIO_LOW, and
HDMI_PHY_FEEDBACK_DIV_RATIO_HIGH on modeset.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261106-jh7110-clean-send-v7-0-68f7ea9913db@samsung.com?part=12