Re: [PATCH v12 04/14] s390/vfio-ap: Reset migration state on VFIO_DEVICE_RESET and device close

[sashiko-bot@kernel.org]

> According to the VFIO migration specifications, userspace must issue a
> VFIO_DEVICE_RESET ioctl if a vfio device enters an error state or fails a
> state transition to recover the device and return its migration state to
> RUNNING. This patch adds a function that is called when a VFIO_DEVICE_RESET
> is issued that releases any open migration file buffers and resets the
> migration state to RUNNING.
> 
> The same function is called when the vfio device is closed. The migration
> data is not freed on close because a migration file descriptor can outlive
> the vfio device file descriptor, so the state left over from one open must
> be reset for the next. To do so under the locks required to detach the
> guest, vfio_ap_mdev_unset_kvm() no longer takes the locks itself. Instead,
> vfio_ap_mdev_close_device() takes them using get_update_locks_for_kvm()
> and calls vfio_ap_mdev_unset_kvm() and vfio_ap_reset_migration_state()
> with the locks held. vfio_ap_mdev_unset_kvm() asserts that the locks it
> requires are held.
> 
> Signed-off-by: Anthony Krowiak <akrowiak@linux.ibm.com>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261106152259.1360651-1-akrowiak@linux.ibm.com?part=4