All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Radhey Shyam Pandey" <radhey.shyam.pandey@amd.com>
Cc: devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org,
	robh@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH 1/2] fbdev: xilinxfb: remove the driver
Date: Fri, 06 Nov 2026 17:19:42 +0000	[thread overview]
Message-ID: <sashiko-outbox-201909@kernel.org> (raw)
In-Reply-To: <20261106170902.3656809-2-radhey.shyam.pandey@amd.com>

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] fbdev: xilinxfb: stale CONFIG_FB_XILINX in microblaze
  mmu_defconfig
--

commit dc9c5a7ca88a79ff63fa682655927a4c3e97e183
Author: Radhey Shyam Pandey <radhey.shyam.pandey@amd.com>

fbdev: xilinxfb: remove the driver

This commit removes the obsolete xilinxfb framebuffer driver along with its
Kconfig option and Makefile entry.

> diff --git a/drivers/video/fbdev/Kconfig b/drivers/video/fbdev/Kconfig
> index e8cd8cb76874b..50673b83cb857 100644
> --- a/drivers/video/fbdev/Kconfig
> +++ b/drivers/video/fbdev/Kconfig
> @@ -1620,15 +1620,6 @@ config FB_PS3_DEFAULT_SIZE_M
>  	  The default value can be overridden on the kernel command line
>  	  using the "ps3fb" option (e.g. "ps3fb=9M");
>  
> -config FB_XILINX
> -	tristate "Xilinx frame buffer support"
> -	depends on FB && (MICROBLAZE || ARCH_ZYNQ || ARCH_ZYNQMP)
> -	select FB_IOMEM_HELPERS
> -	help
> -	  Include support for the Xilinx ML300/ML403 reference design
> -	  framebuffer. ML300 carries a 640*480 LCD display on the board,
> -	  ML403 uses a standard DB15 VGA connector.
> -
>  config FB_GOLDFISH
>  	tristate "Goldfish Framebuffer"
>  	depends on FB

[Severity: Low]
Should CONFIG_FB_XILINX=y also be removed from
arch/microblaze/configs/mmu_defconfig?  Leaving it there triggers an
unknown symbol warning when configuring mmu_defconfig with W=c.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261106170902.3656809-1-radhey.shyam.pandey@amd.com?part=1

  reply	other threads:[~2026-11-06 17:19 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-06 17:09 [PATCH 0/2] fbdev: remove the Xilinx framebuffer driver Radhey Shyam Pandey
2026-11-06 17:09 ` [PATCH 1/2] fbdev: xilinxfb: remove the driver Radhey Shyam Pandey
2026-11-06 17:19   ` sashiko-bot [this message]
2026-11-09 13:47   ` Krzysztof Kozlowski
2026-11-10  3:55     ` Pandey, Radhey Shyam
2026-11-10 23:16       ` Helge Deller
2026-11-06 17:09 ` [PATCH 2/2] dt-bindings: xilinx: Remove description for framebuffer IP Radhey Shyam Pandey
2026-11-09 13:46   ` Krzysztof Kozlowski
2026-11-09  7:29 ` [PATCH 0/2] fbdev: remove the Xilinx framebuffer driver Michal Simek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-201909@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=radhey.shyam.pandey@amd.com \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.