From: sashiko-bot@kernel.org
To: "Joonho Lee" <mynameisjune111@gmail.com>, linux-sound@vger.kernel.org
Cc: virtualization@lists.linux.dev,
"Michael S. Tsirkin" <mst@redhat.com>,
"Eugenio Perez" <eperezma@redhat.com>
Subject: Re: [PATCH v19 06/12] ALSA: virtio: Retain queued messages through device reset
Date: Fri, 06 Nov 2026 17:48:37 +0000 [thread overview]
Message-ID: <sashiko-outbox-201969@kernel.org> (raw)
In-Reply-To: <20261106161838.94308-7-mynameisjune111@gmail.com>
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] ALSA: virtio: misplaced prose and inaccurate event_msgs claim in
commit log
--
commit 32df18a5fa7d41786115812b07c44152d5805142
Author: Joonho Lee <mynameisjune111@gmail.com>
ALSA: virtio: Retain queued messages through device reset
This commit keeps control and PCM virtqueue buffers alive until after
device reset and synchronizes event virtqueue callbacks during teardown
and restore.
> Fixes: 9d45e514da88 ("ALSA: virtio: handling control messages")
>
> Track virtqueue initialization across partial restore so rollback deletes only queues created by the current attempt. Clear freed event-message ownership before a later remove can reclaim it.
> Signed-off-by: Joonho Lee <mynameisjune111@gmail.com>
[Severity: Low]
This paragraph is placed inside the trailer block after the Fixes: tag
instead of in the commit message body, and its second sentence does not
match the diff. The patch does not change snd->event_msgs handling in
virtsnd_freeze() or virtsnd_remove().
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261106161838.94308-1-mynameisjune111@gmail.com?part=6
next prev parent reply other threads:[~2026-11-06 17:48 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-06 16:18 [PATCH v19 00/12] ALSA: virtio: fix capture accounting Joonho Lee
2026-11-06 16:18 ` [PATCH v19 01/12] ALSA: pcm: mark stop-threshold accesses for capture policy sampling Joonho Lee
2026-11-06 16:28 ` sashiko-bot
2026-11-06 16:18 ` [PATCH v19 02/12] ALSA: pcm: report partial progress under the stream lock Joonho Lee
2026-11-06 16:30 ` sashiko-bot
2026-11-06 16:18 ` [PATCH v19 03/12] ALSA: pcm: add an optional reset operation " Joonho Lee
2026-11-06 16:35 ` sashiko-bot
2026-11-06 16:18 ` [PATCH v19 04/12] ALSA: virtio: Propagate PCM send failures through ACK Joonho Lee
2026-11-06 17:01 ` sashiko-bot
2026-11-06 16:18 ` [PATCH v19 05/12] ALSA: virtio: Recover PCM state after a failed start Joonho Lee
2026-11-06 17:26 ` sashiko-bot
2026-11-06 16:18 ` [PATCH v19 06/12] ALSA: virtio: Retain queued messages through device reset Joonho Lee
2026-11-06 17:48 ` sashiko-bot [this message]
2026-11-06 16:18 ` [PATCH v19 07/12] ALSA: virtio: validate indirect capture appl_ptr accounting Joonho Lee
2026-11-06 18:19 ` sashiko-bot
2026-11-06 16:18 ` [PATCH v19 08/12] ALSA: virtio: Keep control payloads alive through DMA completion Joonho Lee
2026-11-06 18:29 ` sashiko-bot
2026-11-06 16:18 ` [PATCH v19 09/12] ALSA: virtio: wait through signals for PCM teardown Joonho Lee
2026-11-06 18:45 ` sashiko-bot
2026-11-06 16:18 ` [PATCH v19 10/12] ALSA: virtio: serialize staged capture lifecycle and defer paused XRUNs Joonho Lee
2026-11-06 19:01 ` sashiko-bot
2026-11-06 16:18 ` [PATCH v19 11/12] ALSA: virtio: prioritize staged capture period work Joonho Lee
2026-11-06 19:04 ` sashiko-bot
2026-11-06 16:18 ` [PATCH v19 12/12] docs: describe virtio-sound capture options Joonho Lee
2026-11-06 19:14 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-201969@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=eperezma@redhat.com \
--cc=linux-sound@vger.kernel.org \
--cc=mst@redhat.com \
--cc=mynameisjune111@gmail.com \
--cc=sashiko-reviews@lists.linux.dev \
--cc=virtualization@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.