All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: selinux@vger.kernel.org
Subject: Re: [PATCH] selinux: check MAP_SHARED_VALIDATE mappings as shared
Date: Fri, 06 Nov 2026 18:33:16 +0000	[thread overview]
Message-ID: <sashiko-outbox-202042@kernel.org> (raw)
In-Reply-To: <20261106182913.15233-1-stephen.smalley.work@gmail.com>

> selinux_mmap_file() only recognizes MAP_SHARED as a shared mapping,
> but MAP_SHARED_VALIDATE is also a shared mapping type. The mmap flags
> reach this hook before the mm code processes the mapping type.
> 
> Consequently, a writable MAP_SHARED_VALIDATE mapping was failing to
> check the file write permission at mmap time, and a writable
> executable file mapping was wrongly checking process execmem
> permission as if it were private.
> 
> Link: https://github.com/SELinuxProject/selinux-kernel/issues/78
> Fixes: 1c9725974074 ("mm: introduce MAP_SHARED_VALIDATE, a mechanism to safely define new mmap flags")
> Signed-off-by: Stephen Smalley <stephen.smalley.work@gmail.com>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261106182913.15233-1-stephen.smalley.work@gmail.com?part=1


  reply	other threads:[~2026-11-06 18:33 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-06 18:29 [PATCH] selinux: check MAP_SHARED_VALIDATE mappings as shared Stephen Smalley
2026-11-06 18:33 ` sashiko-bot [this message]
2026-11-09 23:32 ` Paul Moore

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-202042@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=selinux@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.